From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B44DCCA47B for ; Sat, 2 Jul 2022 11:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbiGBL4g (ORCPT ); Sat, 2 Jul 2022 07:56:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbiGBL4e (ORCPT ); Sat, 2 Jul 2022 07:56:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4184213F0D for ; Sat, 2 Jul 2022 04:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656762992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cwZGWyzbjndeRVONcRo/Y/Xi6a7qOfJRRZZ6iABpQ64=; b=PLwNShmg41MeYHWwlaHWngpK4TdhD4DCpRPT43Esyl+gM8LEF+3NqUdg7QPriyhqFgWFLr VBlooAUUyaEwn7GO9otG/RA1kkVX7T1URcCeTxNUT7ptnbRIHIRJG1IA5aSemOSJrsurPV t/9zRd2r6xyudmYpxuE9+7PLV8jGR6Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-195-IHCWSa3HPTOdIUIYIaJdew-1; Sat, 02 Jul 2022 07:56:31 -0400 X-MC-Unique: IHCWSa3HPTOdIUIYIaJdew-1 Received: by mail-wm1-f71.google.com with SMTP id v123-20020a1cac81000000b003a02a3f0beeso15513wme.3 for ; Sat, 02 Jul 2022 04:56:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cwZGWyzbjndeRVONcRo/Y/Xi6a7qOfJRRZZ6iABpQ64=; b=hZ2ZiFnbUq4FkmmxqVKBG+UGPer2dx7ogW6mz1eLdNUxeukTjkRHw4V1UXK6TlPhXH J/G2x4CSQCYfCjFWnzZAppzV7N6iFajRLVw8bP8pXu1Vqx4Pe9wZFQK06rknAaSeOt5u AOsNEgqwnbHbDI/yYcMwrIi1W3AafslELYT/BaB887kz+3C75JsN7NCjenzE3FSu1h/p 5V7nTF08smH2XBr7ipbVM9FUYSOtxFpVNPCnI4qGW45vQeQm1uwkhEXy/kEDJVfmdS8q 6sVIf75SInjIdvod+/SUvTBZnZU3a6ONlt53AA2srJ8KIFsHgRHfRslSZlF99EEva0Ff Xbaw== X-Gm-Message-State: AJIora/GedF0eqZ9aoFa1aRqH/XM/rzUgAGZsS2LW6Ci4v66axI+Uwpx u8vkScvYGcMR/BdDgbz+1lu2vfoXctYR6A1/MyzDiyecu+8i86gQVeCHY4cefvV2Vy8MzFagnx9 NAkHafPfA3+mOuKNZeAU7GWoV X-Received: by 2002:a05:600c:1d96:b0:3a0:30b6:bb1a with SMTP id p22-20020a05600c1d9600b003a030b6bb1amr22390016wms.93.1656762989839; Sat, 02 Jul 2022 04:56:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uk1mCSCBDnIRoFf17fUzrFaDhgaShQwBHJ3hzA8TaQPISsd83pmv8uOjG8mUc6UBeHaesGRw== X-Received: by 2002:a05:600c:1d96:b0:3a0:30b6:bb1a with SMTP id p22-20020a05600c1d9600b003a030b6bb1amr22389983wms.93.1656762989620; Sat, 02 Jul 2022 04:56:29 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c19d400b0039c4f53c4fdsm12403602wmq.45.2022.07.02.04.56.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 04:56:29 -0700 (PDT) Message-ID: <9185aadb-e459-00fe-70be-3675f6f3ef4c@redhat.com> Date: Sat, 2 Jul 2022 13:56:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 0/9] drm: selftest: Convert to KUnit Content-Language: en-US To: =?UTF-8?Q?Ma=c3=adra_Canal?= , Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, mwen@igalia.com, andrealmeid@riseup.net, siqueirajordao@riseup.net, Trevor Woerner , leandro.ribeiro@collabora.com, n@nfraprado.net, Daniel Vetter , Shuah Khan , David Airlie , Maxime Ripard , Thomas Zimmermann , michal.winiarski@intel.com, =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , David Gow , Daniel Latypov , brendanhiggins@google.com Cc: kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20220630004611.114441-1-maira.canal@usp.br> From: Javier Martinez Canillas In-Reply-To: <20220630004611.114441-1-maira.canal@usp.br> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/30/22 02:46, Maíra Canal wrote: > Hi everyone, > > Here is the v3 of the conversion of selftests to KUnit. Since the v2, there > have been minor fixes. drm_format_test received the biggest change: the > KUNIT_EXPECT_FALSE and KUNIT_EXPECT_TRUE macros were changed to KUNIT_EXPECT_EQ, > as suggested by Daniel. > > Most of all, the patches were rebased on top of the recently applied patches > for drm_format_helper tests (8f456104915f), in order to avoid conflicts when > applying the tests. > > Thanks for your attention and any feedback is welcomed! > > Best Regards, > - Maíra Canal > Thanks a lot for working on this! The patches look good to me, I just had some minor comments. If you re-spin, I think that we can just push the whole series to drm-misc since the patches have been in the mailing list for some time and have already been tested/reviewed. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD1EBC433EF for ; Sat, 2 Jul 2022 11:56:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0473818A828; Sat, 2 Jul 2022 11:56:34 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BC0618B0AE for ; Sat, 2 Jul 2022 11:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656762992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cwZGWyzbjndeRVONcRo/Y/Xi6a7qOfJRRZZ6iABpQ64=; b=PLwNShmg41MeYHWwlaHWngpK4TdhD4DCpRPT43Esyl+gM8LEF+3NqUdg7QPriyhqFgWFLr VBlooAUUyaEwn7GO9otG/RA1kkVX7T1URcCeTxNUT7ptnbRIHIRJG1IA5aSemOSJrsurPV t/9zRd2r6xyudmYpxuE9+7PLV8jGR6Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-70-bJZ4B91tN7enmQBsc2TwXg-1; Sat, 02 Jul 2022 07:56:31 -0400 X-MC-Unique: bJZ4B91tN7enmQBsc2TwXg-1 Received: by mail-wm1-f70.google.com with SMTP id 130-20020a1c0288000000b003a18127d11aso1349127wmc.6 for ; Sat, 02 Jul 2022 04:56:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cwZGWyzbjndeRVONcRo/Y/Xi6a7qOfJRRZZ6iABpQ64=; b=2SdUULMKlyI03KfnAEK2j4ZSOOd+k6UXFD9HdmnGrYidV1rkUHsxpuzWSudtcpGskH inQcLMB8EvNG44QhnLJdQ4q+0XN0C+mAod3PPkFeEdZM0kZk+dmj8CGrb5uDOlNwe8nj ki2c2TpK7KMvkr0ITeCpb5VkN9yzEbxOdSU6Eq5wlprnCoOPs8SLecmTTDsW0VVYLFnR Sm1j3MbNQOGDjMPIfVSBA6ipgDgUBsMG3fRsHkUQAgvq/jxaISzhcFohmAAXoNvAWIC1 R/Yvjcgme+OEqJ8Il1MhkVWbbQv8BW+BFnh0FfXKZOmWTxE6/+CaS1CKw9HeSxt45Lc6 0RCA== X-Gm-Message-State: AJIora9861eZniD1mMsk8S6tCUt7gn9UAFNQccZN4J4/yiNMmxjl0ztD iZokZUmf3Npj69o4LZnXIFM1F3Vvu+vpUjOxKRGYQ1sNQHTpEmuQH45K5xKUsCkuw+yhyZtAyi5 sykVp0D+feI1row+1BHvshV8fLsdB X-Received: by 2002:a05:600c:1d96:b0:3a0:30b6:bb1a with SMTP id p22-20020a05600c1d9600b003a030b6bb1amr22390000wms.93.1656762989837; Sat, 02 Jul 2022 04:56:29 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uk1mCSCBDnIRoFf17fUzrFaDhgaShQwBHJ3hzA8TaQPISsd83pmv8uOjG8mUc6UBeHaesGRw== X-Received: by 2002:a05:600c:1d96:b0:3a0:30b6:bb1a with SMTP id p22-20020a05600c1d9600b003a030b6bb1amr22389983wms.93.1656762989620; Sat, 02 Jul 2022 04:56:29 -0700 (PDT) Received: from [192.168.1.129] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id u20-20020a05600c19d400b0039c4f53c4fdsm12403602wmq.45.2022.07.02.04.56.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 04:56:29 -0700 (PDT) Message-ID: <9185aadb-e459-00fe-70be-3675f6f3ef4c@redhat.com> Date: Sat, 2 Jul 2022 13:56:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 0/9] drm: selftest: Convert to KUnit To: =?UTF-8?Q?Ma=c3=adra_Canal?= , Isabella Basso , magalilemes00@gmail.com, tales.aparecida@gmail.com, mwen@igalia.com, andrealmeid@riseup.net, siqueirajordao@riseup.net, Trevor Woerner , leandro.ribeiro@collabora.com, n@nfraprado.net, Daniel Vetter , Shuah Khan , David Airlie , Maxime Ripard , Thomas Zimmermann , michal.winiarski@intel.com, =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , David Gow , Daniel Latypov , brendanhiggins@google.com References: <20220630004611.114441-1-maira.canal@usp.br> From: Javier Martinez Canillas In-Reply-To: <20220630004611.114441-1-maira.canal@usp.br> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 6/30/22 02:46, Maíra Canal wrote: > Hi everyone, > > Here is the v3 of the conversion of selftests to KUnit. Since the v2, there > have been minor fixes. drm_format_test received the biggest change: the > KUNIT_EXPECT_FALSE and KUNIT_EXPECT_TRUE macros were changed to KUNIT_EXPECT_EQ, > as suggested by Daniel. > > Most of all, the patches were rebased on top of the recently applied patches > for drm_format_helper tests (8f456104915f), in order to avoid conflicts when > applying the tests. > > Thanks for your attention and any feedback is welcomed! > > Best Regards, > - Maíra Canal > Thanks a lot for working on this! The patches look good to me, I just had some minor comments. If you re-spin, I think that we can just push the whole series to drm-misc since the patches have been in the mailing list for some time and have already been tested/reviewed. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat