From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393AbeEBL4I convert rfc822-to-8bit (ORCPT ); Wed, 2 May 2018 07:56:08 -0400 Received: from hermes.aosc.io ([199.195.250.187]:47832 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbeEBL4F (ORCPT ); Wed, 2 May 2018 07:56:05 -0400 Date: Wed, 02 May 2018 19:55:25 +0800 In-Reply-To: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-3-jagan@amarulasolutions.com> <20180502113250.5i2eyzv237t5oyl6@flea> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Subject: Re: [linux-sunxi] Re: [PATCH 02/21] arm64: dts: allwinner: a64: Add DE2 CCU To: linux-arm-kernel@lists.infradead.org, Jagan Teki CC: Mark Rutland , devicetree , Jernej Skrabec , Maxime Ripard , Catalin Marinas , Michael Turquette , linux-sunxi , Will Deacon , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Chen-Yu Tsai , Rob Herring , Jagan Teki , Michael Trimarchi , linux-clk@vger.kernel.org From: Icenowy Zheng Message-ID: <918A5AB7-E83F-40BD-9C4C-772230F798CF@aosc.io> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2018年5月2日 GMT+08:00 下午7:50:19, Jagan Teki 写到: >On Wed, May 2, 2018 at 5:04 PM, Icenowy Zheng wrote: >> >> >> 于 2018年5月2日 GMT+08:00 下午7:32:50, Maxime Ripard > 写到: >>>On Mon, Apr 30, 2018 at 05:10:39PM +0530, Jagan Teki wrote: >>>> DE2 in A64 has clock control unit and behavior is >>>> same like H3/H5, so reuse the same in A64. >>>> >>>> Signed-off-by: Jagan Teki >>>> --- >>>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> index 1b2ef28c42bd..67b80bbe5bf5 100644 >>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> @@ -43,9 +43,11 @@ >>>> */ >>>> >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> +#include >>>> >>>> / { >>>> interrupt-parent = <&gic>; >>>> @@ -168,6 +170,19 @@ >>>> #size-cells = <1>; >>>> ranges; >>>> >>>> + display_clocks: clock@1000000 { >>>> + compatible = "allwinner,sun50i-a64-de2-clk", >>>> + "allwinner,sun50i-h5-de2-clk"; >>> >>>The A64 was released before the H5, so that should be the other way >>>around. >>> >>>> + reg = <0x01000000 0x100000>; >>>> + clocks = <&ccu CLK_DE>, >>>> + <&ccu CLK_BUS_DE>; >>>> + clock-names = "mod", >>>> + "bus"; >>>> + resets = <&ccu RST_BUS_DE>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>> >>>So it turns out we don't need the SRAM to access the CCU driver? >> >> As now U-Boot claims SRAM, people may forget thus :-( > >I've sent few mails about how we represent de2 with sram_c [1] but >none response after. Can I get further inputs so-that we can include >sram_c in proper manner. Please wait for the SRAMC driver sent by Chen-Yu (and commited by me) and the DE2 bus driver pending for the SRAMC part. > >[1] https://patchwork.kernel.org/patch/10289737/ > >Jagan. > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: icenowy@aosc.io (Icenowy Zheng) Date: Wed, 02 May 2018 19:55:25 +0800 Subject: [linux-sunxi] Re: [PATCH 02/21] arm64: dts: allwinner: a64: Add DE2 CCU In-Reply-To: References: <20180430114058.5061-1-jagan@amarulasolutions.com> <20180430114058.5061-3-jagan@amarulasolutions.com> <20180502113250.5i2eyzv237t5oyl6@flea> Message-ID: <918A5AB7-E83F-40BD-9C4C-772230F798CF@aosc.io> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org ? 2018?5?2? GMT+08:00 ??7:50:19, Jagan Teki ??: >On Wed, May 2, 2018 at 5:04 PM, Icenowy Zheng wrote: >> >> >> ? 2018?5?2? GMT+08:00 ??7:32:50, Maxime Ripard > ??: >>>On Mon, Apr 30, 2018 at 05:10:39PM +0530, Jagan Teki wrote: >>>> DE2 in A64 has clock control unit and behavior is >>>> same like H3/H5, so reuse the same in A64. >>>> >>>> Signed-off-by: Jagan Teki >>>> --- >>>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 15 +++++++++++++++ >>>> 1 file changed, 15 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> index 1b2ef28c42bd..67b80bbe5bf5 100644 >>>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>>> @@ -43,9 +43,11 @@ >>>> */ >>>> >>>> #include >>>> +#include >>>> #include >>>> #include >>>> #include >>>> +#include >>>> >>>> / { >>>> interrupt-parent = <&gic>; >>>> @@ -168,6 +170,19 @@ >>>> #size-cells = <1>; >>>> ranges; >>>> >>>> + display_clocks: clock at 1000000 { >>>> + compatible = "allwinner,sun50i-a64-de2-clk", >>>> + "allwinner,sun50i-h5-de2-clk"; >>> >>>The A64 was released before the H5, so that should be the other way >>>around. >>> >>>> + reg = <0x01000000 0x100000>; >>>> + clocks = <&ccu CLK_DE>, >>>> + <&ccu CLK_BUS_DE>; >>>> + clock-names = "mod", >>>> + "bus"; >>>> + resets = <&ccu RST_BUS_DE>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>> >>>So it turns out we don't need the SRAM to access the CCU driver? >> >> As now U-Boot claims SRAM, people may forget thus :-( > >I've sent few mails about how we represent de2 with sram_c [1] but >none response after. Can I get further inputs so-that we can include >sram_c in proper manner. Please wait for the SRAMC driver sent by Chen-Yu (and commited by me) and the DE2 bus driver pending for the SRAMC part. > >[1] https://patchwork.kernel.org/patch/10289737/ > >Jagan. > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel at lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel