From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tariq Toukan Subject: Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating Date: Thu, 25 Jan 2018 11:54:31 +0200 Message-ID: <918db4ec-8c3c-aafa-4be6-0e00a99632e2@mellanox.com> References: <1515728542-3060-1-git-send-email-jianchao.w.wang@oracle.com> <20180112163247.GB15974@ziepe.ca> <1515775567.131759.42.camel@gmail.com> <53b1ac4d-a294-eb98-149e-65d7954243da@oracle.com> <1516376999.3606.39.camel@gmail.com> <339a7156-9ef1-1f3c-30b8-3cc3558d124e@mellanox.com> <532b4d71-e2eb-35f3-894e-1c3288e7bc3f@oracle.com> <1516852543.3715.43.camel@gmail.com> <89066a75-43db-0f62-f171-70b0abaa8ea0@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <89066a75-43db-0f62-f171-70b0abaa8ea0-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "jianchao.wang" , Eric Dumazet , Tariq Toukan , Jason Gunthorpe Cc: junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Saeed Mahameed List-Id: linux-rdma@vger.kernel.org On 25/01/2018 8:25 AM, jianchao.wang wrote: > Hi Eric > > Thanks for you kindly response and suggestion. > That's really appreciated. > > Jianchao > > On 01/25/2018 11:55 AM, Eric Dumazet wrote: >> On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: >>> Hi Tariq >>> >>> On 01/22/2018 10:12 AM, jianchao.wang wrote: >>>>>> On 19/01/2018 5:49 PM, Eric Dumazet wrote: >>>>>>> On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: >>>>>>>> Hi Tariq >>>>>>>> >>>>>>>> Very sad that the crash was reproduced again after applied the patch. >>>>> >>>>> Memory barriers vary for different Archs, can you please share more details regarding arch and repro steps? >>>> The hardware is HP ProLiant DL380 Gen9/ProLiant DL380 Gen9, BIOS P89 12/27/2015 >>>> The xen is installed. The crash occurred in DOM0. >>>> Regarding to the repro steps, it is a customer's test which does heavy disk I/O over NFS storage without any guest. >>>> >>> >>> What is the finial suggestion on this ? >>> If use wmb there, is the performance pulled down ? I want to evaluate this effect. I agree with Eric, expected impact is restricted, especially after batching the allocations. >> >> Since https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_davem_net-2Dnext.git_commit_-3Fid-3Ddad42c3038a59d27fced28ee4ec1d4a891b28155&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=c0oI8duFkyFBILMQYDsqRApHQrOlLY_2uGiz_utcd7s&s=E4_XKmSI0B63qB0DLQ1EX_fj1bOP78ZdeYADBf33B-k&e= >> >> we batch allocations, so mlx4_en_refill_rx_buffers() is not called that often. >> >> I doubt the additional wmb() will have serious impact there. >> I will test the effect (it'll be beginning of next week). I'll update so we can make a more confident decision. Thanks, Tariq >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751455AbeAYJyz (ORCPT ); Thu, 25 Jan 2018 04:54:55 -0500 Received: from mail-ve1eur01on0080.outbound.protection.outlook.com ([104.47.1.80]:19902 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751171AbeAYJyu (ORCPT ); Thu, 25 Jan 2018 04:54:50 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=tariqt@mellanox.com; Subject: Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating To: "jianchao.wang" , Eric Dumazet , Tariq Toukan , Jason Gunthorpe Cc: junxiao.bi@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Saeed Mahameed References: <1515728542-3060-1-git-send-email-jianchao.w.wang@oracle.com> <20180112163247.GB15974@ziepe.ca> <1515775567.131759.42.camel@gmail.com> <53b1ac4d-a294-eb98-149e-65d7954243da@oracle.com> <1516376999.3606.39.camel@gmail.com> <339a7156-9ef1-1f3c-30b8-3cc3558d124e@mellanox.com> <532b4d71-e2eb-35f3-894e-1c3288e7bc3f@oracle.com> <1516852543.3715.43.camel@gmail.com> <89066a75-43db-0f62-f171-70b0abaa8ea0@oracle.com> From: Tariq Toukan Message-ID: <918db4ec-8c3c-aafa-4be6-0e00a99632e2@mellanox.com> Date: Thu, 25 Jan 2018 11:54:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <89066a75-43db-0f62-f171-70b0abaa8ea0@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: AM5PR0102CA0006.eurprd01.prod.exchangelabs.com (2603:10a6:206::19) To DB5PR05MB1142.eurprd05.prod.outlook.com (2a01:111:e400:5812::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36f68820-7534-47d1-20c4-08d563d9ab23 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(2017052603307)(7153060)(7193020);SRVR:DB5PR05MB1142; X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1142;3:MQDPkBAkRu+ixy/eXDzF5l/rCv7grvWVywPAYUEeTE0ImOLcOjNgdtsaeZzmc4TH5CYZw2XLmSefOLeFin3+dWlRQ6TVKW1+uvHOGHVM6m1ZfiIm1WT5gEChs//5AXtjHu2e0bgltLUFtpT+YdMhIv6GJRawZZGczK/4xKGYuiwtTwWY/FWqI+eu4aCG7sz+IFOWrntBWOpxfQNernlRL0ahIk64Xhk6kdOXEX+KW4Dp05ap/KA8PTAGtKBqfX1a;25:AtZIztD2U/FniUhmAX8AMIWXsDa0VDKknxt82NgqsLD6xQOA1pAru1R+tRFZ92Ee/VwCzRyDR1D21Tcoc5Jp9A9KBqt8c+onM11RC7mrnaSpLnNgqMLV5/cTCG+O5+RtnhxRy58H39UjbfydFm00w8DFYUZB+ASGm8sLiatFizFns2krWrCU+jjWraGI/atKk87JkOwsCaltr+wx/t8BMoCgQr0N1MyZHwFx+u24zcm6FNmvlAHikt72Ny9M/mEa07tfkDoJzG+YtpMkLQOegDvFy87/aJ0AOaIwrIF2MmfsuRZoA44bCBVodUAno9eU692Mtrx5kP92/lHear0tBA==;31:/z9wWTjZnqHcx0Ew9tv9h6cnkbdm6lA+uHtPvzGnd0BW4ag/PBM0IK24qON0URx+VcePzaMdqL4o/KtvYUqhu2hyRTDvp9kBSHQiupzOgw+6qVRgDTUfcLKlUVy3d/NaJ8FqQZ+DPsvJ/sAlsvjEyNtTJOckTv+LSnwNxp3MRTUQBo4LOUZRG4ovU9Nai8m9QVIWXYboGWowyuug0OjSY/d4KxEmUZU+RxI/c7jdPc0= X-MS-TrafficTypeDiagnostic: DB5PR05MB1142: X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1142;20:JyLk2ESf/AUFstJjHko5oPCMAg0z4zp4S6XILOze54KoWUHZLJuSqKDUcKpOOY+QJt1Mf22iNC5Un0oQZ0koqR8AqF0BM5+r5pxdg6IEgJKwr72YT1tI49sz5Po24dMYryH09qmMveQsJkFrUtQ3Cjpj8/SdqCMl7nEsBs/tbUv0IVLeqaot/cjgMpvscTGFJAyVVfI9pH+GjriYFosVGrf5MZkU0ETXh5kfm7HxZPOwDYPjFgVdHU1L84jvh/l37RMYO+AAVdhFtkp5Chkwtf8BmraUugHZD9hXauKgdU7d2dsKme0oMvhDZnsd2CGNTN11d3nIxoE+22LEGwDTaOeSvsjDKWf6xVgvRWFN0fwMhyu9I86VJF0Utuq3xtgBzrXhxxUvRKuFmYyVfPe5eCKZDX0bpIGJBwriOa4QUw0GnGwuTOEIdOZkmzn+c0CWB+dTe83prYPMDZ/tHaGuAeR5o/mJt//IjM1B/1Ji2vCHFH8+17YMS0dLD6zRyRit;4:XHlJHKWhXl1tYwXonF768G+7qrcxQrppUP1eNfSwwPHtpGyLXydd2KrsI4MbXwVjgMSOcAKyknaiIFqLlyAHC4f3OeCT5WQOTlc5KLxREhGUddGVXERHLj9XRTEvIzXPWWgvbY/0j5eJsC9d9SymUT/oekrxjWC71WqH7v//90fXQQvrBmiuUP0t4kJ6toZ0AoNKJBW+t78AkuzyKwXWpqIdA0E8Dp1PpFL0BIq1KdsOvxOOsMnD95tbfF/gP5nWdM/hTjWtcfBB7RZ1zJr7AFSgOaGfq0HfsR8cBRB7S5AAFn6s56zG4OWP8QoT7iLO3OfdDUPoHxhIeWmkzp0r9w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(10436049006162)(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041288)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011);SRVR:DB5PR05MB1142;BCL:0;PCL:0;RULEID:;SRVR:DB5PR05MB1142; X-Forefront-PRVS: 0563F2E8B7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6049001)(39380400002)(376002)(39860400002)(366004)(346002)(396003)(199004)(377424004)(189003)(65806001)(81156014)(110136005)(67846002)(8676002)(65956001)(81166006)(77096007)(97736004)(83506002)(316002)(8936002)(31686004)(36756003)(93886005)(66066001)(47776003)(16526018)(58126008)(65826007)(5660300001)(6306002)(6666003)(68736007)(6486002)(2950100002)(25786009)(229853002)(575784001)(53936002)(16576012)(86362001)(4326008)(53546011)(3846002)(2906002)(107886003)(31696002)(59450400001)(6116002)(26005)(230700001)(106356001)(64126003)(6246003)(105586002)(7736002)(305945005)(76176011)(478600001)(966005)(39060400002)(386003)(52146003)(52116002)(2486003)(23676004)(50466002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB5PR05MB1142;H:[10.8.0.245];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA1TUIxMTQyOzIzOm1OWVVWVElvV2loMFpjL0x4N002Szh3Z2hs?= =?utf-8?B?anVwNFFZN0J4U3N4UTZJZlYvd1NnUklId3NuQUNTTHQ5WlNQb3VhTnEvWVZ2?= =?utf-8?B?bmlnZU9lK0tzTE5qVmlQN0ZUN1UwU1FNVGs1YTFsSDdiWE9KamN2T091TG9I?= =?utf-8?B?K1pkdWpUYkhyNHNpMjZJajk4aFIyOFpreWpiTHpIL2phMzJDek5kUERSV2NB?= =?utf-8?B?ZHhndGROMUpsQzNqV1BnQnZaRWJiMmZ1UmdGbHBIU2pJdFVpYUVaWWxiMHZn?= =?utf-8?B?TE4xUXA0QUdScHQvWGl1Znp5citlU1lRSTMwbVZzaGsxRTM4V2NvSGhJVmJH?= =?utf-8?B?Q242bk0yQm5ibFJlOWh0RGo5dHV1aEVKa2hCZGI2TWxIL1dOUUZCQ2xlY29R?= =?utf-8?B?cG9XOGtTdEprclQxOFZHZENYd2YzUWdXb0RWalZHVThkK1JRQjZ5Uy83YzZJ?= =?utf-8?B?Ym1acWtQNDhTN1F2cjBPVWhLK3lMSUlFSG9iYnNJbHBOb09SWHAwRGo3OEFV?= =?utf-8?B?UUlWT0VYQVFUcWZSL3ZrY2hEbzdUQmFwaUZCYXlwVHN4V0RRV0NpSUF4RndC?= =?utf-8?B?WWZtK1lzSlp3MkZQYWpYek5vdkdjTHI5N1FHU2p1anNzM29lQmNPMjVQRkxi?= =?utf-8?B?ZFVwV3o1QUJIRXdTWjR0a2NZMTg4T2Q5RUJ4cGRRRHYxMkVpUVUySjk5NVlT?= =?utf-8?B?Vk1VaHlwVGEyLzlDWWx1b3JBRFE1WDNQQms0QnMxOFBWOWZ4UndXVWtkOGtZ?= =?utf-8?B?ZG94Y05hS1h2WHpPQ01aVm5Rdm9jMDNtRXlTNkNENmxGaVYzYzhmNFpkZ3M2?= =?utf-8?B?Tk90YXFIS0ZaSUJsbFNDaG54ekptc2xNV0M1bWI4RDJVRStYMVZuclN4UW1z?= =?utf-8?B?S1lsdTgybnJBYzB3VnQ1UVhka3kzQjQ5RWw5akFDOXEwRXE5cXJ4NmlYWmli?= =?utf-8?B?dTZxYWs0UkQzU2xUcTBtTURNenJEQ1B0aVh5RkNodlNJWG9KWCthb2Y1NUlT?= =?utf-8?B?cDFaK2xHS3ZuV2l4NlNrN0xmTXluVERWMUMzeWtFTEtsdC9TSFY4V0VHNUdz?= =?utf-8?B?ckVOaFFBdHJsL2pHL213Y2RLakhvcENOQzJ4K2J2QVhaY0t0Q1pzM1BnRHdL?= =?utf-8?B?NlFuWTJpeUd1R3gySXduSndBVHNsRUZ3VkQzVDZ3dDNGc3lZTDI0MExCeWhM?= =?utf-8?B?TFV4aE5XWWw2cU8rRkJkRFV5K2tOYW5nMzl4QzNobHVXNTJYZFAxMktuUm5K?= =?utf-8?B?UkFFSzIzaHBIc0VRaXVqYlljYVpFM1lrRGtZY2dvaVphdmlpWGdjWWdlMUNC?= =?utf-8?B?VStSVUdNWFhhbXE2dzZEWVpOd051aWNmR25ZQlNTVldpUi8wQ0FOb1ovVTEz?= =?utf-8?B?UnNVR2JLTnZhSEZQeWpEVmFpdXY2SkszaXQ1Tmx1bFNFZzdhTHhmUytPa2FZ?= =?utf-8?B?Mk9lMzF5MDl3MjQ4MDZ1ZnhabEJWRHduVUNxUXB4K0FCbWh0ckxmQjdRWmth?= =?utf-8?B?SW9SejgxQ2wyVXRKM0hqemNLRGlaNnN4S3ZqYURheUx5Rk1qdUVhWllkV1BD?= =?utf-8?B?dnd0SEdPT1oxeThSdW9YNzRldEFBTkZvUVhtVDJkZ3Nkc1hGaGpCbG0zaDVR?= =?utf-8?B?VlVXd3VQU081bVdwMFIvTExlZnNFTHJJSnJuaHpGeE04aXdzbTcvd2JEaHQr?= =?utf-8?B?VDlYam1TWFVMSERtVGZVSi9NQUhNTE1XVWJLTzdwemVtNGwvV005S1Joampl?= =?utf-8?B?cGFhbk12TTl2TDAyT080Ym82OWptVVlJcEd4RnlGelFya0J1Nk9tY2lVZ2ls?= =?utf-8?B?QmVnV0dVTkVOQ09mZFkybDFzbUd6M3hDMWkzSmxzMkl3bkZqaTdyTnVrQjA3?= =?utf-8?B?OFlKZnVNV2cxVzlMRityNHVjUC9uOElnM3ViRVFYZDlwYXovb1VLWFJ3UzZy?= =?utf-8?B?MTVacUZXZGF3NDE3UU1aSVhBemxwLyt2L1h6c3pzbG5YdTNqdjc1NnA0Z2Fo?= =?utf-8?B?ZkpkSmFqZldhN05JWlJ4ZWN5NHU4VHZBQlBvV3BBb1E4LzFEb240K1ZhVVBI?= =?utf-8?B?YlFjenBQS1ZaMjNnZ3pRS0RvQlB3MXgwZzdEUEFrSXYzNzVqb3VUNGROend6?= =?utf-8?B?WkM5Z2tyOHBxV1IwNUJaYkpWNzVDUHN3Y1hJR3F4djloVmtNZ2krKzg0cVlU?= =?utf-8?Q?ljj/d9V1eqfzw44A9VWXyYqXl+rl8c2zJHV3b3SR+o=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB5PR05MB1142;6:vldf/GFOsl3Y+81QyYfTdujYMK/zEOgNNza1ms4nM2DxUWwndHTEdP0T5PZOuIo1gDQf+BceE0EkqKw/qBfrKgJ7fw/AvgUS2YrYsYOzcBMgnw6pTxWuq2Ho9qra68uY5sKIJELDaMQZ2g4fiXnm2Auh5F7tBX0Bkhe/JYSjwX7PMcPg8s+qo5IvXsVHtDk3EllY8T2NsWXgkNV3fE6maBOO3dFRSpfNe9x/hdKpstZheHPhPRxXh1r3AVMwB3xkTVe7m0IU8o+sISu5muscvec/TFUKmcveYcob+bQskuinUeYFlGvHcnA6zDd2Fx/FO+ZRq1qysrfrjThO0h2SPYZHl1loWdjUP5fbnnjCviU=;5:zrj263tmydbCHo+LY2/UKmecL6pf/WS56M2rvsk9qOTDo2P5yVEuuZ2gTD6cS4vD228nj95W2c2NWn6KHPERcFqnUzVpFuRYSGdAbfTZmtt0YFUpaLgUkwmaFFl49d1db9gLAQwj58AhXpzyDs/E4pRJLXu1TZ2u0fP+DqY65C0=;24:RPxVkxjxFbLxPOxayJPA4rekPwUoxlZlYPBWKbhcqlODpHYG3TqHNHHy6qqrVhHdhKD8vMYVmNWYWe7hCX2mZR8OH8y4CaSjJwOdtKJI2CI=;7:g2Yuu4+1lpVpOUrUSFgv15+ib5V3Wkyn9iFLcfJbTCik6P1PELcmrWJzgaaok0EocaVyOZu0IKQo4xPM3CiXhY9oLSe0loaZAEJOD8kNlS4Jkj5sOcxSUUDJaVTij1kmhwFUtISPRejbuyiCAUrbyh+8IcBTViS49FQGLIgRA3pbeDxJLqYj34bnO5536/binulDZ4iOqJUXvfCGW+dGsyE/b1anJxyK0pZob2I/Il8hYlNZl3P8ffc5oyfe1j4g SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2018 09:54:46.2427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36f68820-7534-47d1-20c4-08d563d9ab23 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR05MB1142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2018 8:25 AM, jianchao.wang wrote: > Hi Eric > > Thanks for you kindly response and suggestion. > That's really appreciated. > > Jianchao > > On 01/25/2018 11:55 AM, Eric Dumazet wrote: >> On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: >>> Hi Tariq >>> >>> On 01/22/2018 10:12 AM, jianchao.wang wrote: >>>>>> On 19/01/2018 5:49 PM, Eric Dumazet wrote: >>>>>>> On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: >>>>>>>> Hi Tariq >>>>>>>> >>>>>>>> Very sad that the crash was reproduced again after applied the patch. >>>>> >>>>> Memory barriers vary for different Archs, can you please share more details regarding arch and repro steps? >>>> The hardware is HP ProLiant DL380 Gen9/ProLiant DL380 Gen9, BIOS P89 12/27/2015 >>>> The xen is installed. The crash occurred in DOM0. >>>> Regarding to the repro steps, it is a customer's test which does heavy disk I/O over NFS storage without any guest. >>>> >>> >>> What is the finial suggestion on this ? >>> If use wmb there, is the performance pulled down ? I want to evaluate this effect. I agree with Eric, expected impact is restricted, especially after batching the allocations. >> >> Since https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_kernel_git_davem_net-2Dnext.git_commit_-3Fid-3Ddad42c3038a59d27fced28ee4ec1d4a891b28155&d=DwICaQ&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=c0oI8duFkyFBILMQYDsqRApHQrOlLY_2uGiz_utcd7s&s=E4_XKmSI0B63qB0DLQ1EX_fj1bOP78ZdeYADBf33B-k&e= >> >> we batch allocations, so mlx4_en_refill_rx_buffers() is not called that often. >> >> I doubt the additional wmb() will have serious impact there. >> I will test the effect (it'll be beginning of next week). I'll update so we can make a more confident decision. Thanks, Tariq >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >