From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751277AbdFFHs5 (ORCPT ); Tue, 6 Jun 2017 03:48:57 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:16531 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750755AbdFFHsz (ORCPT ); Tue, 6 Jun 2017 03:48:55 -0400 Subject: Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id To: Lee Jones , References: <1496567924-4278-1-git-send-email-j-keerthy@ti.com> <20170605103740.g4t3veigzpdzfkxi@dell> <20170606071703.o6dnzu4vjeywpoxn@dell> <9017b16c-e9f3-ea05-4e71-d7920841ce57@ti.com> CC: , , From: Keerthy Message-ID: <918f5112-b200-b5ae-c4d2-c75e5e227e9a@ti.com> Date: Tue, 6 Jun 2017 13:18:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <9017b16c-e9f3-ea05-4e71-d7920841ce57@ti.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 06 June 2017 01:00 PM, Keerthy wrote: > > > On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote: >> On Mon, 05 Jun 2017, Keerthy wrote: >> >>> >>> >>> On Monday 05 June 2017 04:07 PM, Lee Jones wrote: >>>> On Sun, 04 Jun 2017, Keerthy wrote: >>>> >>>>> With the introduction of probe_new function the i2c_device_id >>>>> is no longer needed. Hence the remove the same and use probe_new >>>>> instead of probe. >>>>> >>>>> Keerthy (9): >>>>> mfd: tps65217: Remove redundant i2c_device_id >>>>> mfd: tps65218: Remove redundant i2c_device_id >>>>> mfd: palmas: Remove redundant i2c_device_id >>>>> mfd: lp873x: Remove redundant i2c_device_id >>>>> mfd: lp8788: Remove redundant i2c_device_id >>>>> mfd: lp3943: Remove redundant i2c_device_id >>>>> mfd: tps65086: Remove redundant i2c_device_id >>>>> mfd: tps65090: Remove redundant i2c_device_id >>>>> mfd: tps6586x: Remove redundant i2c_device_id >>>>> >>>>> drivers/mfd/lp3943.c | 11 ++--------- >>>>> drivers/mfd/lp873x.c | 12 ++---------- >>>>> drivers/mfd/lp8788.c | 11 ++--------- >>>>> drivers/mfd/palmas.c | 15 ++------------- >>>>> drivers/mfd/tps65086.c | 12 ++---------- >>>>> drivers/mfd/tps65090.c | 12 ++---------- >>>>> drivers/mfd/tps65217.c | 14 +++----------- >>>>> drivers/mfd/tps65218.c | 9 +++++---- >>>>> drivers/mfd/tps6586x.c | 12 ++---------- >>>> >>>> Are all of these drivers DT only? >>> >>> At least i did not find any platform code calling on to these drivers. >>> No dependency on OF as such. Hence sent these 9. >> >> I can't accept these changes on any drivers which does not depend on >> OF as a hard requirement. > > Okay. So that is a per-requisite. At least palmas, tps65218, lp873x, > tps65217 imho can have the OF dependency. I will post patches for that > and then will resurrect this series. > > Thanks for your feedback. Tony, I do not see any platform specific code for tps65218, tps65217 and palmas. I believe they are all completely Device Tree based. Can i make them depend on OF? It helps me clear up some unused data from their mfd drivers. Regards, Keerthy > > >> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keerthy Subject: Re: [PATCH 0/9] mfd: Remove redundant i2c_device_id Date: Tue, 6 Jun 2017 13:18:50 +0530 Message-ID: <918f5112-b200-b5ae-c4d2-c75e5e227e9a@ti.com> References: <1496567924-4278-1-git-send-email-j-keerthy@ti.com> <20170605103740.g4t3veigzpdzfkxi@dell> <20170606071703.o6dnzu4vjeywpoxn@dell> <9017b16c-e9f3-ea05-4e71-d7920841ce57@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9017b16c-e9f3-ea05-4e71-d7920841ce57@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Lee Jones , tony@atomide.com Cc: milo.kim@ti.com, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Tuesday 06 June 2017 01:00 PM, Keerthy wrote: > > > On Tuesday 06 June 2017 12:47 PM, Lee Jones wrote: >> On Mon, 05 Jun 2017, Keerthy wrote: >> >>> >>> >>> On Monday 05 June 2017 04:07 PM, Lee Jones wrote: >>>> On Sun, 04 Jun 2017, Keerthy wrote: >>>> >>>>> With the introduction of probe_new function the i2c_device_id >>>>> is no longer needed. Hence the remove the same and use probe_new >>>>> instead of probe. >>>>> >>>>> Keerthy (9): >>>>> mfd: tps65217: Remove redundant i2c_device_id >>>>> mfd: tps65218: Remove redundant i2c_device_id >>>>> mfd: palmas: Remove redundant i2c_device_id >>>>> mfd: lp873x: Remove redundant i2c_device_id >>>>> mfd: lp8788: Remove redundant i2c_device_id >>>>> mfd: lp3943: Remove redundant i2c_device_id >>>>> mfd: tps65086: Remove redundant i2c_device_id >>>>> mfd: tps65090: Remove redundant i2c_device_id >>>>> mfd: tps6586x: Remove redundant i2c_device_id >>>>> >>>>> drivers/mfd/lp3943.c | 11 ++--------- >>>>> drivers/mfd/lp873x.c | 12 ++---------- >>>>> drivers/mfd/lp8788.c | 11 ++--------- >>>>> drivers/mfd/palmas.c | 15 ++------------- >>>>> drivers/mfd/tps65086.c | 12 ++---------- >>>>> drivers/mfd/tps65090.c | 12 ++---------- >>>>> drivers/mfd/tps65217.c | 14 +++----------- >>>>> drivers/mfd/tps65218.c | 9 +++++---- >>>>> drivers/mfd/tps6586x.c | 12 ++---------- >>>> >>>> Are all of these drivers DT only? >>> >>> At least i did not find any platform code calling on to these drivers. >>> No dependency on OF as such. Hence sent these 9. >> >> I can't accept these changes on any drivers which does not depend on >> OF as a hard requirement. > > Okay. So that is a per-requisite. At least palmas, tps65218, lp873x, > tps65217 imho can have the OF dependency. I will post patches for that > and then will resurrect this series. > > Thanks for your feedback. Tony, I do not see any platform specific code for tps65218, tps65217 and palmas. I believe they are all completely Device Tree based. Can i make them depend on OF? It helps me clear up some unused data from their mfd drivers. Regards, Keerthy > > >>