From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958FCC4708F for ; Sat, 29 May 2021 12:54:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B4A96120A for ; Sat, 29 May 2021 12:54:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbhE2Mzt (ORCPT ); Sat, 29 May 2021 08:55:49 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2540 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhE2Mzp (ORCPT ); Sat, 29 May 2021 08:55:45 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FshJG1Rk5zYrdp; Sat, 29 May 2021 20:51:26 +0800 (CST) Received: from dggema769-chm.china.huawei.com (10.1.198.211) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Sat, 29 May 2021 20:54:07 +0800 Received: from [10.174.179.215] (10.174.179.215) by dggema769-chm.china.huawei.com (10.1.198.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 29 May 2021 20:54:07 +0800 Subject: Re: [PATCH -next] USB: gadget: f_fs: Remove unneed cast in ffs_prepare_buffer() To: Greg KH CC: , , References: <20210529120408.23456-1-yuehaibing@huawei.com> From: YueHaibing Message-ID: <91983b80-1818-536d-5ea3-5a38c1cb5443@huawei.com> Date: Sat, 29 May 2021 20:54:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.215] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggema769-chm.china.huawei.com (10.1.198.211) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/29 20:11, Greg KH wrote: > On Sat, May 29, 2021 at 08:04:08PM +0800, YueHaibing wrote: >> A coccicheck run provided information like the following. >> >> ./drivers/usb/gadget/function/f_fs.c:3832:9-16: >> WARNING: ERR_CAST can be used with data >> >> ffs_prepare_buffer() should return an ERR_PTR() encoded error >> code on failure. > > It does return such a pointer today, so this statement does not make > much sense :( Yes, it does. This is just to remove explicit casts. > > And is this a v2 patch? What changed from the previous version? Sorry, I forget to add version info. > > thanks, > > greg k-h > . >