From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BB63C433F5 for ; Tue, 19 Apr 2022 12:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352431AbiDSMvm (ORCPT ); Tue, 19 Apr 2022 08:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346663AbiDSMvk (ORCPT ); Tue, 19 Apr 2022 08:51:40 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F5243700E; Tue, 19 Apr 2022 05:48:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650372538; x=1681908538; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cu8ttrZTtozlzi95obzNrvmh7yZOlBdE43QZNQ1x4ME=; b=ZdX5EatRbFR3AZisA9pBT8Lv6NcGcNNf+BHgCIaBikV0bRt7rKmRWg9l AXC1J9dTlvswjM7g1oOanzEr7XesFj93/lpcYoI9coMID1aSvhlyhOTKq b8mREciWJ7IVbNpnxLeBZinvkkM25fsuxJulndqggyp4gWc/b9Ov2ZuSx 2V/6eowtD48b6hsoHS56UfYlXgSAB0kOtyot+TCpP31edkChiASTbqElJ 1n13+F5s8JRW80lwiN/SCwIEGYeyU9BF704DyEPV8dkxvhUsPqmhjapSW xux7YcogQQ+uBMQzZ7iL0BBX2qmF3W/uRHa0eFNfClxyn98eYuxifYzmc g==; X-IronPort-AV: E=McAfee;i="6400,9594,10321"; a="288852895" X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="288852895" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 05:48:58 -0700 X-IronPort-AV: E=Sophos;i="5.90,272,1643702400"; d="scan'208";a="554713824" Received: from chferrer-mobl.amr.corp.intel.com (HELO [10.209.37.31]) ([10.209.37.31]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 05:48:57 -0700 Message-ID: <9198cc36-67d6-9365-5d18-f23ba4075151@linux.intel.com> Date: Tue, 19 Apr 2022 05:48:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.7.0 Subject: Re: [PATCH v3 4/4] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver Content-Language: en-US To: Borislav Petkov , Kai Huang Cc: Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, Hans de Goede , Mark Gross , "H . Peter Anvin" , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20220415220109.282834-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220415220109.282834-5-sathyanarayanan.kuppuswamy@linux.intel.com> From: Sathyanarayanan Kuppuswamy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/19/22 1:13 AM, Borislav Petkov wrote: > On Tue, Apr 19, 2022 at 07:47:33PM +1200, Kai Huang wrote: >> From this perspective, I am not sure what's the value of having a dedicated >> INTEL_TDX_ATTESTATION Kconfig. The attestation support code should be turned on >> unconditionally when CONFIG_INTEL_TDX_GUEST is on. The code can also be just >> under arch/x86/coco/tdx/ I guess? >> >> But I'll leave this to maintainers. > > Similar story with the unaccepted memory gunk. If it is not going to > be used outside of encrypted guests, why are we polluting our already > insanely humongous Kconfig space with more symbols? > Make sense. We can just go with CONFIG_INTEL_TDX_ATTESTATION. Boris, this is a simple platform driver which adds IOCTL interfaces to allow user space to get TDREPORT and TDQuote support. So, would prefer to leave in platform/x86 or move it to arch/x86/coco/tdx/ ? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer