All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: bertrand.marquis@arm.com, Julien Grall <jgrall@amazon.com>,
	Michal Orzel <michal.orzel@arm.com>
Subject: PING Re: [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel
Date: Mon, 10 May 2021 18:47:19 +0100	[thread overview]
Message-ID: <91ab70b6-3a02-22ab-0a92-3ac3943c828c@xen.org> (raw)
In-Reply-To: <6c8133a5-dc78-083b-0cec-69860e46daf7@xen.org>



On 18/04/2021 19:26, Julien Grall wrote:
> On 12/04/2021 07:45, Michal Orzel wrote:
>> On 06.04.2021 21:15, Julien Grall wrote:
>>> From: Julien Grall <jgrall@amazon.com>
>>>
>>> Currently, we are ignoring any error from perform_gunzip() and replacing
>>> the compressed kernel with the "uncompressed" kernel.
>>>
>>> If there is a gzip failure, then it means that the output buffer may
>>> contain garbagge. So it can result to various sort of behavior that may
>>> be difficult to root cause.
>>>
>>> In case of failure, free the output buffer and propagate the error.
>>> We also need to adjust the return check for kernel_compress() as
>>> perform_gunzip() may return a positive value.
>>>
>>> Take the opportunity to adjust the code style for the check.
>>>
>>> Signed-off-by: Julien Grall <jgrall@amazon.com>
>>>
>>> ---
>>>      Changes in v2:
>>>          - Fix build
>>> ---
>>
>> Reviewed-by: Michal Orzel <michal.orzel@arm.com>
> 
> Thanks! @Stefano, can I get your acked-by?

Ping? I intend to commit it on Wednesday unless I hear otherwise.

Cheers,

-- 
Julien Grall


      reply	other threads:[~2021-05-10 17:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 19:15 [PATCH v2] xen/arm: kernel: Propagate the error if we fail to decompress the kernel Julien Grall
2021-04-12  6:45 ` Michal Orzel
2021-04-18 18:26   ` Julien Grall
2021-05-10 17:47     ` Julien Grall [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ab70b6-3a02-22ab-0a92-3ac3943c828c@xen.org \
    --to=julien@xen.org \
    --cc=bertrand.marquis@arm.com \
    --cc=jgrall@amazon.com \
    --cc=michal.orzel@arm.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.