All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudius Heine <ch@denx.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Marek Vasut" <marex@denx.de>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Horia Geantă" <horia.geanta@nxp.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Iuliana Prodan" <iuliana.prodan@nxp.com>
Subject: Re: [RFC][PATCH] crypto: caam - Add missing MODULE_ALIAS
Date: Tue, 21 Sep 2021 13:19:18 +0200	[thread overview]
Message-ID: <91b14d32-17e9-545c-65a3-0a5c0437af33@denx.de> (raw)
In-Reply-To: <CAOMZO5Bq4wSreYOjB6A86MpZVtudQN7ypJVsL93NsU40S4sN9A@mail.gmail.com>

Hi Fabio,

On 2021-09-21 13:08, Fabio Estevam wrote:
> Hi Claudius,
> 
> On Mon, Sep 20, 2021 at 1:54 PM Claudius Heine <ch@denx.de> wrote:
> 
>> Here are the uevent entries without this RFC patch applied:
>>
>> ```
>> # udevadm info -q all -p devices/platform/soc@0/30800000.bus/30900000.crypto
>> P: /devices/platform/soc@0/30800000.bus/30900000.crypto
>> L: 0
>> E: DEVPATH=/devices/platform/soc@0/30800000.bus/30900000.crypto
>> E: DRIVER=caam
>> E: OF_NAME=crypto
>> E: OF_FULLNAME=/soc@0/bus@30800000/crypto@30900000
>> E: OF_COMPATIBLE_0=fsl,sec-v4.0
>> E: OF_COMPATIBLE_N=1
>> E: MODALIAS=of:NcryptoT(null)Cfsl,sec-v4.0
>> E: SUBSYSTEM=platform
>> E: USEC_INITIALIZED=4468986
>> E: ID_PATH=platform-30900000.crypto
>> E: ID_PATH_TAG=platform-30900000_crypto
> 
> Looking at the addresses above, it looks like you have a device from
> the i.MX8M family.
> 
> caam module is being correctly autoloaded on imx8mn-evk, for example
> on kernel 5.14.6:
> https://storage.kernelci.org/stable/linux-5.14.y/v5.14.6/arm64/defconfig/gcc-8/lab-baylibre/baseline-imx8mn-ddr4-evk.html
> 
> It works on 5.10.67 too:
> https://storage.kernelci.org/stable/linux-5.10.y/v5.10.67/arm64/defconfig/gcc-8/lab-baylibre/baseline-imx8mn-ddr4-evk.html
> 
> Which kernel version do you use?

I never have any issues with auto loading of the module. I just had an 
issue where the rngd daemon didn't wait until the module was loaded and 
failed to start. I found out that there was just some 
`Wants=systemd-udev-settle.service` missing in the service file and then 
everything worked. [1]

Marek just suspected at first that a `MODULE_ALIAS` might be necessary 
in the driver and submitted this RFC patch for it.

So all is well from my end :) And thanks for everyone looking into this!

regards,
Claudius

[1] https://lists.openembedded.org/g/openembedded-core/message/156129

      reply	other threads:[~2021-09-21 11:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-16 13:41 [RFC][PATCH] crypto: caam - Add missing MODULE_ALIAS Marek Vasut
2021-09-16 13:59 ` Krzysztof Kozlowski
2021-09-16 14:06   ` Marek Vasut
2021-09-16 14:22     ` Krzysztof Kozlowski
2021-09-17  9:51     ` Horia Geantă
2021-09-17 10:33       ` Krzysztof Kozlowski
2021-09-17 14:44         ` Horia Geantă
2021-09-17 16:21           ` Krzysztof Kozlowski
2021-09-17 17:30             ` Krzysztof Kozlowski
2021-09-20 13:43               ` Marek Vasut
2021-09-20 16:09                 ` Claudius Heine
2021-09-20 16:16                   ` Krzysztof Kozlowski
2021-09-21 11:08                   ` Fabio Estevam
2021-09-21 11:19                     ` Claudius Heine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91b14d32-17e9-545c-65a3-0a5c0437af33@denx.de \
    --to=ch@denx.de \
    --cc=festevam@gmail.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=horia.geanta@nxp.com \
    --cc=iuliana.prodan@nxp.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.