All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Programmingkid <programmingkidx@gmail.com>,
	"qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>
Cc: Yongbok Kim <yongbok.kim@imgtec.com>,
	James Hogan <james.hogan@imgtec.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression
Date: Wed, 26 Jul 2017 01:13:12 -0300	[thread overview]
Message-ID: <91ba54de-b2eb-f3a9-eb0f-a697b7698149@amsat.org> (raw)
In-Reply-To: <65ED9743-B53C-4E6A-866F-C883650914CE@gmail.com>

Hi John,

On 07/25/2017 07:55 PM, Programmingkid wrote:
> While compiling the mips64el-softmmu target I encountered these errors:
> 
>    CC      hw/display/g364fb.o
> hw/core/loader-fit.c:105:41: error: expected expression
>          *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>                                          ^
> hw/core/loader-fit.c:105:32: error: use of undeclared identifier 'fdt32_t'

It seems you are missing the libfdt headers, so indeed you found bug.

Replacing CONFIG_FITLOADER by CONFIG_FDT in hw/core/Makefile.objs and 
default-configs/mips64el-softmmu.mak should fix it, can you try?

>          *addr = fdt32_to_cpu(*(fdt32_t *)prop);
>                                 ^
> hw/core/loader-fit.c:108:41: error: expected expression
>          *addr = fdt64_to_cpu(*(fdt64_t *)prop);
>                                          ^
> hw/core/loader-fit.c:108:32: error: use of undeclared identifier 'fdt64_t'
>          *addr = fdt64_to_cpu(*(fdt64_t *)prop);
>                                 ^
> hw/core/loader-fit.c:278:19: warning: implicit declaration of function
>        'fdt_first_subnode' is invalid in C99 [-Wimplicit-function-declaration]
>              off = fdt_first_subnode(itb, configs);
>                    ^
> hw/core/loader-fit.c:286:23: warning: implicit declaration of function
>        'fdt_next_subnode' is invalid in C99 [-Wimplicit-function-declaration]
>                  off = fdt_next_subnode(itb, off);
>                        ^
> 2 warnings and 4 errors generated.
> make: *** [hw/core/loader-fit.o] Error 1
> make: *** Waiting for unfinished jobs….

It'd be useful if next time you also tell which compiler/version are you 
using.

> Steps to reproduce the error:
> ./configure --target-list=mips64el-softmmu && make

And also the ./configure output, I'm interested by:

"fdt support       no"

Regards,

Phil.

  reply	other threads:[~2017-07-26  4:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 22:55 [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression Programmingkid
2017-07-26  4:13 ` Philippe Mathieu-Daudé [this message]
2017-07-26  5:15   ` Programmingkid
2017-07-26 10:24     ` Peter Maydell
2017-07-26 16:46       ` Programmingkid
2017-07-26 21:02         ` Philippe Mathieu-Daudé
2017-07-26 21:03         ` Philippe Mathieu-Daudé
2017-07-26 10:45   ` Yongbok Kim
2017-07-26 17:24     ` Programmingkid

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91ba54de-b2eb-f3a9-eb0f-a697b7698149@amsat.org \
    --to=f4bug@amsat.org \
    --cc=aurelien@aurel32.net \
    --cc=james.hogan@imgtec.com \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yongbok.kim@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.