Re: [PATCH v2 07/10] xsm: drop generic event channel labeling

[Jan Beulich <jbeulich@suse.com>]

On 12.07.2021 22:32, Daniel P. Smith wrote:
> The generic event channel labeling has not been used by any XSM module since
> its introduction. This commit removes the capability leaving FLASK labeling
> field always present. In the future if a new XSM module needs to have its own
> channel label, this or a new form can be introduced.

I'm not fully convinced of this removal: Does it get in the way of
anything?

> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -120,15 +120,7 @@ struct evtchn
>      unsigned short notify_vcpu_id; /* VCPU for local delivery notification */
>      uint32_t fifo_lastq;           /* Data for identifying last queue. */
>  
> -#ifdef CONFIG_XSM_EVTCHN_LABELING
>      union {
> -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID
> -        /*
> -         * If an XSM module needs more space for its event channel context,
> -         * this pointer stores the necessary data for the security server.
> -         */
> -        void *generic;
> -#endif
>  #ifdef CONFIG_XSM_FLASK
>          /*
>           * Inlining the contents of the structure for FLASK avoids unneeded

This comment's "with only FLASK" now becomes stale, and hence would
imo better be updated.

Jan