All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Paul Durrant <xadimgnik@gmail.com>
Cc: sstabellini@kernel.org, julien@xen.org, wl@xen.org,
	konrad.wilk@oracle.com, andrew.cooper3@citrix.com,
	ian.jackson@eu.citrix.com, george.dunlap@citrix.com,
	xen-devel@lists.xenproject.org, Volodymyr_Babchuk@epam.com,
	'David Woodhouse' <dwmw2@infradead.org>
Subject: Re: [Xen-devel] [PATCH 2/2] domain: use PGC_extra domheap page for shared_info
Date: Fri, 6 Mar 2020 14:36:01 +0100	[thread overview]
Message-ID: <91c6ffa0-a53e-86a5-4544-935616bb3eee@suse.com> (raw)
In-Reply-To: <00cc01d5f3ba$e3a89300$aaf9b900$@xen.org>

On 06.03.2020 14:26, Paul Durrant wrote:
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of Jan Beulich
>> Sent: 06 March 2020 13:24
>>
>> On 06.03.2020 14:13, Paul Durrant wrote:
>>> My aim is to make the separation abundantly obvious by getting rid
>>> of shared xenheap pages (for non-system domains at least) but I
>>> can't do that before converting shared_info and grant shared/status
>>> frames to domheap.
>>
>> Following David's various replies - instead of going this route of
>> replacing the sharing of xenheap pages by different logic, the
>> same ought to be achievable by making the backing allocations come
>> from the correct pool?
>>
> 
> I still prefer the simplification of not having to clean up the
> shared xenheap page list in domain_kill() so IMO it is still worth
> it for that alone.

I don't see anything very special with the cleaning up in
domain_kill() / domain_relinquish_resources(). What I'd view as
more desirable in this regard is the general fact of needing
two lists. But you realize there's a downside to this as well?
dump_pageframe_info() will reliably show _all_ Xen heap pages
associated with a domain, but it will only ever show up to 10
pages on ->page_list for a domain that's not already being
cleaned up.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-03-06 13:36 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25  9:53 [Xen-devel] [PATCH 0/2] remove one more shared xenheap page: shared_info Paul Durrant
2020-02-25  9:53 ` [Xen-devel] [PATCH 1/2] domain: introduce alloc/free_shared_info() helpers Paul Durrant
2020-02-26  8:03   ` Julien Grall
2020-02-25  9:53 ` [Xen-devel] [PATCH 2/2] domain: use PGC_extra domheap page for shared_info Paul Durrant
2020-02-26 11:33   ` Julien Grall
2020-02-26 11:43     ` Jan Beulich
2020-02-26 12:03     ` Durrant, Paul
2020-02-26 14:22       ` Julien Grall
2020-02-26 14:44         ` Jan Beulich
2020-02-26 11:46   ` Andrew Cooper
2020-02-26 11:53     ` Durrant, Paul
2020-02-26 13:57   ` Jan Beulich
2020-02-26 14:05     ` Durrant, Paul
2020-02-26 15:23       ` Jan Beulich
2020-02-26 16:12         ` Julien Grall
2020-02-26 16:53           ` Woodhouse, David
2020-03-06 11:37             ` Jan Beulich
2020-03-06 11:52               ` David Woodhouse
2020-03-06 11:59                 ` Durrant, Paul
2020-03-06 12:29                   ` Jan Beulich
2020-03-06 12:49                     ` David Woodhouse
2020-03-06 12:25                 ` Jan Beulich
2020-03-06 12:37                   ` David Woodhouse
2020-03-06 12:55                     ` Jan Beulich
2020-03-06 13:08                       ` David Woodhouse
2020-03-06 12:20               ` David Woodhouse
2020-03-06 12:36                 ` Jan Beulich
2020-03-06 12:57                   ` David Woodhouse
2020-03-06 13:10                     ` Jan Beulich
2020-03-06 13:13                       ` Paul Durrant
2020-03-06 13:23                         ` Jan Beulich
2020-03-06 13:26                           ` Paul Durrant
2020-03-06 13:36                             ` Jan Beulich [this message]
2020-03-06 13:41                               ` Paul Durrant
2020-03-06 13:46                                 ` Jan Beulich
2020-03-06 16:27                                   ` Paul Durrant
2020-03-06 17:16                                     ` Jan Beulich
2020-03-09  8:48                                       ` Paul Durrant
2020-03-09  8:54                                         ` Jan Beulich
2020-03-06 13:15                       ` David Woodhouse
2020-03-06 13:22                         ` [Xen-devel] [EXTERNAL][PATCH " Paul Durrant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91c6ffa0-a53e-86a5-4544-935616bb3eee@suse.com \
    --to=jbeulich@suse.com \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=dwmw2@infradead.org \
    --cc=george.dunlap@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=julien@xen.org \
    --cc=konrad.wilk@oracle.com \
    --cc=sstabellini@kernel.org \
    --cc=wl@xen.org \
    --cc=xadimgnik@gmail.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.