From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@arm.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH v3 1/7] docs: Improve documentation for dom0= and dom0-iommu=
Date: Wed, 16 Jan 2019 19:54:30 +0000 [thread overview]
Message-ID: <91d7f060-b180-fe78-5a53-1d07ef156c44@citrix.com> (raw)
In-Reply-To: <20190116105332.hj4xef7wuch5ackw@mac>
On 16/01/2019 10:53, Roger Pau Monné wrote:
> On Wed, Jan 16, 2019 at 09:00:44AM +0000, Andrew Cooper wrote:
>> Update to the latest metadata style, and discuss the options more
>> completely where appropriate.
>>
>> Drop the redundant comment beside parse_dom0_param() - it is already out
>> of sync with the main documentation. Also drop the individual
>> documentation for deprecated options which refer to their newer
>> versions, for the same reason.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Just one comment.
>
> [...]
>> +* The `map-inclusive` boolean is applicable to x86 PV dom0's, and sets up
>> + identity IOMMU mappings for all non-RAM regions below 4GB except for
>> + unusable ranges, and ranges belonging to Xen.
>> +
>> + Typically, some devices in a system use bits of RAM for communication, and
>> + these areas should be listed as reserved in the E820 table and identified
>> + via RMRR or IVMD entries in the APCI tables, so Xen can ensure that they
>> + are identity-mapped in the IOMMU. However, some firmware makes mistakes,
>> + and this option is a coarse-grain workaround for those errors.
>> +
>> + Where possible, finer grain corrections should be made with the `rmrr=`,
>> + `ivrs_hpet=` or `ivrs_ioapic=` command line options.
>> +
>> + This option is enabled by default on x86 systems, and invalid on ARM
>> + systems.
>> +
>> +* The `map-reserved` functionality is very similar to `map-inclusive`, but is
>> + applicable to both x86 PV and PVH dom0's, and represents a subset of the
>> + correction by only mapping reserved memory regions rather than all non-RAM
>> + regions.
> Should you add "This option is enabled by default on x86 systems, and
> invalid on ARM systems." here?
What I listed here where the differences from map-inclusive, so the ARM
bit is covered IMO.
However, this bit of text doesn't survive past patch 6 anyway, so it
really doesn't matter.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-16 19:54 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:00 [PATCH v3 for-4.12 0/7] Docs improvements, and dom0 construction fixes Andrew Cooper
2019-01-16 9:00 ` [PATCH v3 1/7] docs: Improve documentation for dom0= and dom0-iommu= Andrew Cooper
2019-01-16 10:53 ` Roger Pau Monné
2019-01-16 19:54 ` Andrew Cooper [this message]
2019-01-16 11:52 ` Jan Beulich
2019-01-16 19:51 ` Andrew Cooper
2019-01-17 8:43 ` Roger Pau Monné
2019-01-17 9:08 ` Andrew Cooper
2019-01-17 9:14 ` Juergen Gross
2019-01-17 11:59 ` Jan Beulich
2019-01-17 12:11 ` Andrew Cooper
2019-01-17 11:20 ` Jan Beulich
2019-01-17 12:15 ` Andrew Cooper
2019-01-17 12:26 ` Jan Beulich
2019-01-21 17:24 ` Andrew Cooper
2019-01-16 9:00 ` [PATCH v3 2/7] docs: Improve documentation and parsing for iommu= Andrew Cooper
2019-01-16 11:06 ` Roger Pau Monné
2019-01-21 17:30 ` Andrew Cooper
2019-01-16 13:47 ` Jan Beulich
2019-01-16 9:00 ` [PATCH v3 3/7] docs: Improve documentation and parsing for pci= Andrew Cooper
2019-01-16 11:08 ` Roger Pau Monné
2019-01-16 13:52 ` Jan Beulich
2019-01-16 9:00 ` [PATCH v3 4/7] docs: Improve documentation and parsing for efi= Andrew Cooper
2019-01-16 14:00 ` Jan Beulich
2019-01-16 9:00 ` [PATCH v3 5/7] x86/dom0: Improve dom0= useability Andrew Cooper
2019-01-16 11:13 ` Roger Pau Monné
2019-01-16 14:08 ` Jan Beulich
2019-01-16 19:58 ` Andrew Cooper
2019-01-17 11:21 ` Jan Beulich
2019-01-16 9:00 ` [PATCH v3 6/7] xen/dom0: Drop iommu_hwdom_inclusive entirely Andrew Cooper
2019-01-16 11:24 ` Roger Pau Monné
2019-01-17 13:32 ` Jan Beulich
2019-01-17 14:51 ` Roger Pau Monné
2019-01-16 9:00 ` [PATCH v3 7/7] xen/dom0: Add a dom0-iommu=none option Andrew Cooper
2019-01-16 11:32 ` Roger Pau Monné
2019-01-17 10:55 ` Wei Liu
2019-01-17 13:35 ` Jan Beulich
2019-01-21 18:08 ` Andrew Cooper
2019-01-22 8:06 ` Jan Beulich
2019-01-22 13:42 ` Andrew Cooper
2019-01-16 11:38 ` [PATCH v3 for-4.12 0/7] Docs improvements, and dom0 construction fixes Juergen Gross
2019-01-17 12:08 [PATCH v3 1/7] docs: Improve documentation for dom0= and dom0-iommu= Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91d7f060-b180-fe78-5a53-1d07ef156c44@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.