All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
@ 2021-07-04 19:31 Marek Vasut
  2021-07-05  4:17 ` Heiko Schocher
  2021-07-14 20:52 ` Tom Rini
  0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2021-07-04 19:31 UTC (permalink / raw)
  To: u-boot; +Cc: Marek Vasut, Heiko Schocher, Michal Simek

Linux kernel binding is using atmel,24c01 compatible string. On the
other hand there is atmel,24c01a which is not listed in the kernel.
Add compatible string without "a" suffix to be compatible with Linux
kernel binding.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Heiko Schocher <hs@denx.de>
Cc: Michal Simek <michal.simek@xilinx.com>
---
 drivers/misc/i2c_eeprom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/i2c_eeprom.c b/drivers/misc/i2c_eeprom.c
index 5926c91a2e..99eff8442a 100644
--- a/drivers/misc/i2c_eeprom.c
+++ b/drivers/misc/i2c_eeprom.c
@@ -262,6 +262,7 @@ static const struct i2c_eeprom_drv_data atmel24c512_data = {
 static const struct udevice_id i2c_eeprom_std_ids[] = {
 	{ .compatible = "i2c-eeprom", (ulong)&eeprom_data },
 	{ .compatible = "microchip,24aa02e48", (ulong)&mc24aa02e48_data },
+	{ .compatible = "atmel,24c01", (ulong)&atmel24c01a_data },
 	{ .compatible = "atmel,24c01a", (ulong)&atmel24c01a_data },
 	{ .compatible = "atmel,24c02", (ulong)&atmel24c02_data },
 	{ .compatible = "atmel,24c04", (ulong)&atmel24c04_data },
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
  2021-07-04 19:31 [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list Marek Vasut
@ 2021-07-05  4:17 ` Heiko Schocher
  2021-07-05  7:25   ` Marek Vasut
  2021-07-14 20:52 ` Tom Rini
  1 sibling, 1 reply; 4+ messages in thread
From: Heiko Schocher @ 2021-07-05  4:17 UTC (permalink / raw)
  To: Marek Vasut, u-boot; +Cc: Marek Vasut, Michal Simek

Hello Marek,

On 04.07.21 21:31, Marek Vasut wrote:
> Linux kernel binding is using atmel,24c01 compatible string. On the
> other hand there is atmel,24c01a which is not listed in the kernel.
> Add compatible string without "a" suffix to be compatible with Linux
> kernel binding.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Michal Simek <michal.simek@xilinx.com>
> ---
>  drivers/misc/i2c_eeprom.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Heiko Schocher <hs@denx.de>

Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel,
may we should remove it in U-Boot completly?

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
  2021-07-05  4:17 ` Heiko Schocher
@ 2021-07-05  7:25   ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2021-07-05  7:25 UTC (permalink / raw)
  To: hs, u-boot; +Cc: Michal Simek

On 7/5/21 6:17 AM, Heiko Schocher wrote:
> Hello Marek,
> 
> On 04.07.21 21:31, Marek Vasut wrote:
>> Linux kernel binding is using atmel,24c01 compatible string. On the
>> other hand there is atmel,24c01a which is not listed in the kernel.
>> Add compatible string without "a" suffix to be compatible with Linux
>> kernel binding.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
>> Cc: Heiko Schocher <hs@denx.de>
>> Cc: Michal Simek <michal.simek@xilinx.com>
>> ---
>>   drivers/misc/i2c_eeprom.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> Hmm... may dummy remark ... if "atmel,24c01a" is not used in kernel,
> may we should remove it in U-Boot completly?

Sadly they are both used by the DTs, so we cannot. That's why we also 
have 24c08 and 24c08a in the compatibles, it's exactly the same change.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list
  2021-07-04 19:31 [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list Marek Vasut
  2021-07-05  4:17 ` Heiko Schocher
@ 2021-07-14 20:52 ` Tom Rini
  1 sibling, 0 replies; 4+ messages in thread
From: Tom Rini @ 2021-07-14 20:52 UTC (permalink / raw)
  To: Marek Vasut; +Cc: u-boot, Marek Vasut, Heiko Schocher, Michal Simek

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Sun, Jul 04, 2021 at 09:31:18PM +0200, Marek Vasut wrote:

> Linux kernel binding is using atmel,24c01 compatible string. On the
> other hand there is atmel,24c01a which is not listed in the kernel.
> Add compatible string without "a" suffix to be compatible with Linux
> kernel binding.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Reviewed-by: Heiko Schocher <hs@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-07-14 20:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-04 19:31 [PATCH] misc: i2c_eeprom: Add atmel,24c01 to the list Marek Vasut
2021-07-05  4:17 ` Heiko Schocher
2021-07-05  7:25   ` Marek Vasut
2021-07-14 20:52 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.