From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dfk3y-00044W-49 for qemu-devel@nongnu.org; Thu, 10 Aug 2017 05:47:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dfk3u-0002Yx-U4 for qemu-devel@nongnu.org; Thu, 10 Aug 2017 05:47:34 -0400 References: <20170728053610.15770-1-f4bug@amsat.org> <20170728053610.15770-19-f4bug@amsat.org> <87mv7aumav.fsf@linaro.org> <8e2e3aa5-4459-76ba-3309-af6b30220346@amsat.org> <87fud0vmak.fsf@linaro.org> <3e66742f-04c5-51b7-de3a-f692c0637bc5@amsat.org> From: Paolo Bonzini Message-ID: <91e62cd2-947b-5c7b-3371-b1d116710fc7@redhat.com> Date: Thu, 10 Aug 2017 11:47:22 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= , Eric Blake , Fam Zheng , Cornelia Huck , Richard Henderson , QEMU Trivial , QEMU Developers , Markus Armbruster , "Dr. David Alan Gilbert" On 10/08/2017 11:35, Peter Maydell wrote: >> actual default for un-matched: "recent contributors" + qemu-devel@ >> >> $ ./scripts/get_maintainer.pl -f disas.c >> get_maintainer.pl: No maintainers found, printing recent contributor= s. >> get_maintainer.pl: Do not blindly cc: them on patches! Use common s= ense. >> Peter Maydell (commit_signer:2/3=3D67%) >> Richard Henderson (commit_signer:1/3=3D33%) >> Thomas Huth (commit_signer:1/3=3D33%) >> Michael Tokarev (commit_signer:1/3=3D33%) >> Julian Brown (commit_signer:1/3=3D33%) >> qemu-devel@nongnu.org (open list:All patches CC here) >> >> I find the un-matched "recent contributors" list often confuse, due to= files >> being moved, header updated, checkpatch indented. >=20 > Yes, the recent-contributors list is often unhelpful, which > is partly why the script warns about them. We might perhaps > switch the default to --no-git-fallback". Note that if a patch touches both maintained and unmaintained files, the recent contributors list is omitted: $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c John Snow (supporter:IDE) qemu-devel@nongnu.org (open list:All patches CC here) qemu-block@nongnu.org (open list:IDE) "--no-git-fallback" is probably the right thing to do when sending a patch series. The maintainer that shepherds the series will take care of unmaintained files too. However, when sending a single patch to an unmaintained file the contributors list usually does get the patch to the inbox of a maintainer. This increases the odds of getting someone's attention. Because inexperienced contributors usually don't send large series, my feeling is that overall "--git-fallback"'s advantage are more than the disadvantages, especially with the above logic that was introduced in commit c6561586f0 ("get_maintainer.pl: restrict cases where it falls back to --git", 2014-10-23). Paolo