RE: [oe] [meta-oe][PATCH] ipmitool: add default iana enterprise numbers database

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> On Behalf Of Xiangyu Chen
> Sent: den 24 oktober 2022 11:57
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH] ipmitool: add default iana enterprise numbers database
> 
> When using default configuration without add IANA_ENTERPRISE_NUMBERS and
> SRC_URI in a bbappend, the ipmitool would report an error as below:
> 
> "
> root@intel-x86-64:~# ipmitool -I open bmc getenables
> IANA PEN registry open failed: No such file or directory
> "
> 
> Add a default iana enterprise numbers database to avoid the error
> happen if using ipmitool default bb configuration.
> 
> Signed-off-by: Xiangyu Chen <xiangyu.chen@windriver.com>
> ---
>  .../ipmitool/ipmitool/iana-enterprise-numbers | 237682 +++++++++++++++
>  .../ipmitool/ipmitool_1.8.19.bb               |      6 +-
>  2 files changed, 237686 insertions(+), 2 deletions(-)
>  create mode 100644 meta-oe/recipes-kernel/ipmitool/ipmitool/iana-enterprise-numbers
> 
> diff --git a/meta-oe/recipes-kernel/ipmitool/ipmitool/iana-enterprise-numbers b/meta-oe/recipes-kernel/ipmitool/ipmitool/iana-enterprise-numbers
> new file mode 100644
> index 000000000..f8c328796
> --- /dev/null

[cut 237k+ lines... ]

For the benefit of all members of this list, do not send a 237k+ 
lines patch as a mail! The resulting mail was 20 MB. It took my 
Outlook client over two hours to create this response (where I 
then had to remove most of those 237k+ lines again)...

Instead push the change to some public repository. For 
OpenEmbedded you should be able to use the github repository and 
create a merge request that way (and let us hope that Khem does 
not have automatic tooling that sends all merge requests as 
patches to the mailing list...)

> +++ b/meta-oe/recipes-kernel/ipmitool/ipmitool/iana-enterprise-numbers
> diff --git a/meta-oe/recipes-kernel/ipmitool/ipmitool_1.8.19.bb b/meta-oe/recipes-kernel/ipmitool/ipmitool_1.8.19.bb
> index 0a600e23b..e166ea213 100644
> --- a/meta-oe/recipes-kernel/ipmitool/ipmitool_1.8.19.bb
> +++ b/meta-oe/recipes-kernel/ipmitool/ipmitool_1.8.19.bb
> @@ -27,9 +27,11 @@ SRC_URI = "git://github.com/ipmitool/ipmitool;protocol=https;branch=master \
>             file://0001-ipmi_fru.c-Provide-missing-function-declarations.patch \
>             file://0001-configure-Remove-the-logic-to-download-IANA-PEN-data.patch \
>             "
> -IANA_ENTERPRISE_NUMBERS ?= ""
> 
> -# Add these via bbappend if this database is needed by the system
> +# Default IANA enterprise database version is 2022-10-24
> +IANA_ENTERPRISE_NUMBERS ?= "file://iana-enterprise-numbers"

If you compress the file with xz, the size is reduced to a third.	
Bitbake will then uncompress it automatically during do_unpack(). 

> +
> +# Add these via bbappend if the latest version database is needed by the system
>  #IANA_ENTERPRISE_NUMBERS ?= "http://www.iana.org/assignments/enterprise-numbers;name=iana-enterprise-numbers;downloadfilename=iana-enterprise-numbers"

Change "?=" to "=", or the suggestion to add it as a bbappend will 
not work.

>  #SRC_URI[iana-enterprise-numbers.sha256sum] = "cdd97fc08325667434b805eb589104ae63f7a9eb720ecea73cb55110b383934c"
> 
> --
> 2.34.1

//Peter