From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C4EC54FD0 for ; Mon, 20 Apr 2020 18:19:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E089B206B8 for ; Mon, 20 Apr 2020 18:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgDTSTv (ORCPT ); Mon, 20 Apr 2020 14:19:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727891AbgDTSTv (ORCPT ); Mon, 20 Apr 2020 14:19:51 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30E9DC061A0C; Mon, 20 Apr 2020 11:19:51 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id 313602A0FEB Subject: Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct From: Andrzej Pietrasiewicz To: Bartlomiej Zolnierkiewicz Cc: linux-pm@vger.kernel.org, Zhang Rui , "Rafael J . Wysocki" , Len Brown , Jiri Pirko , Ido Schimmel , "David S . Miller" , Peter Kaestle , Darren Hart , Andy Shevchenko , Support Opensource , Daniel Lezcano , Amit Kucheria , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Allison Randal , Enrico Weigelt , Gayatri Kammela , Thomas Gleixner , linux-acpi@vger.kernel.org, netdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <9ac3b37a-8746-b8ee-70e1-9c876830ac83@linaro.org> <20200417162020.19980-1-andrzej.p@collabora.com> <20200417162020.19980-2-andrzej.p@collabora.com> <4b97e46a-e7ef-ee22-227e-d35ebef458b0@samsung.com> <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Message-ID: <920f8285-1b49-d088-64b4-98bce8d23e39@collabora.com> Date: Mon, 20 Apr 2020 20:19:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org @Daniel please see below W dniu 20.04.2020 o 13:03, Andrzej Pietrasiewicz pisze: > Hi Barlomiej, > > Thanks for looking into the series. > > @Daniel can you see below? > > W dniu 19.04.2020 o 13:38, Bartlomiej Zolnierkiewicz pisze: >> >> Hi Andrzej, >> >> On 4/17/20 6:20 PM, Andrzej Pietrasiewicz wrote: >>> Thermal zone devices' mode is stored in individual drivers. This patch >>> changes it so that mode is stored in struct thermal_zone_device instead. >>> >>> As a result all driver-specific variables storing the mode are not needed >>> and are removed. Consequently, the get_mode() implementations have nothing >>> to operate on and need to be removed, too. >>> >>> Some thermal framework specific functions are introduced: >>> >>> thermal_zone_device_get_mode() >>> thermal_zone_device_set_mode() >>> thermal_zone_device_enable() >>> thermal_zone_device_disable() >>> >>> thermal_zone_device_get_mode() and its "set" counterpart take tzd's lock >>> and the "set" calls driver's set_mode() if provided, so the latter must >>> not take this lock again. At the end of the "set" >>> thermal_zone_device_update() is called so drivers don't need to repeat this >>> invocation in their specific set_mode() implementations. >>> >>> The scope of the above 4 functions is purposedly limited to the thermal >>> framework and drivers are not supposed to call them. This encapsulation >> >> This should be true only for thermal_zone_device_{get,set}_mode(). >> >> thermal_zone_device_{en,dis}able() should be available for device drivers: >> >> * of/thermal device drivers need to enable thermal device itself >>    (please refer to my patchset for details) >> >> * device drivers need to call them on ->suspend and ->resume operations >> > > @Daniel: > > How does this compare to > > "Just: > > thermal_zone_device_get_mode() > thermal_zone_device_set_mode() > thermal_zone_device_disable() > thermal_zone_device_enable() > > And all of them in drivers/thermal/thermal_core.h". Did I understand > you correctly? > I sent a PATCH series (rather than next iteration of RFC) addressing Bartlomiej's comments. They make sense to me. Regards, Andrzej From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Pietrasiewicz Subject: Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct Date: Mon, 20 Apr 2020 20:19:43 +0200 Message-ID: <920f8285-1b49-d088-64b4-98bce8d23e39@collabora.com> References: <9ac3b37a-8746-b8ee-70e1-9c876830ac83@linaro.org> <20200417162020.19980-1-andrzej.p@collabora.com> <20200417162020.19980-2-andrzej.p@collabora.com> <4b97e46a-e7ef-ee22-227e-d35ebef458b0@samsung.com> <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Content-Language: en-US Sender: linux-acpi-owner@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-pm@vger.kernel.org, Zhang Rui , "Rafael J . Wysocki" , Len Brown , Jiri Pirko , Ido Schimmel , "David S . Miller" , Peter Kaestle , Darren Hart , Andy Shevchenko , Support Opensource , Daniel Lezcano , Amit Kucheria , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Allison Randal , Enrico Weigelt List-Id: platform-driver-x86.vger.kernel.org @Daniel please see below W dniu 20.04.2020 o 13:03, Andrzej Pietrasiewicz pisze: > Hi Barlomiej, > > Thanks for looking into the series. > > @Daniel can you see below? > > W dniu 19.04.2020 o 13:38, Bartlomiej Zolnierkiewicz pisze: >> >> Hi Andrzej, >> >> On 4/17/20 6:20 PM, Andrzej Pietrasiewicz wrote: >>> Thermal zone devices' mode is stored in individual drivers. This patch >>> changes it so that mode is stored in struct thermal_zone_device instead. >>> >>> As a result all driver-specific variables storing the mode are not needed >>> and are removed. Consequently, the get_mode() implementations have nothing >>> to operate on and need to be removed, too. >>> >>> Some thermal framework specific functions are introduced: >>> >>> thermal_zone_device_get_mode() >>> thermal_zone_device_set_mode() >>> thermal_zone_device_enable() >>> thermal_zone_device_disable() >>> >>> thermal_zone_device_get_mode() and its "set" counterpart take tzd's lock >>> and the "set" calls driver's set_mode() if provided, so the latter must >>> not take this lock again. At the end of the "set" >>> thermal_zone_device_update() is called so drivers don't need to repeat this >>> invocation in their specific set_mode() implementations. >>> >>> The scope of the above 4 functions is purposedly limited to the thermal >>> framework and drivers are not supposed to call them. This encapsulation >> >> This should be true only for thermal_zone_device_{get,set}_mode(). >> >> thermal_zone_device_{en,dis}able() should be available for device drivers: >> >> * of/thermal device drivers need to enable thermal device itself >>    (please refer to my patchset for details) >> >> * device drivers need to call them on ->suspend and ->resume operations >> > > @Daniel: > > How does this compare to > > "Just: > > thermal_zone_device_get_mode() > thermal_zone_device_set_mode() > thermal_zone_device_disable() > thermal_zone_device_enable() > > And all of them in drivers/thermal/thermal_core.h". Did I understand > you correctly? > I sent a PATCH series (rather than next iteration of RFC) addressing Bartlomiej's comments. They make sense to me. Regards, Andrzej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C26C38A30 for ; Mon, 20 Apr 2020 18:19:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E59C4206B8 for ; Mon, 20 Apr 2020 18:19:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A2ti/ITL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E59C4206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DpT1J0VwE0Pf1dmFjHq6xuXvoaxonfwDlaJC3/1u9nc=; b=A2ti/ITLqNKxYjLWjocqEPMdG EvJZQGLRTZklJ0q9cXK/E7abnXriWO/QaNAFwTGZ0b1IdFJpkwZSznxa7bssMnnEGPg7zdHgaselA EAH7KkdZKtD1xLyNYRiVL0u97UG657m6o5WHiXZZpH3JutdnwFWWOEDaZ0ShlPD94fhyn52eDnLzP ofBFHQH7eZ7iaLujbaaCO9QQxrQE1lk7sNyc+iwTH2i9A3B1+tKLwRmbYNEXHkppuAHa5NlJgP5jn EoAYA1yUJfUV9Ms5Pu9FevTxU07FVOMJI8jJJur1nysBkEF3L34nLsPt/38WkQ+2yQd8EgK/NhoLq /RUNW3W8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQb1P-0002nC-Ob; Mon, 20 Apr 2020 18:19:55 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQb1K-0002l1-W5 for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 18:19:53 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: andrzej.p) with ESMTPSA id 313602A0FEB Subject: Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct From: Andrzej Pietrasiewicz To: Bartlomiej Zolnierkiewicz References: <9ac3b37a-8746-b8ee-70e1-9c876830ac83@linaro.org> <20200417162020.19980-1-andrzej.p@collabora.com> <20200417162020.19980-2-andrzej.p@collabora.com> <4b97e46a-e7ef-ee22-227e-d35ebef458b0@samsung.com> <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Message-ID: <920f8285-1b49-d088-64b4-98bce8d23e39@collabora.com> Date: Mon, 20 Apr 2020 20:19:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <4cda3e11-7bea-8445-cd51-4b25dcafc741@collabora.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_111951_158590_DAF0997A X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Rafael J . Wysocki" , platform-driver-x86@vger.kernel.org, kernel@collabora.com, Fabio Estevam , Amit Kucheria , Daniel Lezcano , linux-acpi@vger.kernel.org, NXP Linux Team , Darren Hart , Zhang Rui , Gayatri Kammela , Len Brown , linux-pm@vger.kernel.org, Sascha Hauer , Ido Schimmel , Jiri Pirko , Thomas Gleixner , Allison Randal , linux-arm-kernel@lists.infradead.org, Support Opensource , Shawn Guo , Peter Kaestle , Pengutronix Kernel Team , netdev@vger.kernel.org, Enrico Weigelt , "David S . Miller" , Andy Shevchenko Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org QERhbmllbAoKcGxlYXNlIHNlZSBiZWxvdwoKVyBkbml1IDIwLjA0LjIwMjAgb8KgMTM6MDMsIEFu ZHJ6ZWogUGlldHJhc2lld2ljeiBwaXN6ZToKPiBIaSBCYXJsb21pZWosCj4gCj4gVGhhbmtzIGZv ciBsb29raW5nIGludG8gdGhlIHNlcmllcy4KPiAKPiBARGFuaWVsIGNhbiB5b3Ugc2VlIGJlbG93 Pwo+IAo+IFcgZG5pdSAxOS4wNC4yMDIwIG/CoDEzOjM4LCBCYXJ0bG9taWVqIFpvbG5pZXJraWV3 aWN6IHBpc3plOgo+Pgo+PiBIaSBBbmRyemVqLAo+Pgo+PiBPbiA0LzE3LzIwIDY6MjAgUE0sIEFu ZHJ6ZWogUGlldHJhc2lld2ljeiB3cm90ZToKPj4+IFRoZXJtYWwgem9uZSBkZXZpY2VzJyBtb2Rl IGlzIHN0b3JlZCBpbiBpbmRpdmlkdWFsIGRyaXZlcnMuIFRoaXMgcGF0Y2gKPj4+IGNoYW5nZXMg aXQgc28gdGhhdCBtb2RlIGlzIHN0b3JlZCBpbiBzdHJ1Y3QgdGhlcm1hbF96b25lX2RldmljZSBp bnN0ZWFkLgo+Pj4KPj4+IEFzIGEgcmVzdWx0IGFsbCBkcml2ZXItc3BlY2lmaWMgdmFyaWFibGVz IHN0b3JpbmcgdGhlIG1vZGUgYXJlIG5vdCBuZWVkZWQKPj4+IGFuZCBhcmUgcmVtb3ZlZC4gQ29u c2VxdWVudGx5LCB0aGUgZ2V0X21vZGUoKSBpbXBsZW1lbnRhdGlvbnMgaGF2ZSBub3RoaW5nCj4+ PiB0byBvcGVyYXRlIG9uIGFuZCBuZWVkIHRvIGJlIHJlbW92ZWQsIHRvby4KPj4+Cj4+PiBTb21l IHRoZXJtYWwgZnJhbWV3b3JrIHNwZWNpZmljIGZ1bmN0aW9ucyBhcmUgaW50cm9kdWNlZDoKPj4+ Cj4+PiB0aGVybWFsX3pvbmVfZGV2aWNlX2dldF9tb2RlKCkKPj4+IHRoZXJtYWxfem9uZV9kZXZp Y2Vfc2V0X21vZGUoKQo+Pj4gdGhlcm1hbF96b25lX2RldmljZV9lbmFibGUoKQo+Pj4gdGhlcm1h bF96b25lX2RldmljZV9kaXNhYmxlKCkKPj4+Cj4+PiB0aGVybWFsX3pvbmVfZGV2aWNlX2dldF9t b2RlKCkgYW5kIGl0cyAic2V0IiBjb3VudGVycGFydCB0YWtlIHR6ZCdzIGxvY2sKPj4+IGFuZCB0 aGUgInNldCIgY2FsbHMgZHJpdmVyJ3Mgc2V0X21vZGUoKSBpZiBwcm92aWRlZCwgc28gdGhlIGxh dHRlciBtdXN0Cj4+PiBub3QgdGFrZSB0aGlzIGxvY2sgYWdhaW4uIEF0IHRoZSBlbmQgb2YgdGhl ICJzZXQiCj4+PiB0aGVybWFsX3pvbmVfZGV2aWNlX3VwZGF0ZSgpIGlzIGNhbGxlZCBzbyBkcml2 ZXJzIGRvbid0IG5lZWQgdG8gcmVwZWF0IHRoaXMKPj4+IGludm9jYXRpb24gaW4gdGhlaXIgc3Bl Y2lmaWMgc2V0X21vZGUoKSBpbXBsZW1lbnRhdGlvbnMuCj4+Pgo+Pj4gVGhlIHNjb3BlIG9mIHRo ZSBhYm92ZSA0IGZ1bmN0aW9ucyBpcyBwdXJwb3NlZGx5IGxpbWl0ZWQgdG8gdGhlIHRoZXJtYWwK Pj4+IGZyYW1ld29yayBhbmQgZHJpdmVycyBhcmUgbm90IHN1cHBvc2VkIHRvIGNhbGwgdGhlbS4g VGhpcyBlbmNhcHN1bGF0aW9uCj4+Cj4+IFRoaXMgc2hvdWxkIGJlIHRydWUgb25seSBmb3IgdGhl cm1hbF96b25lX2RldmljZV97Z2V0LHNldH1fbW9kZSgpLgo+Pgo+PiB0aGVybWFsX3pvbmVfZGV2 aWNlX3tlbixkaXN9YWJsZSgpIHNob3VsZCBiZSBhdmFpbGFibGUgZm9yIGRldmljZSBkcml2ZXJz Ogo+Pgo+PiAqIG9mL3RoZXJtYWwgZGV2aWNlIGRyaXZlcnMgbmVlZCB0byBlbmFibGUgdGhlcm1h bCBkZXZpY2UgaXRzZWxmCj4+IMKgwqAgKHBsZWFzZSByZWZlciB0byBteSBwYXRjaHNldCBmb3Ig ZGV0YWlscykKPj4KPj4gKiBkZXZpY2UgZHJpdmVycyBuZWVkIHRvIGNhbGwgdGhlbSBvbiAtPnN1 c3BlbmQgYW5kIC0+cmVzdW1lIG9wZXJhdGlvbnMKPj4KPiAKPiBARGFuaWVsOgo+IAo+IEhvdyBk b2VzIHRoaXMgY29tcGFyZSB0bwo+IAo+ICJKdXN0Ogo+IAo+IHRoZXJtYWxfem9uZV9kZXZpY2Vf Z2V0X21vZGUoKQo+IHRoZXJtYWxfem9uZV9kZXZpY2Vfc2V0X21vZGUoKQo+IHRoZXJtYWxfem9u ZV9kZXZpY2VfZGlzYWJsZSgpCj4gdGhlcm1hbF96b25lX2RldmljZV9lbmFibGUoKQo+IAo+IEFu ZCBhbGwgb2YgdGhlbSBpbiBkcml2ZXJzL3RoZXJtYWwvdGhlcm1hbF9jb3JlLmgiLiBEaWQgSSB1 bmRlcnN0YW5kCj4geW91IGNvcnJlY3RseT8KPiAKCkkgc2VudCBhIFBBVENIIHNlcmllcyAocmF0 aGVyIHRoYW4gbmV4dCBpdGVyYXRpb24gb2YgUkZDKSBhZGRyZXNzaW5nCkJhcnRsb21pZWoncyBj b21tZW50cy4gVGhleSBtYWtlIHNlbnNlIHRvIG1lLgoKUmVnYXJkcywKCkFuZHJ6ZWoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK