From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935267AbcIFXTJ convert rfc822-to-8bit (ORCPT ); Tue, 6 Sep 2016 19:19:09 -0400 Received: from smtpout.microchip.com ([198.175.253.82]:37922 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755801AbcIFXTH (ORCPT ); Tue, 6 Sep 2016 19:19:07 -0400 From: To: , , CC: , , Subject: RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros Thread-Topic: [PATCH 0/2] lan78xx: Remove trailing underscores from macros Thread-Index: AQHSCJMM6pPiypwMkUaYMdwJIihAYKBtFsGQ Date: Tue, 6 Sep 2016 23:19:05 +0000 Message-ID: <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.10.76.4] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Joe Perches (2): > lan78xx: Remove locally defined trailing underscores from defines and uses > microchipphy.h and uses: Remove trailing underscores from defines and > uses > > drivers/net/phy/microchip.c | 4 +- > drivers/net/usb/lan78xx.c | 368 +++++++-------- > drivers/net/usb/lan78xx.h | 1068 +++++++++++++++++++++----------------- > ---- > include/linux/microchipphy.h | 72 +-- > 4 files changed, 756 insertions(+), 756 deletions(-) Because there is no specific rule how to name defines, I'm not sure it is worth to change 1000+ lines. It may be better to set guideline for new submissions. Welcome any comments. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subject: RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros Date: Tue, 6 Sep 2016 23:19:05 +0000 Message-ID: <9235D6609DB808459E95D78E17F2E43D40910FF9@CHN-SV-EXMX02.mchp-main.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Cc: , , To: , , Return-path: In-Reply-To: Content-Language: en-US Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org > Joe Perches (2): > lan78xx: Remove locally defined trailing underscores from defines and uses > microchipphy.h and uses: Remove trailing underscores from defines and > uses > > drivers/net/phy/microchip.c | 4 +- > drivers/net/usb/lan78xx.c | 368 +++++++-------- > drivers/net/usb/lan78xx.h | 1068 +++++++++++++++++++++----------------- > ---- > include/linux/microchipphy.h | 72 +-- > 4 files changed, 756 insertions(+), 756 deletions(-) Because there is no specific rule how to name defines, I'm not sure it is worth to change 1000+ lines. It may be better to set guideline for new submissions. Welcome any comments. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html