From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com ([209.132.183.28]:55532 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbdDHVFj (ORCPT ); Sat, 8 Apr 2017 17:05:39 -0400 From: David Howells In-Reply-To: <20170408150812.GX22845@eguan.usersys.redhat.com> References: <20170408150812.GX22845@eguan.usersys.redhat.com> <149146774821.12770.3592235770964461857.stgit@warthog.procyon.org.uk> <149146775556.12770.11943651470996193921.stgit@warthog.procyon.org.uk> Subject: Re: [PATCH 2/4] xfstests: Add first statx test [ver #10] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9255.1491685531.1@warthog.procyon.org.uk> Date: Sat, 08 Apr 2017 22:05:31 +0100 Message-ID: <9256.1491685531@warthog.procyon.org.uk> Sender: fstests-owner@vger.kernel.org To: Eryu Guan Cc: dhowells@redhat.com, linux-xfs@vger.kernel.org, hch@infradead.org, amir73il@gmail.com, david@fromorbit.com, fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org List-ID: Eryu Guan wrote: > Perhaps we should add a new autoconf rule in configure.ac and define > HAVE_STATX if there's statx support, like what src/renameat2.c does? src/renameat2.c has in it: #if !defined(SYS_renameat2) && defined(__i386__) #define SYS_renameat2 353 #endif #if !defined(SYS_renameat2) && defined(__i386__) #define SYS_renameat2 353 #endif This looks like a copy & paste error. David