From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3736AC433B4 for ; Wed, 12 May 2021 01:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A6D16192B for ; Wed, 12 May 2021 01:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229973AbhELB3f (ORCPT ); Tue, 11 May 2021 21:29:35 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2425 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229736AbhELB3e (ORCPT ); Tue, 11 May 2021 21:29:34 -0400 Received: from dggemx753-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ffxtw3sgSz5yyY; Wed, 12 May 2021 09:25:44 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 12 May 2021 09:28:24 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first To: Jaegeuk Kim , , CC: kernel test robot References: <20210511214337.2857522-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <925bff47-de32-76b8-041d-0aad4fec0d54@huawei.com> Date: Wed, 12 May 2021 09:28:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210511214337.2857522-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/12 5:43, Jaegeuk Kim wrote: > The final solution can be migrating blocks to form a section-aligned file > internally. Meanwhile, let's ask users to do that when preparing the swap > file initially like: > 1) create() > 2) ioctl(F2FS_IOC_SET_PIN_FILE) > 3) fallocate() Let me take a look how to migrate unaligned swapfile during swapon(). :) > > Reported-by: kernel test robot > Fixes: 36e4d95891ed ("f2fs: check if swapfile is section-alligned") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F0E2C433ED for ; Wed, 12 May 2021 01:28:53 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 382BD61927; Wed, 12 May 2021 01:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 382BD61927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lgdgC-0000rD-80; Wed, 12 May 2021 01:28:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgdg2-0000qC-O3 for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 May 2021 01:28:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:CC:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XZ0poH5BQTi9AnR6OKUVEZZrJ+RXAjuQNVr9cqHpV34=; b=Re/c1eingxW0UYRBX0OtxN+fMU 0XIk1S7YJDQXJisO0mEOIqRS/znNGL88GVPB1p9LR40z3IeQKHPU4ab5cQh+aa4Wi87Fzga8ALd0/ annNMSaQ7VbDl+5mohB5K7sgBmpDSFbWCCXRt9t2jpmOWRJZTUkCOEru1MD54wLbrYvo=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XZ0poH5BQTi9AnR6OKUVEZZrJ+RXAjuQNVr9cqHpV34=; b=XlTVk5u8zHfxwDjLFlqH1BS1W9 yzikUTsGA/0Yexajy0KzjBkEETROr9eUb9t0n2YbnfQOY7GX+eTA5KLBaFBgrBcBP2d1nvq5Z4fiR ub4W91X5e0FAaufO4d4OvVHvhGM71CC4bT885M2z+v9bnl1APvfCfKX9jj0ilcEZxsJY=; Received: from szxga02-in.huawei.com ([45.249.212.188]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1lgdfw-004XSb-DK for linux-f2fs-devel@lists.sourceforge.net; Wed, 12 May 2021 01:28:43 +0000 Received: from dggemx753-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Ffxtw3sgSz5yyY; Wed, 12 May 2021 09:25:44 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 12 May 2021 09:28:24 +0800 To: Jaegeuk Kim , , References: <20210511214337.2857522-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <925bff47-de32-76b8-041d-0aad4fec0d54@huawei.com> Date: Wed, 12 May 2021 09:28:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210511214337.2857522-1-jaegeuk@kernel.org> Content-Language: en-US X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected X-Headers-End: 1lgdfw-004XSb-DK Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 2021/5/12 5:43, Jaegeuk Kim wrote: > The final solution can be migrating blocks to form a section-aligned file > internally. Meanwhile, let's ask users to do that when preparing the swap > file initially like: > 1) create() > 2) ioctl(F2FS_IOC_SET_PIN_FILE) > 3) fallocate() Let me take a look how to migrate unaligned swapfile during swapon(). :) > > Reported-by: kernel test robot > Fixes: 36e4d95891ed ("f2fs: check if swapfile is section-alligned") > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel