From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Mateo Lozano, Oscar" <oscar.mateo@intel.com>
Subject: Re: [PATCH 53/53] !UPSTREAM: drm/i915: Use MMIO flips
Date: Thu, 19 Jun 2014 10:33:59 +0000
Message-ID: <92648605EABDA246B775AAB04C95A7A3013209D2@IRSMSX103.ger.corp.intel.com>
References: <1402673891-14618-1-git-send-email-oscar.mateo@intel.com>
 <1402673891-14618-54-git-send-email-oscar.mateo@intel.com>
 <20140618210112.GJ5821@phenom.ffwll.local>
 <92648605EABDA246B775AAB04C95A7A3013208EA@IRSMSX103.ger.corp.intel.com>
 <20140619101357.GB25975@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id 8642E6E028
 for <intel-gfx@lists.freedesktop.org>; Thu, 19 Jun 2014 03:34:02 -0700 (PDT)
In-Reply-To: <20140619101357.GB25975@nuc-i3427.alporthouse.com>
Content-Language: en-US
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Thursday, June 19, 2014 11:14 AM
> To: Mateo Lozano, Oscar
> Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 53/53] !UPSTREAM: drm/i915: Use MMIO
> flips
> =

> On Thu, Jun 19, 2014 at 09:50:33AM +0000, Mateo Lozano, Oscar wrote:
> > > -----Original Message-----
> > > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of
> > > Daniel Vetter
> > > Sent: Wednesday, June 18, 2014 10:01 PM
> > > To: Mateo Lozano, Oscar
> > > Cc: intel-gfx@lists.freedesktop.org
> > > Subject: Re: [Intel-gfx] [PATCH 53/53] !UPSTREAM: drm/i915: Use MMIO
> > > flips
> > >
> > > On Fri, Jun 13, 2014 at 04:38:11PM +0100, oscar.mateo@intel.com
> wrote:
> > > > From: Sourab Gupta <sourab.gupta@intel.com>
> > > >
> > > > If we want flips to work, either we create an Execlists-aware
> > > > version of intel_gen7_queue_flip, or we don't place commands
> > > > directly in the ringbuffer.
> > > >
> > > > When upstreamed, this patch should implement the second option:
> > >
> > > Usually we just mention such requirements in the cover letter of the
> > > series and don't include them.
> > > -Daniel
> >
> > Well, since we have it here, there is something I wanted to ask about t=
his:
> >
> > MODULE_PARM_DESC(use_mmio_flip, "use MMIO flips (-1=3Dnever, 0=3Ddriver
> > discretion [default], 1=3Dalways)");
> >
> > The "driver discretion" option will blow up with Execlists :( How do I
> > tackle this? an execlists version of intel_gen7_queue_flip? sanitizing
> use_mmio_flip when execlists get enabled? I really don=B4t have a prefere=
nce...
> =

> Why does execlist make it hard to add a command to the last lrc that the
> object was on?
> -Chris

Well, it=B4s not hard: up to v2 of the series I reused intel_ring_begin, in=
tel_ring_emit, etc... to simply accept a context (it this case, ring->defau=
lt_context) but since now we have a different set of functions, it needs so=
me more frobbing. Now, I don=B4t mind doing that as a especial case, but I =
was told I shouldn=B4t worry about flips because we were changing them for =
MMIO flips anyway...