From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013EAC433EF for ; Thu, 23 Sep 2021 15:09:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D21FF610C9 for ; Thu, 23 Sep 2021 15:09:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241856AbhIWPLB (ORCPT ); Thu, 23 Sep 2021 11:11:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:57794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241792AbhIWPLA (ORCPT ); Thu, 23 Sep 2021 11:11:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 34A0561211; Thu, 23 Sep 2021 15:09:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632409769; bh=oA+WWs5P3iaZypn5jU4SpKYZzff2WutgvUss6C8I1ls=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=OpjLqQ3wJS0mnuI98GptpCEetjJ7ryrKPRZawRxcJyOjz39Wm0twQ88tzZObVtMa9 QirClY/g+GQBLZejLEdyBfzOjNXKsC8u85V5dflPNMap/uUNEpb4PbYBWqazCivDFw H1CeAhEm7ctFniGz5gqTchtFCM7PmG7d14tcezwZGUo7yhVbFREvm4RmiW4Vx6F0wc 4WM7ylAKNg00kdQNmWhhvx9MxVp5DT7oMWgkYHMm2QA9FOmnbvua9/xgug/pzRWpYI mEno+UW5OxERAGrRNu1ijGqrngs6+dF99CMPNCbq3VGnxP2JfOZVFXYMhHrksK8y0S S0mBdZrDOo02w== Subject: Re: [PATCH] erofs: fix misbehavior of unsupported chunk format check To: Gao Xiang , linux-erofs@lists.ozlabs.org, Liu Bo Cc: LKML References: <20210922095141.233938-1-hsiangkao@linux.alibaba.com> From: Chao Yu Message-ID: <926fb1a9-174e-26de-c9ed-70aa0a01d394@kernel.org> Date: Thu, 23 Sep 2021 23:09:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210922095141.233938-1-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/9/22 17:51, Gao Xiang wrote: > Unsupported chunk format should be checked with > "if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL)" > > Found when checking with 4k-byte blockmap (although currently mkfs That means for 4k-byte blockmap, chunkformat should be zero, right? > uses inode chunk indexes format by default.) > > Fixes: c5aa903a59db ("erofs: support reading chunk-based uncompressed files") > Cc: Liu Bo > Cc: Chao Yu > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,