All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Shelton <ben.shelton@ni.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 20/20] udev: don't halt if devtmpfs can't be mounted
Date: Mon, 4 Aug 2014 13:41:12 -0500	[thread overview]
Message-ID: <9288a31de2b502a43e9d0067ff9c1378133d00a4.1407177403.git.ben.shelton@ni.com> (raw)
In-Reply-To: <cover.1407177403.git.ben.shelton@ni.com>

From: Richard Tollerton <rich.tollerton@ni.com>

Halting if udev cannot start is problematic for a couple reasons.
- Compared to a reboot loop, halting is much more difficult to recover
  from in remote deployments.
- If the rootfs has a prepopulated /dev (which happens somewhat often),
  the system may be able to boot up just fine, or at least fine enough
  for the administrator to log in and fix things.

Instead of halting, just exit, and let the administrator deal with the
potential reboot loop.

Natinst-Rally-ID: TA44427
Acked-by: Gratian Crisan <gratian.crisan@ni.com>
Acked-by: Scot Salmon <scot.salmon@ni.com>
Natinst-ReviewBoard-ID: 58623
Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
---
 meta/recipes-core/udev/udev/init | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index 6caf7d5..f6a8391 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -45,8 +45,7 @@ case "$1" in
     if ! grep -q devtmpfs /proc/filesystems
     then
         echo "Missing devtmpfs, which is required for udev to run";
-        echo "Halting..."
-        halt
+	exit 1
     fi
     # mount the devtmpfs on /dev, if not already done
     LANG=C awk '$2 == "/dev" && ($3 == "devtmpfs") { exit 1 }' /proc/mounts && {
-- 
2.0.4



  parent reply	other threads:[~2014-08-04 18:41 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 18:40 [PATCH 00/20] udev-cache related changes Ben Shelton
2014-08-04 18:40 ` [PATCH 01/20] udev-cache: Compress the cache Ben Shelton
2014-08-04 19:29   ` Otavio Salvador
2014-08-04 22:44   ` Khem Raj
2014-08-04 23:45     ` Ben Shelton
2014-08-05  0:06       ` Khem Raj
2014-08-05 19:00   ` Randy MacLeod
2014-08-05 20:09     ` Otavio Salvador
2014-08-05 20:35       ` Randy MacLeod
2014-08-06  2:08         ` Ben Shelton
2014-08-22 15:24         ` Patch message guidelines and internal/corporate fields Richard Tollerton
2014-08-23  8:40           ` Richard Purdie
2014-08-24 15:33             ` Paul Eggleton
2014-08-25  1:19               ` Khem Raj
2014-08-04 18:40 ` [PATCH 02/20] udev-cache: choose a more descriptive cache filename Ben Shelton
2014-08-04 19:30   ` Otavio Salvador
2014-08-04 18:40 ` [PATCH 03/20] udev-cache: Honor VERBOSE for bootup message Ben Shelton
2014-08-04 19:30   ` Otavio Salvador
2014-08-04 18:40 ` [PATCH 04/20] udev-cache: Don't ignore errors from cache extract Ben Shelton
2014-08-04 19:32   ` Otavio Salvador
2014-08-04 18:40 ` [PATCH 05/20] busybox: tar: enable CONFIG_FEATURE_TAR_LONG_OPTIONS Ben Shelton
2014-08-04 19:33   ` Otavio Salvador
2014-08-04 18:40 ` [PATCH 06/20] udev-cache: Remove superfluous subshell on extract Ben Shelton
2014-08-04 19:33   ` Otavio Salvador
2014-08-04 18:40 ` [PATCH 07/20] udev-cache: Update cache tarball atomically Ben Shelton
2014-08-04 19:35   ` Otavio Salvador
2014-08-04 18:41 ` [PATCH 08/20] udev-cache: Create cache asynchronously Ben Shelton
2014-08-04 19:41   ` Otavio Salvador
2014-08-04 21:18     ` Richard Tollerton
2014-08-04 21:22       ` Otavio Salvador
2014-08-04 21:37         ` Richard Tollerton
2014-08-04 21:41           ` Otavio Salvador
2014-08-04 22:07             ` Richard Tollerton
2014-08-04 18:41 ` [PATCH 09/20] udev-cache.default: documentation update Ben Shelton
2014-08-04 19:42   ` Otavio Salvador
2014-08-04 18:41 ` [PATCH 10/20] udev-cache: parametrize sysconf file paths Ben Shelton
2014-08-04 19:44   ` Otavio Salvador
2014-08-04 21:38     ` Ben Shelton
2014-08-04 21:42       ` Otavio Salvador
2014-08-04 21:48         ` Ben Shelton
2014-08-04 18:41 ` [PATCH 11/20] udev-cache: parametrize tar options Ben Shelton
2014-08-04 19:44   ` Otavio Salvador
2014-08-04 21:40     ` Ben Shelton
2014-08-04 18:41 ` [PATCH 12/20] udev-cache: fix timestamp errors on systems lacking an RTC Ben Shelton
2014-08-04 18:41 ` [PATCH 13/20] udev-cache: Avoid caching udev.cache or non-devfs filesystems Ben Shelton
2014-08-04 18:41 ` [PATCH 14/20] udev-cache: refactor; improve verbosity and error handling Ben Shelton
2014-08-04 18:41 ` [PATCH 15/20] udev-cache: don't attempt to extract cache if it doesn't exist Ben Shelton
2014-08-04 18:41 ` [PATCH 16/20] udev-cache: invalidate on rules.d changes Ben Shelton
2014-08-04 18:41 ` [PATCH 17/20] udev-cache: fix udev-cache changes to work with busybox tar Ben Shelton
2014-08-04 18:41 ` [PATCH 18/20] udev: Make build MACHINE-specific Ben Shelton
2014-08-04 19:43   ` Martin Jansa
2014-08-04 18:41 ` [PATCH 19/20] udev: Disable keymap support on machines lacking keyboard support Ben Shelton
2014-08-04 19:41   ` Martin Jansa
2014-08-04 18:41 ` Ben Shelton [this message]
2014-08-04 19:40   ` [PATCH 20/20] udev: don't halt if devtmpfs can't be mounted Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9288a31de2b502a43e9d0067ff9c1378133d00a4.1407177403.git.ben.shelton@ni.com \
    --to=ben.shelton@ni.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.