From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:52240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hF66d-00028a-Oe for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:01:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hF66b-0000eP-Pi for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:01:15 -0400 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]:44161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hF66Z-0000ce-CW for qemu-devel@nongnu.org; Fri, 12 Apr 2019 20:01:12 -0400 Received: by mail-pl1-x641.google.com with SMTP id g12so5830616pll.11 for ; Fri, 12 Apr 2019 17:01:09 -0700 (PDT) References: <20190411100836.646-1-david@redhat.com> <20190411100836.646-20-david@redhat.com> From: Richard Henderson Message-ID: <92929d01-7607-84ae-c316-3072035ec603@linaro.org> Date: Fri, 12 Apr 2019 14:01:04 -1000 MIME-Version: 1.0 In-Reply-To: <20190411100836.646-20-david@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 19/41] s390x/tcg: Implement VECTOR MULTIPLY AND ADD * List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, Cornelia Huck , Thomas Huth , Richard Henderson On 4/11/19 12:08 AM, David Hildenbrand wrote: > Quite some variants to handle. At least handle some 32-bit element > variants via gvec expansion (we could also handle 16/32-bit variants > for ODD and EVEN easily via gvec expansion, but let's keep it simple > for now). > > Signed-off-by: David Hildenbrand > --- > target/s390x/helper.h | 18 +++++ > target/s390x/insn-data.def | 14 ++++ > target/s390x/translate_vx.inc.c | 122 +++++++++++++++++++++++++++++++ > target/s390x/vec_int_helper.c | 123 ++++++++++++++++++++++++++++++++ > 4 files changed, 277 insertions(+) Reviewed-by: Richard Henderson r~