From: Edward Cree <ecree.xilinx@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH net-next 2/2] net-gro: remove GRO_DROP
Date: Fri, 8 Jan 2021 12:32:59 +0000 [thread overview]
Message-ID: <92939962-8b08-a1fb-4ea5-4eeea6a3709f@gmail.com> (raw)
In-Reply-To: <20210108113903.3779510-3-eric.dumazet@gmail.com>
On 08/01/2021 11:39, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> GRO_DROP can only be returned from napi_gro_frags()
> if the skb has not been allocated by a prior napi_get_frags()
>
> Since drivers must use napi_get_frags() and test its result
> before populating the skb with metadata, we can safely remove
> GRO_DROP since it offers no practical use.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Fwiw,
Acked-by: Edward Cree <ecree.xilinx@gmail.com>
next prev parent reply other threads:[~2021-01-08 12:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 11:39 [PATCH net-next 0/2] net-gro: GRO_DROP deprecation Eric Dumazet
2021-01-08 11:39 ` [PATCH net-next 1/2] ice: drop dead code in ice_receive_skb() Eric Dumazet
2021-01-08 19:33 ` Jesse Brandeburg
2021-01-08 11:39 ` [PATCH net-next 2/2] net-gro: remove GRO_DROP Eric Dumazet
2021-01-08 12:32 ` Edward Cree [this message]
2021-01-10 0:10 ` [PATCH net-next 0/2] net-gro: GRO_DROP deprecation patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92939962-8b08-a1fb-4ea5-4eeea6a3709f@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.