From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 388E9C48BE5 for ; Wed, 16 Jun 2021 13:41:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FBBC6100A for ; Wed, 16 Jun 2021 13:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233240AbhFPNnu (ORCPT ); Wed, 16 Jun 2021 09:43:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:60033 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232199AbhFPNnr (ORCPT ); Wed, 16 Jun 2021 09:43:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623850900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p8GK50I3KBKc8B6YusjGKlCOchxcM/TeXaVsgxynpE4=; b=KaxONaEDpeYNdHhqoI2a26Gqi+BYEJFtj6yRID2YLDx3gGGHOK1T5nqthwAaqT2i/0w48v QiIu/CrJyOhz1j9zA8oUGGm3LnW1oIpQB/yjqHoJ0tLNdUw1suAE0JNfcmM9BfcwayjCSO WWvgKOt79xK78g+sNU9viGn34aMRWKE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-84-PT56Y0xWN_GyKRNQvyK7Zg-1; Wed, 16 Jun 2021 09:41:39 -0400 X-MC-Unique: PT56Y0xWN_GyKRNQvyK7Zg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D78319251AD; Wed, 16 Jun 2021 13:41:38 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-65.rdu2.redhat.com [10.10.118.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FCBF10016F4; Wed, 16 Jun 2021 13:41:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> References: <200ea6f7-0182-9da1-734c-c49102663ccc@redhat.com> <162375813191.653958.11993495571264748407.stgit@warthog.procyon.org.uk> <051421e0-afe8-c6ca-95cd-4dc8cd20a43e@huawei.com> To: Tom Rix Cc: dhowells@redhat.com, Zheng Zengkai , Randy Dunlap , Linus Torvalds , Hulk Robot , linux-afs@lists.infradead.org, Marc Dionne , linux-fsdevel , Linux Kernel Mailing List Subject: Re: [PATCH] afs: fix no return statement in function returning non-void MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <929459.1623850895.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Wed, 16 Jun 2021 14:41:35 +0100 Message-ID: <929460.1623850895@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tom Rix wrote: > A fix is to use the __noreturn attribute on this function and not add a = return > like this > = > -static int afs_dir_set_page_dirty(struct page *page) > +static int __noreturn afs_dir_set_page_dirty(struct page *page) > = > and to the set of ~300 similar functions in these files. BUG() really ought to handle it. Do you have CONFIG_BUG=3Dy? David