From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68810C282CE for ; Tue, 4 Jun 2019 13:32:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4177B24AC0 for ; Tue, 4 Jun 2019 13:32:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4177B24AC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:52761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9Xj-0007Lj-FK for qemu-devel@archiver.kernel.org; Tue, 04 Jun 2019 09:31:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hY9Uy-0005Vv-Mx for qemu-devel@nongnu.org; Tue, 04 Jun 2019 09:29:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hY9Uw-0001NZ-Ve for qemu-devel@nongnu.org; Tue, 04 Jun 2019 09:29:08 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:39380) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hY9Uw-0001KA-KB for qemu-devel@nongnu.org; Tue, 04 Jun 2019 09:29:06 -0400 Received: by mail-wr1-f46.google.com with SMTP id x4so15843881wrt.6 for ; Tue, 04 Jun 2019 06:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w43Jb7h23jtaW99y+wJT93dyU7nE2P8hurZWjwCsfTs=; b=KBY8KODptyMZD8BJjQ4+lR3hZ2uAkYeWC+hWJ5foREO2PhPFu5sXoe+ptmxIprY4X2 EuSHMdKzwEhXyB82Co8VAsUPx6NWBl/FEH0Q+K8m3DkGuX+BYKmWmRfgejprrcYUUTjr xP5LCIqaaIk33FA2NdRrYTjAhthLgkcJ7E7A1bGwcqmD8ft+koRJ4PR75M+v+ao1541p o6idHVK8uxdw8T9d7LsInG/BlmrKU0vXR6M7M6v7v0oYZNfOstB/Px+yIRFP1T/1JC9D nNcIAgtMtnMntZXWWZ97+C8CpzD7WSs7wxOWwSLS+KN6eUEaDhW9qNUMh+2Dfl4U7ijH e9GA== X-Gm-Message-State: APjAAAVG9qekKAU9Csv5z+ak3EzrEcooT8ULnC9VrN1lc4RTnKz8Pz0F 0vH/Wc3uAzARo4Cf0DeYt9NqQpxTYnMCMw== X-Google-Smtp-Source: APXvYqwlVKaihLn80Q/nmRDA2zoaD7LhKb+iu40fTS76AMFhyEr2j4TmfXCJLQAftPybgOrZXNnCLQ== X-Received: by 2002:adf:ea4a:: with SMTP id j10mr179561wrn.114.1559654943448; Tue, 04 Jun 2019 06:29:03 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:657f:501:149f:5617? ([2001:b07:6468:f312:657f:501:149f:5617]) by smtp.gmail.com with ESMTPSA id x16sm5377075wmj.4.2019.06.04.06.29.02 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jun 2019 06:29:02 -0700 (PDT) To: Markus Armbruster , Michal Privoznik References: <20190311220843.4026-1-armbru@redhat.com> <20190311220843.4026-23-armbru@redhat.com> <76d4a7b2-3c13-beea-2dc0-4fda7025030b@redhat.com> <878sv6tyjy.fsf@dusky.pond.sub.org> <87zhmysh2n.fsf@dusky.pond.sub.org> From: Paolo Bonzini Message-ID: <92a2f965-0d17-b6bc-fcfd-2cc088fb77da@redhat.com> Date: Tue, 4 Jun 2019 15:29:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87zhmysh2n.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.221.46 Subject: Re: [Qemu-devel] [PULL 22/27] vl: Create block backends before setting machine properties X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 03/06/19 19:40, Markus Armbruster wrote: > > Paolo, why is pr-manager-helper a delayed object? Why this hunk of > commit 7c9e527659c: > > diff --git a/vl.c b/vl.c > index 9bb5058c3a..a121a65731 100644 > --- a/vl.c > +++ b/vl.c > @@ -2893,7 +2893,8 @@ static int machine_set_property(void *opaque, > */ > static bool object_create_initial(const char *type) > { > - if (g_str_equal(type, "rng-egd")) { > + if (g_str_equal(type, "rng-egd") || > + g_str_has_prefix(type, "pr-manager-")) { > return false; > } > I don't think there was any particular reason. Change it back to normal, I can send a pull request today for that. Paolo