From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F961C433F5 for ; Mon, 16 May 2022 19:06:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345261AbiEPTGa (ORCPT ); Mon, 16 May 2022 15:06:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345349AbiEPTGR (ORCPT ); Mon, 16 May 2022 15:06:17 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5853421268 for ; Mon, 16 May 2022 12:06:15 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPV6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nqg2m-0002na-G3; Mon, 16 May 2022 21:06:12 +0200 Message-ID: <92ae0fd5-f827-ae3c-bbef-d551c9fa5b76@pengutronix.de> Date: Mon, 16 May 2022 21:06:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1] thermal: imx: Make trip point offset configurable Content-Language: en-US To: Francesco Dolcini , Daniel Lezcano , l.stach@pengutronix.de, linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Fabio Estevam , Sascha Hauer , Amit Kucheria , Jon Nettleton , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Tim Harvey , linux-arm-kernel@lists.infradead.org References: <20220516190001.147919-1-francesco.dolcini@toradex.com> From: Ahmad Fatoum In-Reply-To: <20220516190001.147919-1-francesco.dolcini@toradex.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 16.05.22 21:00, Francesco Dolcini wrote: > Currently the imx thermal driver has a hardcoded critical temperature > value offset of 5 Celsius degrees from the actual SoC maximum > temperature. > > This affects applications and systems designed to be working on this close > to the limit, but yet valid, temperature range. > > Given that there is no single value that will fit all the use cases make > the critical trip point offset from the max temperature configurable > using a newly added trip_offset module parameter, passive trip point is > set to 5 Celsius degrees less than the critical. By default the > system behaves exactly as before. > > Link: https://lore.kernel.org/all/20220420091300.179753-1-francesco.dolcini@toradex.com/ > Signed-off-by: Francesco Dolcini > --- > drivers/thermal/imx_thermal.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c > index 16663373b682..42d1f8a3eccb 100644 > --- a/drivers/thermal/imx_thermal.c > +++ b/drivers/thermal/imx_thermal.c > @@ -86,6 +86,10 @@ enum imx_thermal_trip { > #define TEMPMON_IMX6SX 2 > #define TEMPMON_IMX7D 3 > > +static int trip_offset = 5; > +module_param(trip_offset, int, 0444); Is this being r--r--r-- intended? > +MODULE_PARM_DESC(trip_offset, "Critical trip point offset from CPU max temp in Celsius degrees (default 5)"); > + > struct thermal_soc_data { > u32 version; > > @@ -504,11 +508,11 @@ static void imx_init_temp_grade(struct platform_device *pdev, u32 ocotp_mem0) > } > > /* > - * Set the critical trip point at 5 °C under max > - * Set the passive trip point at 10 °C under max (changeable via sysfs) > + * Set the critical trip point at 5 °C under max (changeable via module param) > + * Set the passive trip point at 5 °C under critical (changeable via sysfs) > */ > - data->temp_critical = data->temp_max - (1000 * 5); > - data->temp_passive = data->temp_max - (1000 * 10); > + data->temp_critical = data->temp_max - (1000 * trip_offset); > + data->temp_passive = data->temp_critical - (1000 * 5); > } > > static int imx_init_from_tempmon_data(struct platform_device *pdev) -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 930AAC433EF for ; Mon, 16 May 2022 19:07:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QGiLjls3S/z9MagiddbPFSdodlNNUbitiiX9PpnnyjA=; b=zXbNBi0B+kZ9yr HijyR/hlDg52/J5S6bcOvyfHuIETCyDt/TrcT3aah8GxYT4nHmPb2Kgrf5hey9fcdP8OAyU5YCnHS rzbZUChEwMuV6lpC/IOO9zAvxrMPfqKdbXyPGnCHA8RrLLgG9Mu0fBNVn1JHUbP/aEEeLlJRxD9QG EIEznVY+EwCTZLuv61pSb6Bfy63aywagA7xeb7UdFEqaJc3ULKRm4NrZkpBmmyqfT/+SpklDXjlqL HDFIXspGiMKtaeQkCsDmI9QiRTFOb6eaoP77C9URtXZ3ag0IkZo78oScvtM/R2z4sQWBwzGqNA3Ko U3zoheFz4WPXzhFl3s0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqg36-009ibY-K7; Mon, 16 May 2022 19:06:32 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqg32-009iZZ-SF for linux-arm-kernel@lists.infradead.org; Mon, 16 May 2022 19:06:30 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPV6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nqg2m-0002na-G3; Mon, 16 May 2022 21:06:12 +0200 Message-ID: <92ae0fd5-f827-ae3c-bbef-d551c9fa5b76@pengutronix.de> Date: Mon, 16 May 2022 21:06:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1] thermal: imx: Make trip point offset configurable Content-Language: en-US To: Francesco Dolcini , Daniel Lezcano , l.stach@pengutronix.de, linux-pm@vger.kernel.org Cc: "Rafael J . Wysocki" , Fabio Estevam , Sascha Hauer , Amit Kucheria , Jon Nettleton , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , Tim Harvey , linux-arm-kernel@lists.infradead.org References: <20220516190001.147919-1-francesco.dolcini@toradex.com> From: Ahmad Fatoum In-Reply-To: <20220516190001.147919-1-francesco.dolcini@toradex.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_120628_952426_C18FDDA7 X-CRM114-Status: GOOD ( 24.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTYuMDUuMjIgMjE6MDAsIEZyYW5jZXNjbyBEb2xjaW5pIHdyb3RlOgo+IEN1cnJlbnRseSB0 aGUgaW14IHRoZXJtYWwgZHJpdmVyIGhhcyBhIGhhcmRjb2RlZCBjcml0aWNhbCB0ZW1wZXJhdHVy ZQo+IHZhbHVlIG9mZnNldCBvZiA1IENlbHNpdXMgZGVncmVlcyBmcm9tIHRoZSBhY3R1YWwgU29D IG1heGltdW0KPiB0ZW1wZXJhdHVyZS4KPiAKPiBUaGlzIGFmZmVjdHMgYXBwbGljYXRpb25zIGFu ZCBzeXN0ZW1zIGRlc2lnbmVkIHRvIGJlIHdvcmtpbmcgb24gdGhpcyBjbG9zZQo+IHRvIHRoZSBs aW1pdCwgYnV0IHlldCB2YWxpZCwgdGVtcGVyYXR1cmUgcmFuZ2UuCj4gCj4gR2l2ZW4gdGhhdCB0 aGVyZSBpcyBubyBzaW5nbGUgdmFsdWUgdGhhdCB3aWxsIGZpdCBhbGwgdGhlIHVzZSBjYXNlcyBt YWtlCj4gdGhlIGNyaXRpY2FsIHRyaXAgcG9pbnQgb2Zmc2V0IGZyb20gdGhlIG1heCB0ZW1wZXJh dHVyZSBjb25maWd1cmFibGUKPiB1c2luZyBhIG5ld2x5IGFkZGVkIHRyaXBfb2Zmc2V0IG1vZHVs ZSBwYXJhbWV0ZXIsIHBhc3NpdmUgdHJpcCBwb2ludCBpcwo+IHNldCB0byA1IENlbHNpdXMgZGVn cmVlcyBsZXNzIHRoYW4gdGhlIGNyaXRpY2FsLiBCeSBkZWZhdWx0IHRoZQo+IHN5c3RlbSBiZWhh dmVzIGV4YWN0bHkgYXMgYmVmb3JlLgo+IAo+IExpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3Jn L2FsbC8yMDIyMDQyMDA5MTMwMC4xNzk3NTMtMS1mcmFuY2VzY28uZG9sY2luaUB0b3JhZGV4LmNv bS8KPiBTaWduZWQtb2ZmLWJ5OiBGcmFuY2VzY28gRG9sY2luaSA8ZnJhbmNlc2NvLmRvbGNpbmlA dG9yYWRleC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvdGhlcm1hbC9pbXhfdGhlcm1hbC5jIHwgMTIg KysrKysrKystLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDQgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdGhlcm1hbC9pbXhfdGhlcm1hbC5jIGIv ZHJpdmVycy90aGVybWFsL2lteF90aGVybWFsLmMKPiBpbmRleCAxNjY2MzM3M2I2ODIuLjQyZDFm OGEzZWNjYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3RoZXJtYWwvaW14X3RoZXJtYWwuYwo+ICsr KyBiL2RyaXZlcnMvdGhlcm1hbC9pbXhfdGhlcm1hbC5jCj4gQEAgLTg2LDYgKzg2LDEwIEBAIGVu dW0gaW14X3RoZXJtYWxfdHJpcCB7Cj4gICNkZWZpbmUgVEVNUE1PTl9JTVg2U1gJCQkyCj4gICNk ZWZpbmUgVEVNUE1PTl9JTVg3RAkJCTMKPiAgCj4gK3N0YXRpYyBpbnQgdHJpcF9vZmZzZXQgPSA1 Owo+ICttb2R1bGVfcGFyYW0odHJpcF9vZmZzZXQsIGludCwgMDQ0NCk7CgpJcyB0aGlzIGJlaW5n IHItLXItLXItLSBpbnRlbmRlZD8KCj4gK01PRFVMRV9QQVJNX0RFU0ModHJpcF9vZmZzZXQsICJD cml0aWNhbCB0cmlwIHBvaW50IG9mZnNldCBmcm9tIENQVSBtYXggdGVtcCBpbiBDZWxzaXVzIGRl Z3JlZXMgKGRlZmF1bHQgNSkiKTsKPiArCj4gIHN0cnVjdCB0aGVybWFsX3NvY19kYXRhIHsKPiAg CXUzMiB2ZXJzaW9uOwo+ICAKPiBAQCAtNTA0LDExICs1MDgsMTEgQEAgc3RhdGljIHZvaWQgaW14 X2luaXRfdGVtcF9ncmFkZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LCB1MzIgb2NvdHBf bWVtMCkKPiAgCX0KPiAgCj4gIAkvKgo+IC0JICogU2V0IHRoZSBjcml0aWNhbCB0cmlwIHBvaW50 IGF0IDUgwrBDIHVuZGVyIG1heAo+IC0JICogU2V0IHRoZSBwYXNzaXZlIHRyaXAgcG9pbnQgYXQg MTAgwrBDIHVuZGVyIG1heCAoY2hhbmdlYWJsZSB2aWEgc3lzZnMpCj4gKwkgKiBTZXQgdGhlIGNy aXRpY2FsIHRyaXAgcG9pbnQgYXQgNSDCsEMgdW5kZXIgbWF4IChjaGFuZ2VhYmxlIHZpYSBtb2R1 bGUgcGFyYW0pCj4gKwkgKiBTZXQgdGhlIHBhc3NpdmUgdHJpcCBwb2ludCBhdCA1IMKwQyB1bmRl ciBjcml0aWNhbCAoY2hhbmdlYWJsZSB2aWEgc3lzZnMpCj4gIAkgKi8KPiAtCWRhdGEtPnRlbXBf Y3JpdGljYWwgPSBkYXRhLT50ZW1wX21heCAtICgxMDAwICogNSk7Cj4gLQlkYXRhLT50ZW1wX3Bh c3NpdmUgPSBkYXRhLT50ZW1wX21heCAtICgxMDAwICogMTApOwo+ICsJZGF0YS0+dGVtcF9jcml0 aWNhbCA9IGRhdGEtPnRlbXBfbWF4IC0gKDEwMDAgKiB0cmlwX29mZnNldCk7Cj4gKwlkYXRhLT50 ZW1wX3Bhc3NpdmUgPSBkYXRhLT50ZW1wX2NyaXRpY2FsIC0gKDEwMDAgKiA1KTsKPiAgfQo+ICAK PiAgc3RhdGljIGludCBpbXhfaW5pdF9mcm9tX3RlbXBtb25fZGF0YShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQoKCi0tIApQZW5ndXRyb25peCBlLksuICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfApTdGV1ZXJ3YWxkZXIgU3RyLiAy MSAgICAgICAgICAgICAgICAgICAgICAgfCBodHRwOi8vd3d3LnBlbmd1dHJvbml4LmRlLyAgfAoz MTEzNyBIaWxkZXNoZWltLCBHZXJtYW55ICAgICAgICAgICAgICAgICAgfCBQaG9uZTogKzQ5LTUx MjEtMjA2OTE3LTAgICAgfApBbXRzZ2VyaWNodCBIaWxkZXNoZWltLCBIUkEgMjY4NiAgICAgICAg ICAgfCBGYXg6ICAgKzQ5LTUxMjEtMjA2OTE3LTU1NTUgfAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=