From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A0EC07E94 for ; Fri, 4 Jun 2021 07:53:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99CBB6141B for ; Fri, 4 Jun 2021 07:53:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230196AbhFDHzA (ORCPT ); Fri, 4 Jun 2021 03:55:00 -0400 Received: from lb3-smtp-cloud9.xs4all.net ([194.109.24.30]:60643 "EHLO lb3-smtp-cloud9.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhFDHzA (ORCPT ); Fri, 4 Jun 2021 03:55:00 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud9.xs4all.net with ESMTPA id p4dilRWAahg8Zp4dllzr5a; Fri, 04 Jun 2021 09:53:13 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1622793193; bh=/pdh2RQOsWSUlNkYPjkWUGLFeQ+HjPYjqmui9HhJnaY=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=CjmKm9OMfJay7Fa8xGx6INFhPTbaN4MAVafMxpKIO1myKTHHJZj2/9I0HIVNksIfc WDP+QVgteV8DHC14nCMmegZ3AtyNowG5t5yReTqXisUX+FFosiHfrJSg6cO5zoWTC7 pQgEcJkgv9RrYM9GEdo6PsLZBx0tiShh6YFU3973wGR4QtgSPCJMobDr3prqWQHNwo bsGm8l6LFuebfpk5ONj3YYclxmhG+YEl5ds0lX4svjmAb95uRaRlav+vkBfAfcPbKL hVnXKEnErAyPMdFc5fRm77CrgQUscsYXvAFHOr4utGP/YQnmIOwfcfLlypH2T654iB p92f+RbiNvRJQ== Subject: Re: [PATCH v4 0/2] cec: add tests for Give Deck Status message To: Deborah Brouwer , linux-media@vger.kernel.org Cc: jaffe1@gmail.com References: From: Hans Verkuil Message-ID: <92b0c36a-22ab-708d-4e06-3d80db369f3b@xs4all.nl> Date: Fri, 4 Jun 2021 09:53:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfGYSQbZhraOJNkBDokRkjZwXPzuxzuwkzG/spwrdxr7Lb6mp6vFt0Pkw1jWQuEZPHLS4bSZ6dfvC0FeJvuXRNO0X1DVME90sEKZyHDChz7Ta+YmWcPZ+ NwMl448LzRXSy+gi2R4BJVBnDa9HJfbGsAMdGMUMDBU/3tkcwhiUMhklzMHgWsRToTuT9CeVLmfKBWi0A9GFSfGxg4lPQiubUitXOBhrAMj52fU8p7DOHp6T Edyjj2lcquOCQMOVEjgkpPd0u7yq6UaxHoOZGebGTuA= Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Deb, Thank you for your work, I've applied the patches. One note for future patch series: the cover letter should also explain a bit about what the patch series is about, not just the change history. Something to keep in mind for the next patch series. Regards, Hans On 04/06/2021 04:40, Deborah Brouwer wrote: > Changes since v3: > Patch 1/2: > - Remove the CEC Version checks and else block. > - Add comment explaining why it works for CEC 1.4. > Patch 2/2: > - Keep/add empty line between variable declarations and code. > - Remove restriction to playback or recording devices. > - Extract the deck status where it was previously missed. > - Extend comment to explain CEC_OP_STATUS_REQ_OFF test. > - In the invalid test, remove redundant testing. > > Changes since v2: > Patch 1/2 cec-follower: emulate features for CEC versions < CEC 2.0 > * I already sent this as a single patch, and I have not made > changes since then, I am just including it because now I > need it for Patch 2/2 to apply. > > Patch 2/2 cec: add tests for Give Deck Status message > * Combine functions with same name "deck_ctl_give_status" > to avoid confusion about the naming but also to avoid > returning FAIL rather than using "fail_on_test" directly. > * Expand the "Invalid Operand" test so that it will also test a > follower running version < CEC 2.0. > * Change the invalid operand from 0xaa to 0 and add a test for > invalid operand "4", both just outside of the valid range. > * Expand the "Invalid Operand" test to catch the other reasons > for which a follower might Feature Abort (e.g. Unrecognized > Op). > > Changes since v1: > * Remove unnecessary functions. > * Revise function for turning Give Deck Status reporting On/Off. > * Combine the Give Deck Status Reporting test into the first > Give Deck Status test. > > Deborah Brouwer (2): > cec-follower: emulate features for CEC versions < CEC 2.0 > cec: add tests for Give Deck Status message > > utils/cec-compliance/cec-test.cpp | 72 ++++++++++++++++++++++----- > utils/cec-follower/cec-follower.cpp | 44 +++++++++------- > utils/cec-follower/cec-follower.h | 1 + > utils/cec-follower/cec-processing.cpp | 41 +++++++-------- > utils/libcecutil/cec-info.cpp | 2 - > 5 files changed, 104 insertions(+), 56 deletions(-) > > -- > 2.17.1 >