Re: [PATCH linux v2 17/17] drivers/fsi: Add GPIO master functionality

[Jeremy Kerr <jk@ozlabs.org>]

Hi Chris,

> Add setup of the GPIO pins for FSI master function.
> Set up I/O directions, define all pins needed and
> set up their initial values.  Define serial out
> operation.
> 
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>

Awesome! I assume this is still in development though, right?

>  struct fsi_master_gpio {
>  	struct fsi_master	master;
>  	struct gpio_desc	*gpio_clk;
>  	struct gpio_desc	*gpio_data;
> +	struct gpio_desc	*gpio_trans;		/* Voltage translator */
> +	struct gpio_desc	*gpio_enable;		/* FSI enable */
> +	struct gpio_desc	*gpio_mux;		/* Mux control */
>  };

OK, you should update the device-tree binding to include these extra
GPIOs (and put their descriptions in there). Are they required for all
implementations? (is it possible that some would only have clock and
data?)

Cheers,


Jeremy