From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [dpdk-stable] [PATCH 2/4] net/mlx5: fix flow single queue Date: Wed, 28 Mar 2018 17:38:42 +0100 Message-ID: <92bfeb87-7b01-3c5b-9c49-4b4e7c9f261e@intel.com> References: <7aeb54018d1a8dd06638632076f25fbc88945afd.1518686582.git.nelio.laranjeiro@6wind.com> <07145c9505263ba30de44a5c5186431935b98884.1520950386.git.nelio.laranjeiro@6wind.com> <6b81cc53-f6a5-a5e8-0972-16da937644ab@intel.com> <3e8d0155-ed53-07cc-6344-dfdce1a8b159@intel.com> <20180328113419.g3rmsgcuzn2hpudf@laranjeiro-vm.dev.6wind.com> <5b296774-aec3-b600-e215-7756579654ec@intel.com> <20180328150943.ughfvwa2p5a4hvgi@laranjeiro-vm.dev.6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Shahaf Shuler , Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" , "stable@dpdk.org" To: =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= Return-path: In-Reply-To: <20180328150943.ughfvwa2p5a4hvgi@laranjeiro-vm.dev.6wind.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/28/2018 4:09 PM, Nélio Laranjeiro wrote: > On Wed, Mar 28, 2018 at 02:16:44PM +0100, Ferruh Yigit wrote: >> On 3/28/2018 12:34 PM, Nélio Laranjeiro wrote: >>> On Wed, Mar 28, 2018 at 11:13:42AM +0000, Shahaf Shuler wrote: >>>> Wednesday, March 28, 2018 12:05 PM, Ferruh Yigit: >>>>> On 3/21/2018 6:45 PM, Ferruh Yigit wrote: >>>>>> On 3/13/2018 2:17 PM, Nelio Laranjeiro wrote: >>>>>>> The flow is created with any steering being applied in the NIC when >>>>>>> the device is handling a single Rx queue. >>>>>>> >>>>>>> Fixes: cede123a158f ("net/mlx5: fix flow creation with a single >>>>>>> target queue") >>>>>> >>>>>> This patch is from current release and still in next-net. If it is >>>>>> possible to split this patch to fix issue in this particular commit it >>>>>> can be squashed into original fix. >>>>> >>>> >>>> We can say it only fixes the above and squash the commits. >>> >>> Indeed they are fixing the same issue. >> >> Can you please confirm it is safe to squash this commit [1] into [2]? >> >> [1]: ebfe9a38cb47 ("net/mlx5: fix flow single queue") >> [2]: cede123a158f ("net/mlx5: fix flow creation with a single target queue") > > I confirm, [1] is a fix fixing a bug introduced in [2]. Both are needed > to fix the same bug, they should be squash in a single commit. [1] Squashed into relevant commit [2] in next-net, thanks. (There were a few conflicts, please check latest next-net.)