From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Peter Xu <peterx@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30
Date: Wed, 7 Nov 2018 10:53:08 -0600 [thread overview]
Message-ID: <92c2ae1e-a081-4cce-53c5-d8fd3222d3c1@redhat.com> (raw)
In-Reply-To: <CAFEAcA_FhkA_1DiDM2PWDw27dupsAdP==kBUxRrw5rGDnLzMwg@mail.gmail.com>
On 11/7/18 5:21 AM, Peter Maydell wrote:
> On 7 November 2018 at 02:56, Peter Xu <peterx@redhat.com> wrote:
>> Strange, "make check -j8" failed on my hosts (I tried two) with either
>> Markus's pull tree or qemu master:
>>
>> hw/core/ptimer.o: In function `timer_new_tl':
>> /home/xz/git/qemu/include/qemu/timer.h:536: undefined reference to `timer_init_tl'
>> collect2: error: ld returned 1 exit status
>> make: *** [/home/xz/git/qemu/rules.mak:124: tests/ptimer-test] Error 1
>>
>> Is that only happening on my hosts?
>
> Commit 89a603a0c80ae3 changed things so that there is no
> timer_new_tl() or timer_init_tl() any more, so if you have
> an object file that's referring to it then it's probably
> stale. Try a make clean.
I ran into it as well:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg00876.html
Wonder what makefile dependency we are missing that is resulting in
stale .o files being picked up?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-11-07 16:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 19:16 [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30 Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 1/8] monitor: guard iothread access by mon->use_io_thread Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 2/8] monitor: delay monitor iothread creation Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 3/8] monitor: Suspend monitor instead dropping commands Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 4/8] monitor: remove "x-oob", turn oob on by default Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 5/8] Revert "tests: Add parameter to qtest_init_without_qmp_handshake" Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 6/8] tests: add oob functional test for test-qmp-cmds Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 7/8] tests: qmp-test: add queue full test Markus Armbruster
2018-10-30 19:16 ` [Qemu-devel] [PULL 8/8] vl: Avoid crash when -mon is underspecified Markus Armbruster
2018-11-01 11:50 ` [Qemu-devel] [PULL 0/8] Monitor patches for 2018-10-30 Peter Maydell
2018-11-06 15:56 ` Markus Armbruster
2018-11-07 2:56 ` Peter Xu
2018-11-07 11:21 ` Peter Maydell
2018-11-07 16:53 ` Eric Blake [this message]
2018-11-08 2:44 ` Peter Xu
2018-11-19 6:17 ` Peter Xu
2018-11-19 7:05 ` Peter Xu
2018-11-19 18:08 ` Markus Armbruster
2018-11-20 6:31 ` Peter Xu
2018-11-20 17:44 ` Markus Armbruster
2018-11-21 3:28 ` Peter Xu
2018-11-21 7:00 ` Markus Armbruster
2018-11-27 9:36 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c2ae1e-a081-4cce-53c5-d8fd3222d3c1@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.