From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"David Ahern" <dsahern@kernel.org>,
"Wei Wang" <weiwan@google.com>,
"Maciej Żenczykowski" <maze@google.com>
Subject: Re: [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc()
Date: Fri, 8 May 2020 09:03:57 -0600 [thread overview]
Message-ID: <92c6ab11-3022-a01a-95db-13f6da8637cc@gmail.com> (raw)
In-Reply-To: <a5f381b0-e2bf-05f9-a849-d9d45aa38212@gmail.com>
On 5/8/20 8:43 AM, Eric Dumazet wrote:
> This patch can be backported without any pains ;)
sure, but you tagged it as net-next, not net.
>
> Getting rid of limits, even for exceptions ?
Running through where dst entries are created in IPv6:
1. pcpu cache
2. uncached_list
3. exceptions like pmtu and redirect
All of those match IPv4 and as I recall IPv4 does not have any limits,
even on exceptions and redirect. If IPv4 does not have limits, why
should IPv6? And if the argument is uncontrolled memory consumption, is
there an expectation that IPv6 generates more exceptions?
My argument really just boils down to consistency between them. IPv4
does not use DST_NOCOUNT, so why put that burden on v6?
next prev parent reply other threads:[~2020-05-08 15:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 14:34 [PATCH net-next] ipv6: use DST_NOCOUNT in ip6_rt_pcpu_alloc() Eric Dumazet
2020-05-08 14:39 ` David Ahern
2020-05-08 14:43 ` Eric Dumazet
2020-05-08 15:03 ` David Ahern [this message]
2020-05-08 15:13 ` Eric Dumazet
2020-05-08 16:31 ` Wei Wang
2020-05-09 5:34 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c6ab11-3022-a01a-95db-13f6da8637cc@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kafai@fb.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.