From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA52FC433EF for ; Sun, 5 Sep 2021 02:59:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B0A160F4C for ; Sun, 5 Sep 2021 02:59:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4B0A160F4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SW+e3rfl1WK8b4C/FcV8VF2Pe4ZrL4YRlc5FpAlO1ig=; b=Z5pjMIs3ORx419uGYaNUdVoQ4H tF2QalnzzGoyHX980aVIv/u2cXOqyVSwoNURRW81yMCaT27iB5i0py8anHqeuWwvMjB6Q4EfmkLTO +dli1KkSFPoCOW2jdXhIcmUutb3d3hwYVurzkAr2w39QcfojbsQyRVDb3o01+5lh72cHmFCWIuuUB BMlvHc+I4FgG8gdBhwWj2u/rUkJUnHnpSlEbqR1HvcPEsRTcFMWt5sRzcQPhA+2pjrGbwjcgFSv9j EGtOfkyNDPsRKE2aHwSlZ0eNWZ7IeU7WI1MaIeuHTxyVUIqTLCry05yZV73/e/R5fUu4BfxPtcIaq 6eXOmZxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMiM4-00F776-DQ; Sun, 05 Sep 2021 02:58:00 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMiM0-00F73I-Rb for linux-arm-kernel@lists.infradead.org; Sun, 05 Sep 2021 02:57:58 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9264283130; Sun, 5 Sep 2021 04:57:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1630810672; bh=qiN9dioENCGJUa2I9kFuzDKeZAMaX+YdZmeq3+XsMps=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iVtQzrSHTyjhKJ8lGZed8GbwIgtMU9iE92DAgYpmBylb8HyGsTGtDu/Y6ai5lYh04 Ibz8XyonsU6MjmqSyNND8G+WAunGS96LENi1gupimtm/N+LnmT4taJ3fjDA9wl7DD1 fe7YHVYXHLm7nuM/Eza90TYzPYErHplNRhDNyrYEF1jRS4H72B7HtkF0/3nnYUr8rO PFOfL1W2mJJj0xoO4TAyLDgnPJQoUd1e5tPFew5apOjL/9sC+46vcmruV4pL9ElN0d OO8b88caVNaqM62jVLtUBTTkclArLHpBm/VJOP4CjFaVTM3WOLFjRYqQym5FjDhWU9 T6g/h+/b6jKBQ== Subject: Re: [PATCH] ARM: dts: imx: Fix USB host power regulator polarity on M53Menlo To: Fabio Estevam Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Shawn Guo , NXP Linux Team References: <20210905000137.95438-1-marex@denx.de> From: Marek Vasut Message-ID: <92d00e82-737b-7380-00aa-fb49656ff8e7@denx.de> Date: Sun, 5 Sep 2021 04:57:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210904_195757_145970_FF3785F7 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/5/21 2:49 AM, Fabio Estevam wrote: > Hi Marek, > > On Sat, Sep 4, 2021 at 9:01 PM Marek Vasut wrote: >> >> The MIC2025 switch input signal nEN is active low, describe it as such >> in the DT. The previous change to this regulator polarity was incorrectly >> influenced by broken quirks in gpiolib-of.c, which is now long fixed. So >> fix this regulator polarity setting here once and for all. >> >> Fixes: 3c3601cd6a6d3 ("ARM: dts: imx53: Update USB configuration on M53Menlo") >> Signed-off-by: Marek Vasut >> Cc: Shawn Guo >> Cc: Fabio Estevam >> Cc: NXP Linux Team >> --- >> arch/arm/boot/dts/imx53-m53menlo.dts | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts >> index 48adcfd32cea9..4f88e96d81ddb 100644 >> --- a/arch/arm/boot/dts/imx53-m53menlo.dts >> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts >> @@ -77,8 +77,7 @@ reg_usbh1_vbus: regulator-usbh1-vbus { >> regulator-name = "vbus"; >> regulator-min-microvolt = <5000000>; >> regulator-max-microvolt = <5000000>; >> - gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>; >> - enable-active-high; >> + gpio = <&gpio1 2 0>; > > Don't you mean: gpio = <&gpio1 2 GPIO_ACTIVE_LOW> here? No, the GPIO flags are ignored by gpiolib-of and the signal is active low. That's why there is that zero, no flags, and no enable-active-high property. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel