From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970852C9C for ; Sat, 31 Dec 2022 18:58:43 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id f34so36171960lfv.10 for ; Sat, 31 Dec 2022 10:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+f6MEHPvraJbIhg/Qh3EFX2QlA+pVzk6PS1RzpejfpU=; b=mm3rbNvErKbm878y6ZLKO1BRezWJCBTu40Aw7nN6SC3nL6oJPiv5NeSsIlrJzNCIbp ZRDOe0BQ1Ch84+IMryAV9ZLzjpNG/UAaaXQFnv0oTvj9CJBq+UueBnEXN1N85nBnud4L 5q9pflE6Cz7vI7A2XGBRgpVVGCPOhb39Sdcxgi1WpSlaeZS9cuMSnEzgkG244Ny6x+/7 KLIA1Jw11GUCtITafrih993ehavRbxdQ50Ya4g7ei/mE2gBmWJpuEJqs/vApnsY1HeGR Uwt4c1ihY6b3SERs5S64i21VDRMGTIUZ3UeC9pRcfUj93ZA5WWHbglMljiKP0BRVnRtE MZBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+f6MEHPvraJbIhg/Qh3EFX2QlA+pVzk6PS1RzpejfpU=; b=iTVMp2m1rlU4j7lNIFSxFQRLvnBzbRw3Opj4Q/PaFQFjXFZnQ26n56oV6tHEXxK1ZY qFemCOkc/BWxEQx6ZcJsrVu7Y1kAxjuQ9qoYxHSbV6WFfgvdaYYfdO6MWs2P+a5XwvzF FDjLF5tZhotWucmTJ8afP5ju1Fgt5wD32DpwnACsEs6740alzY9Oe2OIbdDAMj2ox/Ww tC6EZPvIkp8RDY3ZECrZL6nDQJT2swvIrNlybR8PnFmaTdNxGWJ6KL7lTY4aV39lZzef 9Pt+vSbNaybYusn9taEcbFSFq8XCgT+Rs/yOnDc9rnLX0xw85BwZZKEp0M7eY6368taL 4BoA== X-Gm-Message-State: AFqh2kqXIswqIal2viWHMq23xxBeqejTi+zw1iB6bz/AzlHMRCGACijB fYP5qYVaxuKuCPa5FJgPG3WsWA== X-Google-Smtp-Source: AMrXdXu3hVDP0pdMCRE0xDMOyOhqgWtFfHo8ZaBoTE2AP8DSG03gyX4aawLsVQD04bpROMi9ee4vzw== X-Received: by 2002:a05:6512:3d9e:b0:4b5:5efe:966e with SMTP id k30-20020a0565123d9e00b004b55efe966emr13561654lfv.15.1672513121712; Sat, 31 Dec 2022 10:58:41 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id q14-20020a056512210e00b004a2c447598fsm3910225lfr.159.2022.12.31.10.58.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Dec 2022 10:58:41 -0800 (PST) Message-ID: <92dbd096-b02f-b5e5-6275-a37a3d582685@linaro.org> Date: Sat, 31 Dec 2022 19:58:39 +0100 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] dt-bindings: power: Add Allwinner D1 PPU Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring Cc: Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20221231160402.16157-1-samuel@sholland.org> <20221231160402.16157-2-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20221231160402.16157-2-samuel@sholland.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/12/2022 17:04, Samuel Holland wrote: > The Allwinner D1 family of SoCs contain a "PPU" power domain controller > separate from the PRCM. It can power down the video engine and DSP, and > it contains special logic for hardware-assisted CPU idle. Other recent > Allwinner SoCs (e.g. TV303) have a PPU with a different set of domains. > > Signed-off-by: Samuel Holland > --- > > .../power/allwinner,sun20i-d1-ppu.yaml | 54 +++++++++++++++++++ > .../power/allwinner,sun20i-d1-ppu.h | 10 ++++ > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > create mode 100644 include/dt-bindings/power/allwinner,sun20i-d1-ppu.h > > diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > new file mode 100644 > index 000000000000..64c9a9f398a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/allwinner,sun20i-d1-ppu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SoCs "PPU" power domain controller Drop quotes over "PPU" - it's not some nickname, alias, but acronym. Explain the acronym in description. > + > +maintainers: > + - Samuel Holland > + > +description: > + D1 and related SoCs contain a power domain controller for the CPUs, GPU, and > + video-related hardware. > + > +properties: > + compatible: > + enum: > + - allwinner,sun20i-d1-ppu > + > + reg: > + maxItems: 1 > + > + clocks: > + description: Bus Clock > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + '#power-domain-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - '#power-domain-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + ppu: power-controller@7001000 { > + compatible = "allwinner,sun20i-d1-ppu"; Use 4 spaces for example indentation. With above: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92E83C4332F for ; Sat, 31 Dec 2022 19:01:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AljUulbZaieQp9z+OG/lnfxFYVTJLp+u150J94KlGjs=; b=x1Dyz0DQTJUm+H 8oqeiqzoh/gVOgLLSdhns1GPwEFdj0qmMKUMQve2W68rc9SBEeGmYr51d1mnmISmWqep7lYTqfWUR XLF7eHPCXRTGzGVbCn2AOAJkb+3KVDunfniuMFsYSgUFDs357Ji+IjoOxBv6QJ+BwGf1FN085fSxU DxBCyrmGLjhMKXSyQyNSk8ChfXtqv89Zl8eq6T4rtzrX3VUu6kD8lMtLFD7fMmtWOVwt4iFJF3ym5 utCUvPQ4KqvbzCYxu7eEV99VmUExruP46CE4ajS2E4EHcTmKzZRz4kLHejcDlE86jS9694dPcg3P8 S/R0FYEP6Aj+i4RuunhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBh4d-0097Gy-Si; Sat, 31 Dec 2022 18:59:16 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pBh49-0096mw-1f for linux-arm-kernel@lists.infradead.org; Sat, 31 Dec 2022 18:58:48 +0000 Received: by mail-lf1-x130.google.com with SMTP id bp15so36190424lfb.13 for ; Sat, 31 Dec 2022 10:58:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+f6MEHPvraJbIhg/Qh3EFX2QlA+pVzk6PS1RzpejfpU=; b=mm3rbNvErKbm878y6ZLKO1BRezWJCBTu40Aw7nN6SC3nL6oJPiv5NeSsIlrJzNCIbp ZRDOe0BQ1Ch84+IMryAV9ZLzjpNG/UAaaXQFnv0oTvj9CJBq+UueBnEXN1N85nBnud4L 5q9pflE6Cz7vI7A2XGBRgpVVGCPOhb39Sdcxgi1WpSlaeZS9cuMSnEzgkG244Ny6x+/7 KLIA1Jw11GUCtITafrih993ehavRbxdQ50Ya4g7ei/mE2gBmWJpuEJqs/vApnsY1HeGR Uwt4c1ihY6b3SERs5S64i21VDRMGTIUZ3UeC9pRcfUj93ZA5WWHbglMljiKP0BRVnRtE MZBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+f6MEHPvraJbIhg/Qh3EFX2QlA+pVzk6PS1RzpejfpU=; b=sWJoXwPmlwgti17P91KkPYbhE8+HlRvfBpmwspXFCkzGYEHzEqR3R8H+1ItgM5+6nM HgEN0vMPgkS/N2375xNwGS8dYc4Yhacr++hLesN8Jxcp88Q8pmVfb8IO+fCwJ79ZQrgK c2HCe7VEMpYVvpEboKtcci7vSooalVx2/JnVFzGk+hoEBy/fkCjiRgjfWVbnvESIYH1i /BQKCcXxn9BmR79+FYfzmiBzrqnU+N5xElseiVTIzTO6pZ/u6zHnV1d1uTepWes4JTdA UeOBnQE3d1GW1dURjCjefxCZeZcKuyqPqFlPoiLWJSIv6lOjnEIz2ONAxoIDujvvDYFO j4Jw== X-Gm-Message-State: AFqh2kqlNP2SgouVVnwEcuKktW/7O4IPKp9kZhD2PnQJG6YPx/Lqq3k8 JY2pK13sLQ5n4rbyICdhrvqXAw== X-Google-Smtp-Source: AMrXdXu3hVDP0pdMCRE0xDMOyOhqgWtFfHo8ZaBoTE2AP8DSG03gyX4aawLsVQD04bpROMi9ee4vzw== X-Received: by 2002:a05:6512:3d9e:b0:4b5:5efe:966e with SMTP id k30-20020a0565123d9e00b004b55efe966emr13561654lfv.15.1672513121712; Sat, 31 Dec 2022 10:58:41 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id q14-20020a056512210e00b004a2c447598fsm3910225lfr.159.2022.12.31.10.58.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Dec 2022 10:58:41 -0800 (PST) Message-ID: <92dbd096-b02f-b5e5-6275-a37a3d582685@linaro.org> Date: Sat, 31 Dec 2022 19:58:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/2] dt-bindings: power: Add Allwinner D1 PPU Content-Language: en-US To: Samuel Holland , Chen-Yu Tsai , Jernej Skrabec , Krzysztof Kozlowski , Rob Herring Cc: Philipp Zabel , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev References: <20221231160402.16157-1-samuel@sholland.org> <20221231160402.16157-2-samuel@sholland.org> From: Krzysztof Kozlowski In-Reply-To: <20221231160402.16157-2-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221231_105845_174449_C3713C6B X-CRM114-Status: GOOD ( 16.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/12/2022 17:04, Samuel Holland wrote: > The Allwinner D1 family of SoCs contain a "PPU" power domain controller > separate from the PRCM. It can power down the video engine and DSP, and > it contains special logic for hardware-assisted CPU idle. Other recent > Allwinner SoCs (e.g. TV303) have a PPU with a different set of domains. > > Signed-off-by: Samuel Holland > --- > > .../power/allwinner,sun20i-d1-ppu.yaml | 54 +++++++++++++++++++ > .../power/allwinner,sun20i-d1-ppu.h | 10 ++++ > 2 files changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > create mode 100644 include/dt-bindings/power/allwinner,sun20i-d1-ppu.h > > diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > new file mode 100644 > index 000000000000..64c9a9f398a2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/allwinner,sun20i-d1-ppu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner SoCs "PPU" power domain controller Drop quotes over "PPU" - it's not some nickname, alias, but acronym. Explain the acronym in description. > + > +maintainers: > + - Samuel Holland > + > +description: > + D1 and related SoCs contain a power domain controller for the CPUs, GPU, and > + video-related hardware. > + > +properties: > + compatible: > + enum: > + - allwinner,sun20i-d1-ppu > + > + reg: > + maxItems: 1 > + > + clocks: > + description: Bus Clock > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + '#power-domain-cells': > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - '#power-domain-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + ppu: power-controller@7001000 { > + compatible = "allwinner,sun20i-d1-ppu"; Use 4 spaces for example indentation. With above: Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel