From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 9/9] drm/i915: Expand subslice mask Date: Wed, 24 Jul 2019 14:05:53 +0100 Message-ID: <92ddc444-d45e-1ecc-7fc2-2bda4fae13ed@linux.intel.com> References: <20190723154934.26967-1-stuart.summers@intel.com> <20190723154934.26967-10-stuart.summers@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190723154934.26967-10-stuart.summers@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Stuart Summers , intel-gfx@lists.freedesktop.org Cc: intel-gfx-trybot@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIzLzA3LzIwMTkgMTY6NDksIFN0dWFydCBTdW1tZXJzIHdyb3RlOgo+IEN1cnJlbnRseSwg dGhlIHN1YnNsaWNlX21hc2sgcnVudGltZSBwYXJhbWV0ZXIgaXMgc3RvcmVkIGFzIGFuCj4gYXJy YXkgb2Ygc3Vic2xpY2VzIHBlciBzbGljZS4gRXhwYW5kIHRoZSBzdWJzbGljZSBtYXNrIGFycmF5 IHRvCj4gYmV0dGVyIG1hdGNoIHdoYXQgaXMgcHJlc2VudGVkIHRvIHVzZXJzcGFjZSB0aHJvdWdo IHRoZQo+IEk5MTVfUVVFUllfVE9QT0xPR1lfSU5GTyBpb2N0bC4gVGhlIGluZGV4IGludG8gdGhp cyBhcnJheSBpcwo+IHRoZW4gY2FsY3VsYXRlZDoKPiAgICBzbGljZSAqIHN1YnNsaWNlIHN0cmlk ZSArIHN1YnNsaWNlIGluZGV4IC8gOAo+IAo+IFNpZ25lZC1vZmYtYnk6IFN0dWFydCBTdW1tZXJz IDxzdHVhcnQuc3VtbWVyc0BpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkx NS9ndC9pbnRlbF9zc2V1LmMgICAgICAgIHwgMjYgKysrKysrKysrKysrKysrKysrKystCj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9zc2V1LmggICAgICAgIHwgIDUgKysrLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfd29ya2Fyb3VuZHMuYyB8ICAzICstLQo+ICAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgICAgICAgICB8ICA1ICsrKy0KPiAg IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMgICAgfCAgOCArKystLS0t Cj4gICA1IGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4g Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3NzZXUuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3NzZXUuYwo+IGluZGV4IDYwN2MxNDQ3Mjg3Yy4u N2FiYzI0ODdiOTk0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVs X3NzZXUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3NzZXUuYwo+IEBA IC0zMCw2ICszMCwzMCBAQCBpbnRlbF9zc2V1X3N1YnNsaWNlX3RvdGFsKGNvbnN0IHN0cnVjdCBz c2V1X2Rldl9pbmZvICpzc2V1KQo+ICAgCXJldHVybiB0b3RhbDsKPiAgIH0KPiAgIAo+ICt1MzIg aW50ZWxfc3NldV9nZXRfc3Vic2xpY2VzKGNvbnN0IHN0cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1 LCB1OCBzbGljZSkKPiArewo+ICsJaW50IGksIG9mZnNldCA9IHNsaWNlICogc3NldS0+c3Nfc3Ry aWRlOwo+ICsJdTMyIG1hc2sgPSAwOwo+ICsKPiArCWlmIChzbGljZSA+PSBzc2V1LT5tYXhfc2xp Y2VzKSB7Cj4gKwkJRFJNX0VSUk9SKCIlczogaW52YWxpZCBzbGljZSAlZCwgbWF4OiAlZFxuIiwK PiArCQkJICBfX2Z1bmNfXywgc2xpY2UsIHNzZXUtPm1heF9zbGljZXMpOwo+ICsJCXJldHVybiAw Owo+ICsJfQo+ICsKPiArCWlmIChzc2V1LT5zc19zdHJpZGUgPiBzaXplb2YobWFzaykpIHsKPiAr CQlEUk1fRVJST1IoIiVzOiBpbnZhbGlkIHN1YnNsaWNlIHN0cmlkZSAlZCwgbWF4OiAlbHVcbiIs Cj4gKwkJCSAgX19mdW5jX18sIHNzZXUtPnNzX3N0cmlkZSwgc2l6ZW9mKG1hc2spKTsKPiArCQly ZXR1cm4gMDsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAwOyBpIDwgc3NldS0+c3Nfc3RyaWRlOyBp KyspCj4gKwkJbWFzayB8PSAodTMyKXNzZXUtPnN1YnNsaWNlX21hc2tbb2Zmc2V0ICsgaV0gPDwK PiArCQkJaSAqIEJJVFNfUEVSX0JZVEU7Cj4gKwo+ICsJcmV0dXJuIG1hc2s7Cj4gK30KCldoeSBk byB5b3UgYWN0dWFsbHkgbmVlZCB0aGVzZSBjb21wbGljYXRpb25zIHdoZW4gdGhlIHBsYW4gZnJv bSB0aGUgCnN0YXJ0IHdhcyB0aGF0IHRoZSBkcml2ZXIgYW5kIHVzZXIgc3NldSByZXByZXNlbnRh dGlvbiBzdHJ1Y3R1cmVzIGNhbiBiZSAKZGlmZmVyZW50PwoKSSBvbmx5IGdhdmUgaXQgYSBxdWlj ayBsb29rIHNvIEkgbWlnaHQgYmUgd3JvbmcsIGJ1dCB3aHkgbm90IGp1c3QgZXhwYW5kIAp0aGUg ZHJpdmVyIHJlcHJlc2VudGF0aW9ucyBvZiBzdWJzbGljZSBtYXNrIHVwIGZyb20gdTg/IFVzZXJz cGFjZSBBUEkgCnNob3VsZCBiZSBhYmxlIHRvIGNvcGUgd2l0aCBzdHJpZGVzIGFscmVhZHkuCgpS ZWdhcmRzLAoKVHZydGtvCgo+ICsKPiAgIHZvaWQgaW50ZWxfc3NldV9zZXRfc3Vic2xpY2VzKHN0 cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1LCBpbnQgc2xpY2UsCj4gICAJCQkgICAgICB1MzIgc3Nf bWFzaykKPiAgIHsKPiBAQCAtNDMsNyArNjcsNyBAQCB2b2lkIGludGVsX3NzZXVfc2V0X3N1YnNs aWNlcyhzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSwgaW50IHNsaWNlLAo+ICAgdW5zaWduZWQg aW50Cj4gICBpbnRlbF9zc2V1X3N1YnNsaWNlc19wZXJfc2xpY2UoY29uc3Qgc3RydWN0IHNzZXVf ZGV2X2luZm8gKnNzZXUsIHU4IHNsaWNlKQo+ICAgewo+IC0JcmV0dXJuIGh3ZWlnaHQ4KHNzZXUt PnN1YnNsaWNlX21hc2tbc2xpY2VdKTsKPiArCXJldHVybiBod2VpZ2h0MzIoaW50ZWxfc3NldV9n ZXRfc3Vic2xpY2VzKHNzZXUsIHNsaWNlKSk7Cj4gICB9Cj4gICAKPiAgIHUzMiBpbnRlbF9zc2V1 X21ha2VfcnBjcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfc3NldS5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfc3NldS5oCj4gaW5kZXggMGVjYzFjMzVhN2ExLi4yMjkxNzY0YjdkYjUgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfc3NldS5oCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfc3NldS5oCj4gQEAgLTE1LDEwICsxNSwxMSBA QCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZTsKPiAgICNkZWZpbmUgR0VOX01BWF9TTElDRVMJCSg2 KSAvKiBDTkwgdXBwZXIgYm91bmQgKi8KPiAgICNkZWZpbmUgR0VOX01BWF9TVUJTTElDRVMJKDgp IC8qIElDTCB1cHBlciBib3VuZCAqLwo+ICAgI2RlZmluZSBHRU5fU1NFVV9TVFJJREUobWF4X2Vu dHJpZXMpIERJVl9ST1VORF9VUChtYXhfZW50cmllcywgQklUU19QRVJfQllURSkKPiArI2RlZmlu ZSBHRU5fTUFYX1NVQlNMSUNFX1NUUklERSBHRU5fU1NFVV9TVFJJREUoR0VOX01BWF9TVUJTTElD RVMpCj4gICAKPiAgIHN0cnVjdCBzc2V1X2Rldl9pbmZvIHsKPiAgIAl1OCBzbGljZV9tYXNrOwo+ IC0JdTggc3Vic2xpY2VfbWFza1tHRU5fTUFYX1NMSUNFU107Cj4gKwl1OCBzdWJzbGljZV9tYXNr W0dFTl9NQVhfU0xJQ0VTICogR0VOX01BWF9TVUJTTElDRV9TVFJJREVdOwo+ICAgCXUxNiBldV90 b3RhbDsKPiAgIAl1OCBldV9wZXJfc3Vic2xpY2U7Cj4gICAJdTggbWluX2V1X2luX3Bvb2w7Cj4g QEAgLTg1LDYgKzg2LDggQEAgaW50ZWxfc3NldV9zdWJzbGljZV90b3RhbChjb25zdCBzdHJ1Y3Qg c3NldV9kZXZfaW5mbyAqc3NldSk7Cj4gICB1bnNpZ25lZCBpbnQKPiAgIGludGVsX3NzZXVfc3Vi c2xpY2VzX3Blcl9zbGljZShjb25zdCBzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3NldSwgdTggc2xp Y2UpOwo+ICAgCj4gK3UzMiAgaW50ZWxfc3NldV9nZXRfc3Vic2xpY2VzKGNvbnN0IHN0cnVjdCBz c2V1X2Rldl9pbmZvICpzc2V1LCB1OCBzbGljZSk7Cj4gKwo+ICAgdm9pZCBpbnRlbF9zc2V1X3Nl dF9zdWJzbGljZXMoc3RydWN0IHNzZXVfZGV2X2luZm8gKnNzZXUsIGludCBzbGljZSwKPiAgIAkJ CSAgICAgIHUzMiBzc19tYXNrKTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50 ZWxfd29ya2Fyb3VuZHMuYwo+IGluZGV4IDcwNGFjZTAxZTdmNS4uN2VjNjA0MzVkODcxIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX3dvcmthcm91bmRzLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF93b3JrYXJvdW5kcy5jCj4gQEAgLTc5 NCw4ICs3OTQsNyBAQCB3YV9pbml0X21jcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwg c3RydWN0IGk5MTVfd2FfbGlzdCAqd2FsKQo+ICAgCX0KPiAgIAo+ICAgCXNsaWNlID0gZmxzKHNz ZXUtPnNsaWNlX21hc2spIC0gMTsKPiAtCUdFTV9CVUdfT04oc2xpY2UgPj0gQVJSQVlfU0laRShz c2V1LT5zdWJzbGljZV9tYXNrKSk7Cj4gLQlzdWJzbGljZSA9IGZscyhsM19lbiAmIHNzZXUtPnN1 YnNsaWNlX21hc2tbc2xpY2VdKTsKPiArCXN1YnNsaWNlID0gZmxzKGwzX2VuICYgaW50ZWxfc3Nl dV9nZXRfc3Vic2xpY2VzKHNzZXUsIHNsaWNlKSk7Cj4gICAJaWYgKCFzdWJzbGljZSkgewo+ICAg CQlEUk1fV0FSTigiTm8gY29tbW9uIGluZGV4IGZvdW5kIGJldHdlZW4gc3Vic2xpY2UgbWFzayAl eCBhbmQgTDMgYmFuayBtYXNrICV4IVxuIiwKPiAgIAkJCSBzc2V1LT5zdWJzbGljZV9tYXNrW3Ns aWNlXSwgbDNfZW4pOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gaW5kZXggN2Y4 NDI1MDZiOWVhLi45NmEyNWE3NzBhZGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVn ZnMuYwo+IEBAIC0zOTQ0LDEzICszOTQ0LDE2IEBAIHN0YXRpYyB2b2lkIGdlbjlfc3NldV9kZXZp Y2Vfc3RhdHVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgIAo+ICAgCQlm b3IgKHNzID0gMDsgc3MgPCBpbmZvLT5zc2V1Lm1heF9zdWJzbGljZXM7IHNzKyspIHsKPiAgIAkJ CXVuc2lnbmVkIGludCBldV9jbnQ7Cj4gKwkJCXU4IHNzX2lkeCA9IHMgKiBpbmZvLT5zc2V1LnNz X3N0cmlkZSArCj4gKwkJCQkgICAgc3MgLyBCSVRTX1BFUl9CWVRFOwo+ICAgCj4gICAJCQlpZiAo SVNfR0VOOV9MUChkZXZfcHJpdikpIHsKPiAgIAkJCQlpZiAoIShzX3JlZ1tzXSAmIChHRU45X1BH Q1RMX1NTX0FDSyhzcykpKSkKPiAgIAkJCQkJLyogc2tpcCBkaXNhYmxlZCBzdWJzbGljZSAqLwo+ ICAgCQkJCQljb250aW51ZTsKPiAgIAo+IC0JCQkJc3NldS0+c3Vic2xpY2VfbWFza1tzXSB8PSBC SVQoc3MpOwo+ICsJCQkJc3NldS0+c3Vic2xpY2VfbWFza1tzc19pZHhdIHw9Cj4gKwkJCQkJQklU KHNzICUgQklUU19QRVJfQllURSk7Cj4gICAJCQl9Cj4gICAKPiAgIAkJCWV1X2NudCA9IDIgKiBo d2VpZ2h0MzIoZXVfcmVnWzIqcyArIHNzLzJdICYKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RldmljZV9pbmZvLmMKPiBpbmRleCA3MjNiMWZkZTVmYzQuLjA0ZGRlNGYyMDRjMyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZXZpY2VfaW5mby5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYwo+IEBAIC05Myw5ICs5Myw5 IEBAIHN0YXRpYyB2b2lkIHNzZXVfZHVtcChjb25zdCBzdHJ1Y3Qgc3NldV9kZXZfaW5mbyAqc3Nl dSwgc3RydWN0IGRybV9wcmludGVyICpwKQo+ICAgCQkgICBod2VpZ2h0OChzc2V1LT5zbGljZV9t YXNrKSwgc3NldS0+c2xpY2VfbWFzayk7Cj4gICAJZHJtX3ByaW50ZihwLCAic3Vic2xpY2UgdG90 YWw6ICV1XG4iLCBpbnRlbF9zc2V1X3N1YnNsaWNlX3RvdGFsKHNzZXUpKTsKPiAgIAlmb3IgKHMg PSAwOyBzIDwgc3NldS0+bWF4X3NsaWNlczsgcysrKSB7Cj4gLQkJZHJtX3ByaW50ZihwLCAic2xp Y2UlZDogJXUgc3Vic2xpY2VzLCBtYXNrPSUwNHhcbiIsCj4gKwkJZHJtX3ByaW50ZihwLCAic2xp Y2UlZDogJXUgc3Vic2xpY2VzLCBtYXNrPSUwOHhcbiIsCj4gICAJCQkgICBzLCBpbnRlbF9zc2V1 X3N1YnNsaWNlc19wZXJfc2xpY2Uoc3NldSwgcyksCj4gLQkJCSAgIHNzZXUtPnN1YnNsaWNlX21h c2tbc10pOwo+ICsJCQkgICBpbnRlbF9zc2V1X2dldF9zdWJzbGljZXMoc3NldSwgcykpOwo+ICAg CX0KPiAgIAlkcm1fcHJpbnRmKHAsICJFVSB0b3RhbDogJXVcbiIsIHNzZXUtPmV1X3RvdGFsKTsK PiAgIAlkcm1fcHJpbnRmKHAsICJFVSBwZXIgc3Vic2xpY2U6ICV1XG4iLCBzc2V1LT5ldV9wZXJf c3Vic2xpY2UpOwo+IEBAIC0xNTksOSArMTU5LDkgQEAgdm9pZCBpbnRlbF9kZXZpY2VfaW5mb19k dW1wX3RvcG9sb2d5KGNvbnN0IHN0cnVjdCBzc2V1X2Rldl9pbmZvICpzc2V1LAo+ICAgCX0KPiAg IAo+ICAgCWZvciAocyA9IDA7IHMgPCBzc2V1LT5tYXhfc2xpY2VzOyBzKyspIHsKPiAtCQlkcm1f cHJpbnRmKHAsICJzbGljZSVkOiAldSBzdWJzbGljZShzKSAoMHglaGh4KTpcbiIsCj4gKwkJZHJt X3ByaW50ZihwLCAic2xpY2UlZDogJXUgc3Vic2xpY2UocykgKDB4JTA4eCk6XG4iLAo+ICAgCQkJ ICAgcywgaW50ZWxfc3NldV9zdWJzbGljZXNfcGVyX3NsaWNlKHNzZXUsIHMpLAo+IC0JCQkgICBz c2V1LT5zdWJzbGljZV9tYXNrW3NdKTsKPiArCQkJICAgaW50ZWxfc3NldV9nZXRfc3Vic2xpY2Vz KHNzZXUsIHMpKTsKPiAgIAo+ICAgCQlmb3IgKHNzID0gMDsgc3MgPCBzc2V1LT5tYXhfc3Vic2xp Y2VzOyBzcysrKSB7Cj4gICAJCQl1MTYgZW5hYmxlZF9ldXMgPSBzc2V1X2dldF9ldXMoc3NldSwg cywgc3MpOwo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=