From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v4 06/23] xen/arm: don't add duplicate boot modules, introduce domU flag Date: Tue, 9 Oct 2018 14:35:52 +0100 Message-ID: <92df9337-8da5-5c79-5bc5-8763b6beb719@arm.com> References: <1538765251-25256-6-git-send-email-sstabellini@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1538765251-25256-6-git-send-email-sstabellini@kernel.org> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Stefano Stabellini Cc: Stefano Stabellini , andrii_anisov@epam.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SGkgU3RlZmFubywKCk9uIDA1LzEwLzIwMTggMTk6NDcsIFN0ZWZhbm8gU3RhYmVsbGluaSB3cm90 ZToKPiBEb24ndCBhZGQgZHVwbGljYXRlIGJvb3QgbW9kdWxlcyAoc2FtZSBraW5kIGFuZCBzYW1l IHN0YXJ0IGFkZHJlc3MpLAo+IHRoZXkgYXJlIGZyZWVkIGxhdGVyLCB3ZSBkb24ndCB3YW50IHRv IGludHJvZHVjZSBkb3VibGUtZnJlZSBlcnJvcnMuCj4gCj4gSW50cm9kdWNlIGEgZG9tVSBmbGFn IGluIHN0cnVjdCBib290bW9kdWxlIGFuZCBzdHJ1Y3QgYm9vdGNtZGxpbmUuIFNldAo+IGl0IGZv ciBrZXJuZWxzIGFuZCByYW1kaXNrcyBvZiAieGVuLGRvbWFpbiIgbm9kZXMgdG8gYXZvaWQgZ2V0 dGluZwo+IGNvbmZ1c2VkIGluIGtlcm5lbF9wcm9iZSwgd2hlcmUgd2UgdHJ5IHRvIGd1ZXNzIHdo aWNoIGlzIHRoZSBkb20wIGtlcm5lbAo+IGFuZCBpbml0cmQgdG8gYmUgY29tcGF0aWJsZSB3aXRo IG9sZGVyIHZlcnNpb25zIG9mIHRoZSBtdWx0aWJvb3Qgc3BlYy4KClRoaXMgY29tbWVudHMgbmVl ZCBhdCBsZWFzdCB0byBiZSByZXBsaWNhdGVkIGluIHRoZSBzdHJ1Y3R1cmUuIFNvIHdlIApoYXZl IGFuIGlkZWEgaG93IHRvIHVzZSBpdC4KCkxhc3RseSwgdGVjaG5pY2FsbHkgaXQgaXMgbm90IG9s ZGVyIHZlcnNpb25zIG9mIHRoZSBzcGVjaWZpY2F0aW9uLiBZb3VyIApleHRlbnNpb24gZG9lcyBu b3QgZGVhbCB3aXRoIERvbTAuCgo+IAo+IGJvb3RfbW9kdWxlX2ZpbmRfYnlfa2luZCBhbmQgYm9v dF9jbWRsaW5lX2ZpbmRfYnlfa2luZCBhdXRvbWF0aWNhbGx5Cj4gY2hlY2sgZm9yICFkb21VIGVu dHJpZXMgKHRoZXkgYXJlIG9ubHkgdXNlZCBmb3Igbm9uLWRvbVUgbW9kdWxlcykuCj4gCj4gU2ln bmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vc0B4aWxpbnguY29tPgo+IAo+ IC0tLQo+IENoYW5nZXMgaW4gdjQ6Cj4gLSB1c2UgdW5zaWduZWQgaW50Cj4gLSBiZXR0ZXIgY29t bWl0IG1lc3NhZ2UKPiAtIGludHJvZHVjZSBkb21VIGZsYWcgYW5kIHVzYWdlCj4gCj4gQ2hhbmdl cyBpbiB2MjoKPiAtIG5ldyBwYXRjaAo+IC0tLQo+ICAgeGVuL2FyY2gvYXJtL2Jvb3RmZHQuYyAg ICAgIHwgMTQgKysrKysrKysrLS0tLS0KPiAgIHhlbi9hcmNoL2FybS9zZXR1cC5jICAgICAgICB8 IDIxICsrKysrKysrKysrKysrKysrLS0tLQo+ICAgeGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5o IHwgIDQgKysrLQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyOSBpbnNlcnRpb25zKCspLCAxMCBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2Jvb3RmZHQuYyBiL3hlbi9h cmNoL2FybS9ib290ZmR0LmMKPiBpbmRleCAyNzMwMzJiLi4zNDlhYTlkIDEwMDY0NAo+IC0tLSBh L3hlbi9hcmNoL2FybS9ib290ZmR0LmMKPiArKysgYi94ZW4vYXJjaC9hcm0vYm9vdGZkdC5jCj4g QEAgLTE2NCw3ICsxNjQsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQgcHJvY2Vzc19tZW1vcnlfbm9k ZShjb25zdCB2b2lkICpmZHQsIGludCBub2RlLAo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBf X2luaXQgYWRkX2Jvb3RfY21kbGluZShjb25zdCB2b2lkICpmZHQsIGludCBub2RlLAo+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBjaGFyICpuYW1lLCBib290bW9k dWxlX2tpbmQga2luZCkKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29u c3QgY2hhciAqbmFtZSwgYm9vdG1vZHVsZV9raW5kIGtpbmQsCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGJvb2wgZG9tVSkKPiAgIHsKPiAgICAgICBzdHJ1Y3QgYm9vdGNt ZGxpbmVzICpjbWRzID0gJmJvb3RpbmZvLmNtZGxpbmVzOwo+ICAgICAgIHN0cnVjdCBib290Y21k bGluZSAqY21kOwo+IEBAIC0xODQsNiArMTg1LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IGFkZF9i b290X2NtZGxpbmUoY29uc3Qgdm9pZCAqZmR0LCBpbnQgbm9kZSwKPiAgIAo+ICAgICAgIGNtZCA9 ICZjbWRzLT5jbWRsaW5lW2NtZHMtPm5yX21vZHMrK107Cj4gICAgICAgY21kLT5raW5kID0ga2lu ZDsKPiArICAgIGNtZC0+ZG9tVSA9IGRvbVU7Cj4gICAKPiAgICAgICBBU1NFUlQoc3RybGVuKG5h bWUpIDw9IERUX01BWF9OQU1FKTsKPiAgICAgICBzYWZlX3N0cmNweShjbWQtPmR0X25hbWUsIG5h bWUpOwo+IEBAIC0yMDYsNiArMjA4LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByb2Nlc3NfbXVs dGlib290X25vZGUoY29uc3Qgdm9pZCAqZmR0LCBpbnQgbm9kZSwKPiAgICAgICBpbnQgbGVuID0g c2l6ZW9mKCIvY2hvc2VuIik7Cj4gICAgICAgY2hhciBwYXRoWzhdOyAvKiBzaXplb2YgIi9jaG9z ZW4iICovCj4gICAgICAgaW50IHBhcmVudF9ub2RlOwo+ICsgICAgYm9vbCBkb21VOwo+ICAgCj4g ICAgICAgcGFyZW50X25vZGUgPSBmZHRfcGFyZW50X29mZnNldChmZHQsIG5vZGUpOwo+ICAgICAg IEFTU0VSVChwYXJlbnRfbm9kZSA+PSAwKTsKPiBAQCAtMjYzLDggKzI2Niw5IEBAIHN0YXRpYyB2 b2lkIF9faW5pdCBwcm9jZXNzX211bHRpYm9vdF9ub2RlKGNvbnN0IHZvaWQgKmZkdCwgaW50IG5v ZGUsCj4gICAgICAgICAgICAgICBraW5kID0gQk9PVE1PRF9YU007Cj4gICAgICAgfQo+ICAgCj4g LSAgICBhZGRfYm9vdF9tb2R1bGUoa2luZCwgc3RhcnQsIHNpemUpOwo+IC0gICAgYWRkX2Jvb3Rf Y21kbGluZShmZHQsIG5vZGUsIGZkdF9nZXRfbmFtZShmZHQsIHBhcmVudF9ub2RlLCAmbGVuKSwg a2luZCk7Cj4gKyAgICBkb21VID0gZmR0X25vZGVfY2hlY2tfY29tcGF0aWJsZShmZHQsIHBhcmVu dF9ub2RlLCAieGVuLGRvbWFpbiIpID09IDA7Cj4gKyAgICBhZGRfYm9vdF9tb2R1bGUoa2luZCwg c3RhcnQsIHNpemUsIGRvbVUpOwo+ICsgICAgYWRkX2Jvb3RfY21kbGluZShmZHQsIG5vZGUsIGZk dF9nZXRfbmFtZShmZHQsIHBhcmVudF9ub2RlLCAmbGVuKSwga2luZCwgZG9tVSk7Cj4gICB9Cj4g ICAKPiAgIHN0YXRpYyB2b2lkIF9faW5pdCBwcm9jZXNzX2Nob3Nlbl9ub2RlKGNvbnN0IHZvaWQg KmZkdCwgaW50IG5vZGUsCj4gQEAgLTMxMCw3ICszMTQsNyBAQCBzdGF0aWMgdm9pZCBfX2luaXQg cHJvY2Vzc19jaG9zZW5fbm9kZShjb25zdCB2b2lkICpmZHQsIGludCBub2RlLAo+ICAgCj4gICAg ICAgcHJpbnRrKCJJbml0cmQgJSJQUklwYWRkciItJSJQUklwYWRkciJcbiIsIHN0YXJ0LCBlbmQp Owo+ICAgCj4gLSAgICBhZGRfYm9vdF9tb2R1bGUoQk9PVE1PRF9SQU1ESVNLLCBzdGFydCwgZW5k LXN0YXJ0KTsKPiArICAgIGFkZF9ib290X21vZHVsZShCT09UTU9EX1JBTURJU0ssIHN0YXJ0LCBl bmQtc3RhcnQsIGZhbHNlKTsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIGludCBfX2luaXQgZWFybHlf c2Nhbl9ub2RlKGNvbnN0IHZvaWQgKmZkdCwKPiBAQCAtMzgxLDcgKzM4NSw3IEBAIHNpemVfdCBf X2luaXQgYm9vdF9mZHRfaW5mbyhjb25zdCB2b2lkICpmZHQsIHBhZGRyX3QgcGFkZHIpCj4gICAg ICAgaWYgKCByZXQgPCAwICkKPiAgICAgICAgICAgcGFuaWMoIk5vIHZhbGlkIGRldmljZSB0cmVl XG4iKTsKPiAgIAo+IC0gICAgYWRkX2Jvb3RfbW9kdWxlKEJPT1RNT0RfRkRULCBwYWRkciwgZmR0 X3RvdGFsc2l6ZShmZHQpKTsKPiArICAgIGFkZF9ib290X21vZHVsZShCT09UTU9EX0ZEVCwgcGFk ZHIsIGZkdF90b3RhbHNpemUoZmR0KSwgZmFsc2UpOwo+ICAgCj4gICAgICAgZGV2aWNlX3RyZWVf Zm9yX2VhY2hfbm9kZSgodm9pZCAqKWZkdCwgZWFybHlfc2Nhbl9ub2RlLCBOVUxMKTsKPiAgICAg ICBlYXJseV9wcmludF9pbmZvKCk7Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zZXR1cC5j IGIveGVuL2FyY2gvYXJtL3NldHVwLmMKPiBpbmRleCBiYzdkZDk3Li5kYmFiMjMyIDEwMDY0NAo+ IC0tLSBhL3hlbi9hcmNoL2FybS9zZXR1cC5jCj4gKysrIGIveGVuL2FyY2gvYXJtL3NldHVwLmMK PiBAQCAtMjAxLDEwICsyMDEsMTIgQEAgdm9pZCBfX2luaXQgZHRfdW5yZXNlcnZlZF9yZWdpb25z KHBhZGRyX3QgcywgcGFkZHJfdCBlLAo+ICAgfQo+ICAgCj4gICBzdHJ1Y3QgYm9vdG1vZHVsZSBf X2luaXQgKmFkZF9ib290X21vZHVsZShib290bW9kdWxlX2tpbmQga2luZCwKPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFkZHJfdCBzdGFydCwgcGFkZHJfdCBz aXplKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90 IHN0YXJ0LCBwYWRkcl90IHNpemUsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGJvb2wgZG9tVSkKPiAgIHsKPiAgICAgICBzdHJ1Y3QgYm9vdG1vZHVsZXMgKm1v ZHMgPSAmYm9vdGluZm8ubW9kdWxlczsKPiAgICAgICBzdHJ1Y3QgYm9vdG1vZHVsZSAqbW9kOwpU aGlzIGF0IGxlYXN0IG5lZWQgdG8gYmUgcmVwbGljYQo+ICsgICAgdW5zaWduZWQgaW50IGk7Cj4g ICAKPiAgICAgICBpZiAoIG1vZHMtPm5yX21vZHMgPT0gTUFYX01PRFVMRVMgKQo+ICAgICAgIHsK PiBAQCAtMjEyLDExICsyMTQsMjIgQEAgc3RydWN0IGJvb3Rtb2R1bGUgX19pbml0ICphZGRfYm9v dF9tb2R1bGUoYm9vdG1vZHVsZV9raW5kIGtpbmQsCj4gICAgICAgICAgICAgICAgICBib290X21v ZHVsZV9raW5kX2FzX3N0cmluZyhraW5kKSwgc3RhcnQsIHN0YXJ0ICsgc2l6ZSk7Cj4gICAgICAg ICAgIHJldHVybiBOVUxMOwo+ICAgICAgIH0KPiArICAgIGZvciAoIGkgPSAwIDsgaSA8IG1vZHMt Pm5yX21vZHMgOyBpKysgKQo+ICsgICAgewo+ICsgICAgICAgIG1vZCA9ICZtb2RzLT5tb2R1bGVb aV07Cj4gKyAgICAgICAgaWYgKCBtb2QtPmtpbmQgPT0ga2luZCAmJiBtb2QtPnN0YXJ0ID09IHN0 YXJ0ICkKPiArICAgICAgICB7Cj4gKyAgICAgICAgICAgIGlmICggIWRvbVUgKQo+ICsgICAgICAg ICAgICAgICAgbW9kLT5kb21VID0gZmFsc2U7Cj4gKyAgICAgICAgICAgIHJldHVybiBtb2Q7Cj4g KyAgICAgICAgfQo+ICsgICAgfQo+ICAgCj4gICAgICAgbW9kID0gJm1vZHMtPm1vZHVsZVttb2Rz LT5ucl9tb2RzKytdOwo+ICAgICAgIG1vZC0+a2luZCA9IGtpbmQ7Cj4gICAgICAgbW9kLT5zdGFy dCA9IHN0YXJ0Owo+ICAgICAgIG1vZC0+c2l6ZSA9IHNpemU7Cj4gKyAgICBtb2QtPmRvbVUgPSBk b21VOwo+ICAgCj4gICAgICAgcmV0dXJuIG1vZDsKPiAgIH0KPiBAQCAtMjI5LDcgKzI0Miw3IEBA IHN0cnVjdCBib290bW9kdWxlICogX19pbml0IGJvb3RfbW9kdWxlX2ZpbmRfYnlfa2luZChib290 bW9kdWxlX2tpbmQga2luZCkKPiAgICAgICBmb3IgKGkgPSAwIDsgaSA8IG1vZHMtPm5yX21vZHMg OyBpKysgKQo+ICAgICAgIHsKPiAgICAgICAgICAgbW9kID0gJm1vZHMtPm1vZHVsZVtpXTsKPiAt ICAgICAgICBpZiAoIG1vZC0+a2luZCA9PSBraW5kICkKPiArICAgICAgICBpZiAoIG1vZC0+a2lu ZCA9PSBraW5kICYmICFtb2QtPmRvbVUgKQoKIEZyb20gdGhlIG5hbWUgb2YgdGhlIGZ1bmN0aW9u IGlzIGl0IHVuY2xlYXIgd2h5IHdlIHdvdWxkIG9ubHkgcmV0dXJuIAptb2R1bGUgd2l0aCAhbW9k LT5kb21VLiBTbyB0aGlzIG5lZWRzIHNvbWUgY2xhcmlmaWNhdGlvbnMgaW4gdGhlIGNvZGUuCgo+ ICAgICAgICAgICAgICAgcmV0dXJuIG1vZDsKPiAgICAgICB9Cj4gICAgICAgcmV0dXJuIE5VTEw7 Cj4gQEAgLTI0NCw3ICsyNTcsNyBAQCBzdHJ1Y3QgYm9vdGNtZGxpbmUgKiBfX2luaXQgYm9vdF9j bWRsaW5lX2ZpbmRfYnlfa2luZChib290bW9kdWxlX2tpbmQga2luZCkKPiAgICAgICBmb3IgKCBp ID0gMCA7IGkgPCBjbWRzLT5ucl9tb2RzIDsgaSsrICkKPiAgICAgICB7Cj4gICAgICAgICAgIGNt ZCA9ICZjbWRzLT5jbWRsaW5lW2ldOwo+IC0gICAgICAgIGlmICggY21kLT5raW5kID09IGtpbmQg KQo+ICsgICAgICAgIGlmICggY21kLT5raW5kID09IGtpbmQgJiYgIWNtZC0+ZG9tVSApCgpEaXR0 byBoZXJlLgoKPiAgICAgICAgICAgICAgIHJldHVybiBjbWQ7Cj4gICAgICAgfQo+ICAgICAgIHJl dHVybiBOVUxMOwo+IEBAIC03MzgsNyArNzUxLDcgQEAgdm9pZCBfX2luaXQgc3RhcnRfeGVuKHVu c2lnbmVkIGxvbmcgYm9vdF9waHlzX29mZnNldCwKPiAgICAgICAvKiBSZWdpc3RlciBYZW4ncyBs b2FkIGFkZHJlc3MgYXMgYSBib290IG1vZHVsZS4gKi8KPiAgICAgICB4ZW5fYm9vdG1vZHVsZSA9 IGFkZF9ib290X21vZHVsZShCT09UTU9EX1hFTiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKHBhZGRyX3QpKHVpbnRwdHJfdCkoX3N0YXJ0ICsgYm9vdF9waHlzX29mZnNldCksCj4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHBhZGRyX3QpKHVpbnRwdHJfdCkoX2VuZCAt IF9zdGFydCArIDEpKTsKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocGFkZHJfdCko dWludHB0cl90KShfZW5kIC0gX3N0YXJ0ICsgMSksIGZhbHNlKTsKPiAgICAgICBCVUdfT04oIXhl bl9ib290bW9kdWxlKTsKPiAgIAo+ICAgICAgIHhlbl9wYWRkciA9IGdldF94ZW5fcGFkZHIoKTsK PiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLWFybS9zZXR1cC5oIGIveGVuL2luY2x1ZGUv YXNtLWFybS9zZXR1cC5oCj4gaW5kZXggYzJlZDVjYy4uNzExYjRhMiAxMDA2NDQKPiAtLS0gYS94 ZW4vaW5jbHVkZS9hc20tYXJtL3NldHVwLmgKPiArKysgYi94ZW4vaW5jbHVkZS9hc20tYXJtL3Nl dHVwLmgKPiBAQCAtMzMsNiArMzMsNyBAQCBzdHJ1Y3QgbWVtaW5mbyB7Cj4gICAjZGVmaW5lIEJP T1RNT0RfTUFYX0NNRExJTkUgMTAyNAo+ICAgc3RydWN0IGJvb3Rtb2R1bGUgewo+ICAgICAgIGJv b3Rtb2R1bGVfa2luZCBraW5kOwo+ICsgICAgYm9vbCBkb21VOwoKVGhpcyBuZWVkcyBzb21lIGRv Y3VtZW50YXRpb24gaW4gdGhlIGNvZGUuCgpDaGVlcnMsCgotLSAKSnVsaWVuIEdyYWxsCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs