From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew F. Davis Date: Wed, 13 Feb 2019 15:16:06 -0600 Subject: [U-Boot] [PATCH 1/7] arm: K3: Avoid use of MCU_PSRAM0 before SYSFW is loaded In-Reply-To: <20190213202701.GT21737@bill-the-cat> References: <20190213183712.7087-1-afd@ti.com> <20190213183712.7087-2-afd@ti.com> <20190213202701.GT21737@bill-the-cat> Message-ID: <92ee4288-978d-1d84-0d01-6a06be5dcb88@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 2/13/19 2:27 PM, Tom Rini wrote: > On Wed, Feb 13, 2019 at 12:37:06PM -0600, Andrew F. Davis wrote: >> On HS devices the 512b region of reset isolated memory called >> MCU_PSRAM0 is firewalled by default. Until SYSFW is loaded we >> cannot use this memory. It is only used to store a single value >> left at the end of SRAM by ROM that will be needed later. Save >> that value to a global variable stored in the .data section. >> This section is used as .bss will be cleared between saving >> this value and using it. >> >> Signed-off-by: Andrew F. Davis >> --- >> arch/arm/mach-k3/am6_init.c | 8 +++----- >> arch/arm/mach-k3/include/mach/am6_hardware.h | 3 --- >> 2 files changed, 3 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm/mach-k3/am6_init.c b/arch/arm/mach-k3/am6_init.c >> index a5553190b4..462538e45d 100644 >> --- a/arch/arm/mach-k3/am6_init.c >> +++ b/arch/arm/mach-k3/am6_init.c >> @@ -49,11 +49,11 @@ static void ctrl_mmr_unlock(void) >> mmr_unlock(CTRL_MMR0_BASE, 7); >> } >> >> +u32 bootindex __attribute__((section(".data"))); >> + > > We need a comment above this one so it's clear down the line to others > why we're doing something odd like this, thanks! > No problem, will add.