From: Jens Axboe <axboe@kernel.dk>
To: Jackie Liu <liuyun01@kylinos.cn>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH] io_uring: set -EINTR directly when a signal wakes up in io_cqring_wait
Date: Fri, 1 Nov 2019 08:37:02 -0600 [thread overview]
Message-ID: <93057b1d-f7af-c8aa-3c4b-e63455a6f163@kernel.dk> (raw)
In-Reply-To: <1572319002-9943-1-git-send-email-liuyun01@kylinos.cn>
On 10/28/19 9:16 PM, Jackie Liu wrote:
> We didn't use -ERESTARTSYS to tell the application layer to restart the
> system call, but instead return -EINTR. we can set -EINTR directly when
> wakeup by the signal, which can help us save an assignment operation and
> comparison operation.
Looks good - patch looks like it's against 5.3 though, I've queued it up
for 5.4 with a bit of mangling.
--
Jens Axboe
prev parent reply other threads:[~2019-11-01 14:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 3:16 [PATCH] io_uring: set -EINTR directly when a signal wakes up in io_cqring_wait Jackie Liu
2019-11-01 2:14 ` Bob Liu
2019-11-01 14:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93057b1d-f7af-c8aa-3c4b-e63455a6f163@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=liuyun01@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.