From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DC3C4332F for ; Fri, 19 Nov 2021 10:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47C2661B72 for ; Fri, 19 Nov 2021 10:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234404AbhKSK3f (ORCPT ); Fri, 19 Nov 2021 05:29:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233895AbhKSK3e (ORCPT ); Fri, 19 Nov 2021 05:29:34 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03BCC06173E for ; Fri, 19 Nov 2021 02:26:32 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id v19so7791221plo.7 for ; Fri, 19 Nov 2021 02:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=6w55kTpau74YSZLJIa8X8+WMQwazhW/u3R2GbUt9wtk=; b=VvH68lZnDU9FciDyDeffiNWHhL5h/QwYLbMusRknyrnqCr9SHs4HTyPeGHcbm+qp2S StOmKlRXQnMcfeOrPfu3fsjVCikGtWUI30ip/aUIycMqvQjY/tzr1CEdvd4VwkCwSsIb 2ZV8pi2W7Y4kZkCrgMIYxLz94J2iAljOo9kqsr2JSysgz46H8USbGFoDXlGKteCPtm0l nfVHIQCqlY9T9tTC9A3GkkG4Y3BwkP+jGhHsSLIwBDXp/8TYjQQYeSGU2d9de+5ELk0J 2kgpMU0ayWsmuzkbY+UtZn1N4hAbwZbGgFYDOCtdadVHmHN3zDv8/lqBbjA7vqm+DJ6n Om6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=6w55kTpau74YSZLJIa8X8+WMQwazhW/u3R2GbUt9wtk=; b=tDHi+5cBpcX/HzX84Ntq883TpM2vA+QfL6XcEGlE1cZO5pJMHSpYfL3At5pHZ5Y7gd uTrfUV0MJSvSd+MoBaZzs2n0KBQiect8YM6wg/usJcjTSxRLVnoR1neCN5TvdStT2JZk B5MuzkmrC6BjZQ0pUtRZXTX0FRYPUMjfnXiAUFVo/jzBvOQBGxam9zcSYrkjWm2FG+p3 6/puK16vyJP3N0RntFp9ustqRNczsV02pOWyaULVVH4pA9fvjlDXgkzeQriEezisVJBf m/m/H6rLQ3ShOItaGOWrekLQ6nBhucWWiv0GE9b5ictdDF9SIeKyu6cam+Ct2QDlG31Q /N6Q== X-Gm-Message-State: AOAM533I/4VjXHShJfHL/gLsyPWgFZSakEjboUzrq9ceH0dS7yoJAmr/ eXYOG9WQiyOFJkggAHNe03xL+Q== X-Google-Smtp-Source: ABdhPJzFQFeewwDICoO/AaPGt9kJGqBG9VuY4xA11XD/c9q4ffCxHcmqbf0rN6lnVUOrDj0HI0peHQ== X-Received: by 2002:a17:902:904b:b0:143:73ff:eb7d with SMTP id w11-20020a170902904b00b0014373ffeb7dmr73509127plz.85.1637317592235; Fri, 19 Nov 2021 02:26:32 -0800 (PST) Received: from [10.254.160.232] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id d19sm2555809pfv.199.2021.11.19.02.26.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 02:26:31 -0800 (PST) Message-ID: <9307b13e-e87e-1bc1-9e75-b4155d4157ca@bytedance.com> Date: Fri, 19 Nov 2021 18:26:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH] x86: Pin task-stack in __get_wchan() To: Peter Zijlstra Cc: Josh Poimboeuf , Linus Torvalds , Holger Hoffst??tte , Kees Cook , Thomas Gleixner , Justin Forbes , Greg Kroah-Hartman , Linux Kernel Mailing List , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, lkft-triage@lists.linaro.org, Pavel Machek , Jon Hunter , Florian Fainelli , stable References: <55c7b316-e03d-9e91-d74c-fea63c469b3b@applied-asynchrony.com> <20211118080627.GH174703@worktop.programming.kicks-ass.net> <20211118081852.GM174730@worktop.programming.kicks-ass.net> <20211119020427.2y5esq2czquwmvwc@treble> <759cd319-990f-af23-2f1c-aba55d0768b8@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/21 6:22 PM, Peter Zijlstra wrote: > On Fri, Nov 19, 2021 at 06:02:50PM +0800, Qi Zheng wrote: > >> This implementation is very similar to stack_trace_save_tsk(), maybe we >> can just move stack_trace_save_tsk() out of CONFIG_STACKTRACE and reuse >> it. > > No, we want to move away from the stack_trace_*() API because it has > very unclear semantics and various arch implementations differ in > details. > > There's a patch that untangles arch_stack_walk*() from CONFIG_STACKTRACE > and we can eventually use that. > Got it. -- Thanks, Qi