From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Durrant <Paul.Durrant@citrix.com>
Subject: Re: [PATCH 1/2] x86/SVM-IOMMU: Don't opencode memcpy()
 in queue_iommu_command()
Date: Mon, 24 Sep 2018 11:59:01 +0000
Message-ID: <930ae0cb767d46898ea4a9acdb95c2be@AMSPEX02CL03.citrite.net>
References: <1537786530-4625-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <xen-devel-bounces@lists.xenproject.org>
In-Reply-To: <1537786530-4625-1-git-send-email-andrew.cooper3@citrix.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.xenproject.org/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xenproject.org>
List-Help: <mailto:xen-devel-request@lists.xenproject.org?subject=help>
List-Subscribe: <https://lists.xenproject.org/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xenproject.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xenproject.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xenproject.org>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>, Andrew Cooper <Andrew.Cooper3@citrix.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Brian Woods <brian.woods@amd.com>, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBBbmRyZXcgQ29vcGVyIFttYWls
dG86YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbV0NCj4gU2VudDogMjQgU2VwdGVtYmVyIDIwMTgg
MTE6NTUNCj4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+DQo+IENjOiBB
bmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPjsgSmFuIEJldWxpY2gNCj4g
PEpCZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdSA8d2VpLmxpdTJAY2l0cml4LmNvbT47IFJvZ2Vy
IFBhdSBNb25uZQ0KPiA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyBQYXVsIER1cnJhbnQgPFBhdWwu
RHVycmFudEBjaXRyaXguY29tPjsgU3VyYXZlZQ0KPiBTdXRoaWt1bHBhbml0IDxzdXJhdmVlLnN1
dGhpa3VscGFuaXRAYW1kLmNvbT47IEJyaWFuIFdvb2RzDQo+IDxicmlhbi53b29kc0BhbWQuY29t
Pg0KPiBTdWJqZWN0OiBbUEFUQ0ggMS8yXSB4ODYvU1ZNLUlPTU1VOiBEb24ndCBvcGVuY29kZSBt
ZW1jcHkoKSBpbg0KPiBxdWV1ZV9pb21tdV9jb21tYW5kKCkNCj4gDQo+IEluIHByYWN0aWNlLCB0
aGlzIGFsbG93cyB0aGUgY29tcGlsZXIgdG8gcmVwbGFjZSB0aGUgbG9vcCB3aXRoIGEgcGFpciBv
Zg0KPiBtb3ZzLg0KPiANCj4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuDQoNCldlbGwgdGhlcmUgaXMg
YSBwb3RlbnRpYWwgZnVuY3Rpb25hbCBjaGFuZ2UuLi4NCg0KPiANCj4gU2lnbmVkLW9mZi1ieTog
QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gLS0tDQo+IENDOiBK
YW4gQmV1bGljaCA8SkJldWxpY2hAc3VzZS5jb20+DQo+IENDOiBXZWkgTGl1IDx3ZWkubGl1MkBj
aXRyaXguY29tPg0KPiBDQzogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+
DQo+IENDOiBQYXVsIER1cnJhbnQgPHBhdWwuZHVycmFudEBjaXRyaXguY29tPg0KPiBDQzogU3Vy
YXZlZSBTdXRoaWt1bHBhbml0IDxzdXJhdmVlLnN1dGhpa3VscGFuaXRAYW1kLmNvbT4NCj4gQ0M6
IEJyaWFuIFdvb2RzIDxicmlhbi53b29kc0BhbWQuY29tPg0KPiAtLS0NCj4gIHhlbi9kcml2ZXJz
L3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9jbWQuYyAgICAgIHwgMTIgKysrKy0tLS0tLS0tDQo+ICB4
ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0vYW1kLWlvbW11LWRlZnMuaCB8ICAxIC0NCj4gIDIg
ZmlsZXMgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlm
ZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9jbWQuYw0KPiBiL3hl
bi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FtZC9pb21tdV9jbWQuYw0KPiBpbmRleCAwODI0N2ZhLi5j
NmMwYjRmIDEwMDY0NA0KPiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hbWQvaW9tbXVf
Y21kLmMNCj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYW1kL2lvbW11X2NtZC5jDQo+
IEBAIC0yNCw4ICsyNCw3IEBADQo+IA0KPiAgc3RhdGljIGludCBxdWV1ZV9pb21tdV9jb21tYW5k
KHN0cnVjdCBhbWRfaW9tbXUgKmlvbW11LCB1MzIgY21kW10pDQo+ICB7DQo+IC0gICAgdTMyIHRh
aWwsIGhlYWQsICpjbWRfYnVmZmVyOw0KPiAtICAgIGludCBpOw0KPiArICAgIHVpbnQzMl90IHRh
aWwsIGhlYWQ7DQo+IA0KPiAgICAgIHRhaWwgPSBpb21tdS0+Y21kX2J1ZmZlci50YWlsOw0KPiAg
ICAgIGlmICggKyt0YWlsID09IGlvbW11LT5jbWRfYnVmZmVyLmVudHJpZXMgKQ0KPiBAQCAtMzUs
MTIgKzM0LDkgQEAgc3RhdGljIGludCBxdWV1ZV9pb21tdV9jb21tYW5kKHN0cnVjdCBhbWRfaW9t
bXUgKmlvbW11LA0KPiB1MzIgY21kW10pDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgIElPTU1VX0NNRF9CVUZGRVJfSEVBRF9PRkZTRVQpKTsNCj4gICAgICBpZiAoIGhl
YWQgIT0gdGFpbCApDQo+ICAgICAgew0KPiAtICAgICAgICBjbWRfYnVmZmVyID0gKHUzMiAqKShp
b21tdS0+Y21kX2J1ZmZlci5idWZmZXIgKw0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAoaW9tbXUtPmNtZF9idWZmZXIudGFpbCAqDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIElPTU1VX0NNRF9CVUZGRVJfRU5UUllfU0laRSkpOw0KPiAtDQo+IC0gICAgICAgIGZvciAo
IGkgPSAwOyBpIDwgSU9NTVVfQ01EX0JVRkZFUl9VMzJfUEVSX0VOVFJZOyBpKysgKQ0KPiAtICAg
ICAgICAgICAgY21kX2J1ZmZlcltpXSA9IGNtZFtpXTsNCj4gKyAgICAgICAgbWVtY3B5KGlvbW11
LT5jbWRfYnVmZmVyLmJ1ZmZlciArDQo+ICsgICAgICAgICAgICAgICAoaW9tbXUtPmNtZF9idWZm
ZXIudGFpbCAqIElPTU1VX0NNRF9CVUZGRVJfRU5UUllfU0laRSksDQo+ICsgICAgICAgICAgICAg
ICBjbWQsIElPTU1VX0NNRF9CVUZGRVJfRU5UUllfU0laRSk7DQoNCi4uLnNpbmNlIHRoZSBidWls
dC1pbiBtZW1jcHkgbWF5IG5vdCBndWFyYW50ZWUgdG8gdGhlIGNvcHkgaW4gNCBieXRlIGNodW5r
cyBpbiBhc2NlbmRpbmcgb3JkZXIuIEFzIGxvbmcgYXMgdGhhdCBjaGFuZ2UgcG9zZXMgbm8gZGFu
Z2VyIChhbmQgc2VlaW5nIGFzIHRoZSBjb2RlIGNvbnRhaW5zIG5vIGJhcnJlci1pbmcgSSdkIGFz
c3VtZSB0aGF0IHRvIGJlIHRoZSBjYXNlKSB0aGVuIHRoaXMgY2hhbmdlIGxvb2tzIGZpbmUgdG8g
bWUgKHdpdGggdGhlICdubyBmdW5jdGlvbmFsIGNoYW5nZScgY29tbWVudCByZW1vdmVkKS4NCg0K
UmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFudCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+DQoNCj4g
DQo+ICAgICAgICAgIGlvbW11LT5jbWRfYnVmZmVyLnRhaWwgPSB0YWlsOw0KPiAgICAgICAgICBy
ZXR1cm4gMTsNCj4gZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvaHZtL3N2bS9hbWQt
aW9tbXUtZGVmcy5oDQo+IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1k
ZWZzLmgNCj4gaW5kZXggYzQ3OWYwYi4uMWYxOWNkMyAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1
ZGUvYXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1kZWZzLmgNCj4gKysrIGIveGVuL2luY2x1ZGUv
YXNtLXg4Ni9odm0vc3ZtL2FtZC1pb21tdS1kZWZzLmgNCj4gQEAgLTE4Nyw3ICsxODcsNiBAQA0K
PiANCj4gICNkZWZpbmUgSU9NTVVfQ01EX0JVRkZFUl9FTlRSWV9TSVpFCQkJMTYNCj4gICNkZWZp
bmUgSU9NTVVfQ01EX0JVRkZFUl9QT1dFUl9PRjJfRU5UUklFU19QRVJfUEFHRQk4DQo+IC0jZGVm
aW5lIElPTU1VX0NNRF9CVUZGRVJfVTMyX1BFUl9FTlRSWSAJKElPTU1VX0NNRF9CVUZGRVJfRU5U
UllfU0laRSAvDQo+IDQpDQo+IA0KPiAgI2RlZmluZSBJT01NVV9DTURfT1BDT0RFX01BU0sJCQkw
eEYwMDAwMDAwDQo+ICAjZGVmaW5lIElPTU1VX0NNRF9PUENPREVfU0hJRlQJCQkyOA0KPiAtLQ0K
PiAyLjEuNA0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpo
dHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs