From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lb2-smtp-cloud7.xs4all.net (lb2-smtp-cloud7.xs4all.net [194.109.24.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C445970 for ; Wed, 7 Apr 2021 14:06:38 +0000 (UTC) Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id U8oAlSJzRMxedU8oDlIhgv; Wed, 07 Apr 2021 16:05:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1617804330; bh=fm44WbDRvg5ne0yHElY/ZyexmCrcHUZfm1JrxKKHYXg=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=aBi0K7CfEbQR3dOy/Dnkf6U3bpGGiR4dImI1ENRMrd+iOMAYetDNcOE91Z8j8c1yC 98QOz9QKMQJ7o0rAL7En+I9RvzA80St63ktEqw9ROlHcY5ZDdFUm4NgFitcZOG+tnu 5Z1t4Zt0gbDXm3gy687VY76pnednaqr7IO51V1TZHSeefFyzr/GQU6gCvCfttw/d+C wCes29Y50tdio3sxOpP7NsPNqIKN/+1kH6v9jJO0GwazL0J90gS5hQdaLIcNoBq9PD SXGIdhXsy2HKIAnGTaG/4IauQ0ILoRX++5JlV010XIz4QudfpmWj9vo0nXdpXYD3yv 0grmeMe/tWusA== Subject: Re: [PATCH] staging: axis-fifo: media/meson: remove redundant dev_err call To: Muhammad Usama Anjum , Greg Kroah-Hartman , Neil Armstrong , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:STAGING SUBSYSTEM" , open list , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "moderated list:ARM/Amlogic Meson SoC support" Cc: linqiheng@huawei.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com References: <20210407101047.GA1491258@LEGION> From: Hans Verkuil Message-ID: <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> Date: Wed, 7 Apr 2021 16:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210407101047.GA1491258@LEGION> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfJuuT3CZKUYbj5nNz8R/l8wm1VJrpjTtQH6J0CmLwm7ghIJ918q0+hbMonNISO7KHY8ltQTOpTNtDRJ8Usjw2cLayCjTim5Lj6hbxFqYwUVV/Qtx3fJy o0P69y7rvrQfzlLdxH8b3CC78srRQDzdHZJ/x7+amPLWayrB6sc/NMDGDF/cHG6rq/ogA/QwcDjLzibQZp+Ly/oyZywn54zrOCrapWyEC5vw5TRHmZP+c90l e6/WiNqO+9zXEPoCZluWJONhoR13VC9A5NrFKRPpOI2J0KxRzbPO4Gn7FH5boVqwzH6s50YHCu/ZKfyl4Ahkf70ldCPaUaP4WnWApKXZKfrCYdd0267PJ4MB KxbTjy/4zMZDTC6dZR06qj+JvYW9hvbSONGDCTvmjSAPmMpwJ/DIB5Yq60JfhrVeth0c3dq1te5hwtjReUKEgA9j8tl3pXMpRJ14neeQEs+WEKPmNIy7rVq5 MLFvYKzilglPPRkGrvsVc97xsoAZnFQ/oablebOTuOfMNKlP/yzYJCOruNtcprpg4nCj+gkXxPkK8cyRe9qTkTMevzx20QTWiPsIxFXgNgvzgUVHFZQyH6sO xfkWiBGP+m5OgIhW44sDGDqPdU32hrBv6XcmD+Zu7+WhTsSYh5Sgbd4gujKk3QKL+oiqqoqI4kevS4yXbdXk6+sjioXy5RvgJ6HrECyButS1+fSOwvT/tBs2 K4PVCUJwHESaKQ8za4+7i4rHtqUjK+Uoi9tfuavJjs+QR1XeqkcFTw== Hi Muhammad, On 07/04/2021 12:10, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well. The patch itself looks OK, but it really has to be two separate patches. Regards, Hans > > Signed-off-by: Muhammad Usama Anjum > --- > drivers/staging/axis-fifo/axis-fifo.c | 1 - > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 2bb1c2e9cb57..ed9281089738 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev) > fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); > if (IS_ERR(fifo->base_addr)) { > rc = PTR_ERR(fifo->base_addr); > - dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); > goto err_initial; > } > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 5d4db7a5b4b5..e51d69c4729d 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > core->dos_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->dos_base)) { > - dev_err(dev, "Couldn't remap DOS memory\n"); > + if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > core->esparser_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->esparser_base)) { > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > + if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > - } > > core->regmap_ao = > syscon_regmap_lookup_by_phandle(dev->of_node, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0379EC433B4 for ; Wed, 7 Apr 2021 14:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B865161165 for ; Wed, 7 Apr 2021 14:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352766AbhDGOFv (ORCPT ); Wed, 7 Apr 2021 10:05:51 -0400 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]:34841 "EHLO lb3-smtp-cloud7.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234067AbhDGOFm (ORCPT ); Wed, 7 Apr 2021 10:05:42 -0400 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id U8oAlSJzRMxedU8oDlIhgv; Wed, 07 Apr 2021 16:05:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1617804330; bh=fm44WbDRvg5ne0yHElY/ZyexmCrcHUZfm1JrxKKHYXg=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=aBi0K7CfEbQR3dOy/Dnkf6U3bpGGiR4dImI1ENRMrd+iOMAYetDNcOE91Z8j8c1yC 98QOz9QKMQJ7o0rAL7En+I9RvzA80St63ktEqw9ROlHcY5ZDdFUm4NgFitcZOG+tnu 5Z1t4Zt0gbDXm3gy687VY76pnednaqr7IO51V1TZHSeefFyzr/GQU6gCvCfttw/d+C wCes29Y50tdio3sxOpP7NsPNqIKN/+1kH6v9jJO0GwazL0J90gS5hQdaLIcNoBq9PD SXGIdhXsy2HKIAnGTaG/4IauQ0ILoRX++5JlV010XIz4QudfpmWj9vo0nXdpXYD3yv 0grmeMe/tWusA== Subject: Re: [PATCH] staging: axis-fifo: media/meson: remove redundant dev_err call To: Muhammad Usama Anjum , Greg Kroah-Hartman , Neil Armstrong , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:STAGING SUBSYSTEM" , open list , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "moderated list:ARM/Amlogic Meson SoC support" Cc: linqiheng@huawei.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com References: <20210407101047.GA1491258@LEGION> From: Hans Verkuil Message-ID: <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> Date: Wed, 7 Apr 2021 16:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210407101047.GA1491258@LEGION> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfJuuT3CZKUYbj5nNz8R/l8wm1VJrpjTtQH6J0CmLwm7ghIJ918q0+hbMonNISO7KHY8ltQTOpTNtDRJ8Usjw2cLayCjTim5Lj6hbxFqYwUVV/Qtx3fJy o0P69y7rvrQfzlLdxH8b3CC78srRQDzdHZJ/x7+amPLWayrB6sc/NMDGDF/cHG6rq/ogA/QwcDjLzibQZp+Ly/oyZywn54zrOCrapWyEC5vw5TRHmZP+c90l e6/WiNqO+9zXEPoCZluWJONhoR13VC9A5NrFKRPpOI2J0KxRzbPO4Gn7FH5boVqwzH6s50YHCu/ZKfyl4Ahkf70ldCPaUaP4WnWApKXZKfrCYdd0267PJ4MB KxbTjy/4zMZDTC6dZR06qj+JvYW9hvbSONGDCTvmjSAPmMpwJ/DIB5Yq60JfhrVeth0c3dq1te5hwtjReUKEgA9j8tl3pXMpRJ14neeQEs+WEKPmNIy7rVq5 MLFvYKzilglPPRkGrvsVc97xsoAZnFQ/oablebOTuOfMNKlP/yzYJCOruNtcprpg4nCj+gkXxPkK8cyRe9qTkTMevzx20QTWiPsIxFXgNgvzgUVHFZQyH6sO xfkWiBGP+m5OgIhW44sDGDqPdU32hrBv6XcmD+Zu7+WhTsSYh5Sgbd4gujKk3QKL+oiqqoqI4kevS4yXbdXk6+sjioXy5RvgJ6HrECyButS1+fSOwvT/tBs2 K4PVCUJwHESaKQ8za4+7i4rHtqUjK+Uoi9tfuavJjs+QR1XeqkcFTw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Muhammad, On 07/04/2021 12:10, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well. The patch itself looks OK, but it really has to be two separate patches. Regards, Hans > > Signed-off-by: Muhammad Usama Anjum > --- > drivers/staging/axis-fifo/axis-fifo.c | 1 - > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 2bb1c2e9cb57..ed9281089738 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev) > fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); > if (IS_ERR(fifo->base_addr)) { > rc = PTR_ERR(fifo->base_addr); > - dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); > goto err_initial; > } > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 5d4db7a5b4b5..e51d69c4729d 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > core->dos_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->dos_base)) { > - dev_err(dev, "Couldn't remap DOS memory\n"); > + if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > core->esparser_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->esparser_base)) { > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > + if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > - } > > core->regmap_ao = > syscon_regmap_lookup_by_phandle(dev->of_node, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7BD3C433ED for ; Wed, 7 Apr 2021 14:08:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3BC8A6044F for ; Wed, 7 Apr 2021 14:08:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3BC8A6044F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1pyOoqZpEE8ahr61Ifgbl+iVxu2kNPqE/b0C/1afh+U=; b=I6T3nC0Pis2Wub1hvZMrcLRTJ D517w42s8Cp9HdwahH8TXTZq/yuDLc4Dx8FcntCnjR1eXlJmY01GTLyqr2HbZ6+21GrGoRRbD1nJv uccAu4cxJuNT7rPw2EZh8XQan4u8wzmAD4qc1EmuLi/9znsOJxaIC8oXsN66AEC3ilS1k1exgFYJs firltxiwb59BzaMcWAqN1Ggb8VC0nWlrqruxrQtxrxmrZOA4Hsv6X8iOPj2jwHz0cJiIz4varA+uQ cINxI0Q7/K3PjpUID4mrNsygqTvQLkRdQMF4wKo5IF7KIK+WKr+zw8t2IUI5v7Q35Gkf1NMe4IeKi TiZW8qIiw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU8p5-0055Zz-4D; Wed, 07 Apr 2021 14:06:23 +0000 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU8oP-0055XM-3g; Wed, 07 Apr 2021 14:05:47 +0000 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id U8oAlSJzRMxedU8oDlIhgv; Wed, 07 Apr 2021 16:05:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1617804330; bh=fm44WbDRvg5ne0yHElY/ZyexmCrcHUZfm1JrxKKHYXg=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=aBi0K7CfEbQR3dOy/Dnkf6U3bpGGiR4dImI1ENRMrd+iOMAYetDNcOE91Z8j8c1yC 98QOz9QKMQJ7o0rAL7En+I9RvzA80St63ktEqw9ROlHcY5ZDdFUm4NgFitcZOG+tnu 5Z1t4Zt0gbDXm3gy687VY76pnednaqr7IO51V1TZHSeefFyzr/GQU6gCvCfttw/d+C wCes29Y50tdio3sxOpP7NsPNqIKN/+1kH6v9jJO0GwazL0J90gS5hQdaLIcNoBq9PD SXGIdhXsy2HKIAnGTaG/4IauQ0ILoRX++5JlV010XIz4QudfpmWj9vo0nXdpXYD3yv 0grmeMe/tWusA== Subject: Re: [PATCH] staging: axis-fifo: media/meson: remove redundant dev_err call To: Muhammad Usama Anjum , Greg Kroah-Hartman , Neil Armstrong , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:STAGING SUBSYSTEM" , open list , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "moderated list:ARM/Amlogic Meson SoC support" Cc: linqiheng@huawei.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com References: <20210407101047.GA1491258@LEGION> From: Hans Verkuil Message-ID: <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> Date: Wed, 7 Apr 2021 16:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210407101047.GA1491258@LEGION> Content-Language: en-US X-CMAE-Envelope: MS4xfJuuT3CZKUYbj5nNz8R/l8wm1VJrpjTtQH6J0CmLwm7ghIJ918q0+hbMonNISO7KHY8ltQTOpTNtDRJ8Usjw2cLayCjTim5Lj6hbxFqYwUVV/Qtx3fJy o0P69y7rvrQfzlLdxH8b3CC78srRQDzdHZJ/x7+amPLWayrB6sc/NMDGDF/cHG6rq/ogA/QwcDjLzibQZp+Ly/oyZywn54zrOCrapWyEC5vw5TRHmZP+c90l e6/WiNqO+9zXEPoCZluWJONhoR13VC9A5NrFKRPpOI2J0KxRzbPO4Gn7FH5boVqwzH6s50YHCu/ZKfyl4Ahkf70ldCPaUaP4WnWApKXZKfrCYdd0267PJ4MB KxbTjy/4zMZDTC6dZR06qj+JvYW9hvbSONGDCTvmjSAPmMpwJ/DIB5Yq60JfhrVeth0c3dq1te5hwtjReUKEgA9j8tl3pXMpRJ14neeQEs+WEKPmNIy7rVq5 MLFvYKzilglPPRkGrvsVc97xsoAZnFQ/oablebOTuOfMNKlP/yzYJCOruNtcprpg4nCj+gkXxPkK8cyRe9qTkTMevzx20QTWiPsIxFXgNgvzgUVHFZQyH6sO xfkWiBGP+m5OgIhW44sDGDqPdU32hrBv6XcmD+Zu7+WhTsSYh5Sgbd4gujKk3QKL+oiqqoqI4kevS4yXbdXk6+sjioXy5RvgJ6HrECyButS1+fSOwvT/tBs2 K4PVCUJwHESaKQ8za4+7i4rHtqUjK+Uoi9tfuavJjs+QR1XeqkcFTw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_150542_990272_0F958057 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Muhammad, On 07/04/2021 12:10, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well. The patch itself looks OK, but it really has to be two separate patches. Regards, Hans > > Signed-off-by: Muhammad Usama Anjum > --- > drivers/staging/axis-fifo/axis-fifo.c | 1 - > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 2bb1c2e9cb57..ed9281089738 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev) > fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); > if (IS_ERR(fifo->base_addr)) { > rc = PTR_ERR(fifo->base_addr); > - dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); > goto err_initial; > } > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 5d4db7a5b4b5..e51d69c4729d 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > core->dos_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->dos_base)) { > - dev_err(dev, "Couldn't remap DOS memory\n"); > + if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > core->esparser_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->esparser_base)) { > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > + if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > - } > > core->regmap_ao = > syscon_regmap_lookup_by_phandle(dev->of_node, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D067C433B4 for ; Wed, 7 Apr 2021 14:06:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E009C611C1 for ; Wed, 7 Apr 2021 14:06:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E009C611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fte+Tfp6IpT8KuPUSxsrtR8mgeNW2/E8Ymqyf6Zroys=; b=p7F/iCS7Y06lA8Br6uojD5J5x N5Mj1veM0lHEgPpB14IgdiJxLMeDKI7Pdkik9dhSCH/6Yj2mrmAjV8o/+/PvhtsZnvSFB2EuZgjVy z31pX/jQCoq7a9HaxBUUlTcboDPzASabYxk76x+Crk2X2DMAJjeV9QpFvqqYicCxCPnurbTXpFKu0 wTUYjLM/BooZnlJI75Y7aQXsLzCzCT6/GWfRT5Ph/d29D3K6y2w0gsNfryyiCao9ykGHSk2O+jlqb Z0PCyMKbBl+NYj1Y1jUmMwG4dU+rzqWSHaoUnTvGqaCH5Qt4MTrX9jUHl+wyTfu48QtuXllqCeVPz 9ne8fBKQQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lU8os-0055Z9-Bz; Wed, 07 Apr 2021 14:06:10 +0000 Received: from lb3-smtp-cloud7.xs4all.net ([194.109.24.31]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lU8oP-0055XM-3g; Wed, 07 Apr 2021 14:05:47 +0000 Received: from cust-b5b5937f ([IPv6:fc0c:c16d:66b8:757f:c639:739b:9d66:799d]) by smtp-cloud7.xs4all.net with ESMTPA id U8oAlSJzRMxedU8oDlIhgv; Wed, 07 Apr 2021 16:05:30 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xs4all.nl; s=s2; t=1617804330; bh=fm44WbDRvg5ne0yHElY/ZyexmCrcHUZfm1JrxKKHYXg=; h=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:From: Subject; b=aBi0K7CfEbQR3dOy/Dnkf6U3bpGGiR4dImI1ENRMrd+iOMAYetDNcOE91Z8j8c1yC 98QOz9QKMQJ7o0rAL7En+I9RvzA80St63ktEqw9ROlHcY5ZDdFUm4NgFitcZOG+tnu 5Z1t4Zt0gbDXm3gy687VY76pnednaqr7IO51V1TZHSeefFyzr/GQU6gCvCfttw/d+C wCes29Y50tdio3sxOpP7NsPNqIKN/+1kH6v9jJO0GwazL0J90gS5hQdaLIcNoBq9PD SXGIdhXsy2HKIAnGTaG/4IauQ0ILoRX++5JlV010XIz4QudfpmWj9vo0nXdpXYD3yv 0grmeMe/tWusA== Subject: Re: [PATCH] staging: axis-fifo: media/meson: remove redundant dev_err call To: Muhammad Usama Anjum , Greg Kroah-Hartman , Neil Armstrong , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , "open list:STAGING SUBSYSTEM" , open list , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "open list:MESON VIDEO DECODER DRIVER FOR AMLOGIC SOCS" , "moderated list:ARM/Amlogic Meson SoC support" Cc: linqiheng@huawei.com, kernel-janitors@vger.kernel.org, dan.carpenter@oracle.com References: <20210407101047.GA1491258@LEGION> From: Hans Verkuil Message-ID: <93218bc8-2cbb-bacc-f985-876a842261c4@xs4all.nl> Date: Wed, 7 Apr 2021 16:05:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210407101047.GA1491258@LEGION> Content-Language: en-US X-CMAE-Envelope: MS4xfJuuT3CZKUYbj5nNz8R/l8wm1VJrpjTtQH6J0CmLwm7ghIJ918q0+hbMonNISO7KHY8ltQTOpTNtDRJ8Usjw2cLayCjTim5Lj6hbxFqYwUVV/Qtx3fJy o0P69y7rvrQfzlLdxH8b3CC78srRQDzdHZJ/x7+amPLWayrB6sc/NMDGDF/cHG6rq/ogA/QwcDjLzibQZp+Ly/oyZywn54zrOCrapWyEC5vw5TRHmZP+c90l e6/WiNqO+9zXEPoCZluWJONhoR13VC9A5NrFKRPpOI2J0KxRzbPO4Gn7FH5boVqwzH6s50YHCu/ZKfyl4Ahkf70ldCPaUaP4WnWApKXZKfrCYdd0267PJ4MB KxbTjy/4zMZDTC6dZR06qj+JvYW9hvbSONGDCTvmjSAPmMpwJ/DIB5Yq60JfhrVeth0c3dq1te5hwtjReUKEgA9j8tl3pXMpRJ14neeQEs+WEKPmNIy7rVq5 MLFvYKzilglPPRkGrvsVc97xsoAZnFQ/oablebOTuOfMNKlP/yzYJCOruNtcprpg4nCj+gkXxPkK8cyRe9qTkTMevzx20QTWiPsIxFXgNgvzgUVHFZQyH6sO xfkWiBGP+m5OgIhW44sDGDqPdU32hrBv6XcmD+Zu7+WhTsSYh5Sgbd4gujKk3QKL+oiqqoqI4kevS4yXbdXk6+sjioXy5RvgJ6HrECyButS1+fSOwvT/tBs2 K4PVCUJwHESaKQ8za4+7i4rHtqUjK+Uoi9tfuavJjs+QR1XeqkcFTw== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210407_150542_990272_0F958057 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Muhammad, On 07/04/2021 12:10, Muhammad Usama Anjum wrote: > devm_ioremap_resource() prints error message in itself. Remove the > dev_err call to avoid redundant error message. Please split this up into two separate patches! They are independent changes and these two drivers are maintained by different people as well. The patch itself looks OK, but it really has to be two separate patches. Regards, Hans > > Signed-off-by: Muhammad Usama Anjum > --- > drivers/staging/axis-fifo/axis-fifo.c | 1 - > drivers/staging/media/meson/vdec/vdec.c | 8 ++------ > 2 files changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 2bb1c2e9cb57..ed9281089738 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -853,7 +853,6 @@ static int axis_fifo_probe(struct platform_device *pdev) > fifo->base_addr = devm_ioremap_resource(fifo->dt_device, r_mem); > if (IS_ERR(fifo->base_addr)) { > rc = PTR_ERR(fifo->base_addr); > - dev_err(fifo->dt_device, "can't remap IO resource (%d)\n", rc); > goto err_initial; > } > > diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c > index 5d4db7a5b4b5..e51d69c4729d 100644 > --- a/drivers/staging/media/meson/vdec/vdec.c > +++ b/drivers/staging/media/meson/vdec/vdec.c > @@ -1008,17 +1008,13 @@ static int vdec_probe(struct platform_device *pdev) > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dos"); > core->dos_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->dos_base)) { > - dev_err(dev, "Couldn't remap DOS memory\n"); > + if (IS_ERR(core->dos_base)) > return PTR_ERR(core->dos_base); > - } > > r = platform_get_resource_byname(pdev, IORESOURCE_MEM, "esparser"); > core->esparser_base = devm_ioremap_resource(dev, r); > - if (IS_ERR(core->esparser_base)) { > - dev_err(dev, "Couldn't remap ESPARSER memory\n"); > + if (IS_ERR(core->esparser_base)) > return PTR_ERR(core->esparser_base); > - } > > core->regmap_ao = > syscon_regmap_lookup_by_phandle(dev->of_node, > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic