From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:45102 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755541AbeDWPlH (ORCPT ); Mon, 23 Apr 2018 11:41:07 -0400 Subject: Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command. To: Roopa Prabhu , David Miller References: <1524119910.3024.12.camel@sipsolutions.net> <173c5f98-36bc-2e52-1e64-3a5f89008d46@candelatech.com> <1524151617.3024.25.camel@sipsolutions.net> <20180422.145420.1197041027922699603.davem@davemloft.net> Cc: netdev , Johannes Berg , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org From: Ben Greear Message-ID: <93312fe6-d39c-8ce2-1717-54d03959a8c8@candelatech.com> (sfid-20180423_174111_420599_B8E6AE69) Date: Mon, 23 Apr 2018 08:41:04 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04/22/2018 02:15 PM, Roopa Prabhu wrote: > On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: >> From: Johannes Berg >> Date: Thu, 19 Apr 2018 17:26:57 +0200 >> >>> On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: >>>> >>>> Maybe this could be in followup patches? It's going to touch a lot of files, >>>> and might be hell to get merged all at once, and I've never used spatch, so >>>> just maybe someone else will volunteer that part :) >>> >>> I guess you'll have to ask davem. :) >> >> Well, first of all, I really don't like this. >> >> The first reason is that every time I see interface foo become foo2, >> foo3 is never far behind it. >> >> If foo was not extensible enough such that we needed foo2, we beter >> design the new thing with explicitly better extensibility in mind. >> >> Furthermore, what you want here is a specific filter. Someone else >> will want to filter on another criteria, and the next person will >> want yet another. >> >> This needs to be properly generalized. >> >> And frankly if we had moved to ethtool netlink/devlink by now, we >> could just add a netlink attribute for filtering and not even be >> having this conversation. > > > +1. > > Also, the RTM_GETSTATS api was added to improve stats query efficiency > (with filters). > we should look at it to see if this fits there. Keeping all stats > queries in one place will help. I like the ethtool API, so I'll be sticking with that for now. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAdai-0000VO-Mu for ath10k@lists.infradead.org; Mon, 23 Apr 2018 15:41:22 +0000 Subject: Re: [PATCH 1/3] ethtool: Support ETHTOOL_GSTATS2 command. References: <1524119910.3024.12.camel@sipsolutions.net> <173c5f98-36bc-2e52-1e64-3a5f89008d46@candelatech.com> <1524151617.3024.25.camel@sipsolutions.net> <20180422.145420.1197041027922699603.davem@davemloft.net> From: Ben Greear Message-ID: <93312fe6-d39c-8ce2-1717-54d03959a8c8@candelatech.com> Date: Mon, 23 Apr 2018 08:41:04 -0700 MIME-Version: 1.0 In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Roopa Prabhu , David Miller Cc: netdev , Johannes Berg , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org On 04/22/2018 02:15 PM, Roopa Prabhu wrote: > On Sun, Apr 22, 2018 at 11:54 AM, David Miller wrote: >> From: Johannes Berg >> Date: Thu, 19 Apr 2018 17:26:57 +0200 >> >>> On Thu, 2018-04-19 at 08:25 -0700, Ben Greear wrote: >>>> >>>> Maybe this could be in followup patches? It's going to touch a lot of files, >>>> and might be hell to get merged all at once, and I've never used spatch, so >>>> just maybe someone else will volunteer that part :) >>> >>> I guess you'll have to ask davem. :) >> >> Well, first of all, I really don't like this. >> >> The first reason is that every time I see interface foo become foo2, >> foo3 is never far behind it. >> >> If foo was not extensible enough such that we needed foo2, we beter >> design the new thing with explicitly better extensibility in mind. >> >> Furthermore, what you want here is a specific filter. Someone else >> will want to filter on another criteria, and the next person will >> want yet another. >> >> This needs to be properly generalized. >> >> And frankly if we had moved to ethtool netlink/devlink by now, we >> could just add a netlink attribute for filtering and not even be >> having this conversation. > > > +1. > > Also, the RTM_GETSTATS api was added to improve stats query efficiency > (with filters). > we should look at it to see if this fits there. Keeping all stats > queries in one place will help. I like the ethtool API, so I'll be sticking with that for now. Thanks, Ben -- Ben Greear Candela Technologies Inc http://www.candelatech.com _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k