From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50404C433FE for ; Fri, 14 Oct 2022 15:36:04 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C9AFD84DFC; Fri, 14 Oct 2022 17:36:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=siemens.com header.i=@siemens.com header.b="uv5mSSp5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 792EE84EB9; Fri, 14 Oct 2022 17:35:59 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B118F8456E for ; Fri, 14 Oct 2022 17:35:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=siemens.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jan.kiszka@siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c8lcirBwIXocG/yNc4E3tG2ckvHvVaAmXjt/Fyqx0GhqQI+0AAcu+1MlfUVvDuvKwEsDj4OftTVVxaFufeY3txmcBwGVaTHk+sszikS3BbUs8Trvxt+fhsWXe11KVdTpRtDKr2r9F2rXlK9qKWcebDhYPbEnuk+nCrKrFyGDrzZ+QDDDAxfMWaX4NmCiAq43JIwmsy0ua2H8Jm0Q1CvECWh0GThuIAxXxplcIGJ7iKghvGUd/ZubAzj+3hC/0MEXw6M2zFor7VSPSPwtM5f0JH8N1jwY2/70XZJCjwOxZ4dNuWc/D4eDOOAyQrwOuT8g0Cj9jW1QKmngLuBr2QCv6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=haj2i1AlxjtHKntx0GYT9vXX82YOstR/vccbHHH7TuA=; b=SZrgaA5v8gSQVDEXPiireFdycDnCBQ8mnLVEVMtObPjfggDSY2PDqc1r+Td+ShthQXQ9wridXQhRIwkNWCwfux7rcf+K1fiuItXKZUqiUeDVswXonfCIFkPVR5N/ZAknrgwBkZqpgOEmIhpSEXc+BF3sA3SdWyGteKPRRl+fosrAHIz5GBnhCaCRfBtfvvZhJcA2WBprU9YthhNdwEYuiW73uGMNB3OFLvya4C/B/eeWA0CnR7UFLoJKArLrAEpZWddMOpHeENWrIQgC/usbJrL5HCdiX4eeztA1Pm/OAa1xWXtoGnFItwxrINF0Dp04cVlyj/zP85G/tDYPHDfE6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.74) smtp.rcpttodomain=konsulko.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=haj2i1AlxjtHKntx0GYT9vXX82YOstR/vccbHHH7TuA=; b=uv5mSSp5KLOI6jqkM64u9ZcpjVnRJLWS2jkWZuETVUcR5wDt2gl3Rzhx3kRRP42amcO64I9i9gmZmUialSlZ7WpbwCq8KybVaGn78Ujq3sZbD3I9gG4omb4VzI2/XGFBBpAEQVWFOZMwoACzrYgJbqfO1o/HamvZsOB0/v8cO4N7bE7VRVjpG4X1wSX+KgxYTx1TebtpdoA1fEd6eEPsjYx/IHb6eSR/07hNEc3lSBC5sE1V+Iv9b0/I2L5TE8Z52mpNeuJBaiO3fJ5UQxum69z1Fwy1ZD1ySfkROgyglj6y/HCW010dUk1eXNZZDgpq4qmhZmuqiZEzptMj7IYYsw== Received: from GV3P280CA0101.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::16) by GVXPR10MB5840.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:6a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.26; Fri, 14 Oct 2022 15:35:55 +0000 Received: from HE1EUR01FT073.eop-EUR01.prod.protection.outlook.com (2603:10a6:150:8:cafe::a8) by GV3P280CA0101.outlook.office365.com (2603:10a6:150:8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.28 via Frontend Transport; Fri, 14 Oct 2022 15:35:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.74) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.74 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.74; helo=hybrid.siemens.com; pr=C Received: from hybrid.siemens.com (194.138.21.74) by HE1EUR01FT073.mail.protection.outlook.com (10.152.1.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.20 via Frontend Transport; Fri, 14 Oct 2022 15:35:54 +0000 Received: from DEMCHDC89XA.ad011.siemens.net (139.25.226.103) by DEMCHDC8VQA.ad011.siemens.net (194.138.21.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.12; Fri, 14 Oct 2022 17:35:51 +0200 Received: from [139.21.18.154] (139.21.18.154) by DEMCHDC89XA.ad011.siemens.net (139.25.226.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.12; Fri, 14 Oct 2022 17:35:46 +0200 Message-ID: <93359f56-b4c8-586d-ea77-cff9808d2e4b@siemens.com> Date: Fri, 14 Oct 2022 17:35:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2 01/39] RFC: efi: Drop code that doesn't work with driver model Content-Language: en-US To: Tom Rini CC: Heinrich Schuchardt , Bin Meng , Christian Melki , Ilias Apalodimas , U-Boot Mailing List , Alexander Graf , Simon Glass References: <20210925003055.759305-1-sjg@chromium.org> <20210924183029.v2.1.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <5e4facbe-c78b-c3a6-2fb6-b268e8761d66@gmx.de> <87380b1a-5011-1e75-a02c-2508227e9818@siemens.com> <20221014152029.GT2020586@bill-the-cat> <45c70284-f293-3e00-4281-e46ca04b849d@siemens.com> <20221014153444.GU2020586@bill-the-cat> From: Jan Kiszka In-Reply-To: <20221014153444.GU2020586@bill-the-cat> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [139.21.18.154] X-ClientProxiedBy: DEMCHDC8WAA.ad011.siemens.net (139.25.226.104) To DEMCHDC89XA.ad011.siemens.net (139.25.226.103) X-TM-AS-Product-Ver: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-AS-Result: No-10--14.367800-8.000000 X-TMASE-MatchedRID: 5gCJM1F5pVc5QaOxwNGfvo9bHfxDWoibW6eKzKKCgnPBjbyj5wYDmv6l pfpte41hWAuSz3ewb220QygafZjV1RvER19e8+LDuWcLt7UQTIALyuqgPh8WPp3bt4XlQMWjecm 5MLY/474da1Vk3RqxOIgnLdHU7oiOHPbzAuybsHyFvwEmnsW3vcHVNeDWrWSGdhnFihmbnwVp4x orO9dSmdzONa1Rspx34rl+FHG3VoDu6gyVCKrNt/5nI8KIHQ65Xnan/9QqlwtfvuAR8NI0nClay zmQ9QV0o1NatSknW0o/PJ8p+RzsAaZQJOJiUzzRnKmf6d82B1mj9HPhXvu25ArgwFF/sjumIiTd 2l7lf6HDshTlues35G2HWvR90BF16NIZ/ft6soBRHkbwQy5W80fX0Ayg3UN3JKe4kl4op4SU2cl PVGqDdioBmWjkLcuLKlYwxaYDzXcrdWdGoKfUyh95HWtSnJR9YMunTeJZsMlKzOvae5Q0rC6MyP q4TWG5tsxVqq1TeAVeN6wU53SkzufOVcxjDhcwAYt5KiTiutkLbigRnpKlKSBuGJWwgxAra7leo U/OMhNYsCaawSIuKfJX+RSemBxhevK5mvwd0iMCnj0Isb6ueP8gQkXEPaKOftwZ3X11IV0= X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--14.367800-8.000000 X-TMASE-Version: SMEX-14.0.0.3080-8.6.1018-26680.007 X-TM-SNTS-SMTP: B8AA56AE6476F951BF7F0F21B642BC2E05AAE0FAD849ECE0674657AC8A4DBDCE2000:8 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: HE1EUR01FT073:EE_|GVXPR10MB5840:EE_ X-MS-Office365-Filtering-Correlation-Id: 19a93c1b-6433-41fa-5c60-08daadf9c89e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9rzqhu9pHHkING8h6hZH8xjex3Vq+Es/GUMOAaQeHHkQVxIJsxkUc4tahi1orK3EHSj1wiGOI9OJRxIs+am2I09vG9h3xxYpbEIn6PO6+2C+4sb0pvMxGOddonDKa1qValbxcZgVQWJ+pAkUgslKs5qK3tQ22OCpXM5COAG068BBTMjAI21pt47+Dmgtm2L8bQoquKa26HC0QK4jjHWWhb++KGUZ+w8aG8mkX6IOVEqpXa83F5qEgFOzKIJ8Ae/7Inx6rOxTl/uIqRRjl1yIb0O0QzjsoNJ/PC0uoh2nJsYEd9UaW5gd8Y59xxaT1jRMu6BfC7RXqSQR2sYtr7DAP0L43fP8DMWFgNIRDAVfRFpVpWSWdZ73YUk6WW/ZK7O9TFttgZhZw2KTsH5RNb0BezutnHkoTrrO7vh6l072FDSdhacVCw2muYEJtXUFz1rT+7FSCjuqu7xyBaVrnJvoOcM+1u19JmzFWfjHLseTddZGQ30uVAhG3SdNctO9oJN9Vj7xuwo8A2p0IfQqKM8uHuIVNQsWcsM9syb6xkxDmIoAQn2GOleFjNQC7q1mpzfW5PItoc7gePa/TyDdA7HLumk41PGc1yBXPvPVx9MsCOQ+EYhXBDpeEnYnlH3L2UTdUcW44Srw25N4wqutJGRVVrKLSy8Y4HdPpdug6EbgOeT4vC6bLooH6yKQxZhJla+bnrQvTNDidnFxCifYuH25d5zzBrAuTnIM8yXSIlYgwAJeYz1+YT8Fe5uduwwaXklnf+pvLZhLN9j6tWQrLzyRp1nFVV9kjhK3NjQHJ3Yq/r3Y9+MaaiWB+l5an+cXcI93Vtzxt/5egu57zCVOVlH/SK52l7rXFA12QiWebjVIhV0= X-Forefront-Antispam-Report: CIP:194.138.21.74; CTRY:DE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:hybrid.siemens.com; PTR:hybrid.siemens.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(346002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(54906003)(4326008)(956004)(82310400005)(6916009)(8936002)(70206006)(70586007)(316002)(8676002)(41300700001)(478600001)(16576012)(36756003)(5660300002)(186003)(36860700001)(34070700002)(40460700003)(44832011)(7636003)(6706004)(82740400003)(356005)(6666004)(40480700001)(26005)(2616005)(82960400001)(31696002)(336012)(53546011)(7596003)(86362001)(16526019)(47076005)(83380400001)(31686004)(2906002)(66899015)(3940600001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 15:35:54.9692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 19a93c1b-6433-41fa-5c60-08daadf9c89e X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a; Ip=[194.138.21.74]; Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT073.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB5840 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 14.10.22 17:34, Tom Rini wrote: > On Fri, Oct 14, 2022 at 05:27:39PM +0200, Jan Kiszka wrote: >> On 14.10.22 17:20, Tom Rini wrote: >>> On Fri, Oct 14, 2022 at 05:10:55PM +0200, Heinrich Schuchardt wrote: >>>> On 10/14/22 13:51, Jan Kiszka wrote: >>>>> On 21.10.21 01:34, Heinrich Schuchardt wrote: >>>>>> On 9/25/21 2:30 AM, Simon Glass wrote: >>>>>>> This code should never have been added as it builds a new feature on top >>>>>>> of legacy code. This has already been improved with the dependency on >>>>>>> BLK. >>>>>>> >>>>>>> Add a dependency on DM_ETH also, to avoid needing to deal with this old >>>>>>> code. >>>>>>> >>>>>>> Boards which want EFI_LOADER should migrate to driver model first. >>>>>>> >>>>>>> Note this patch is included to resolve the following build error: >>>>>>> >>>>>>> lib/efi_loader/efi_runtime.c:680:16: error: ‘CONFIG_SYS_TEXT_BASE’ >>>>>>>     undeclared (first use in this function); did you mean >>>>>>>     ‘CONFIG_SYS_SRAM_BASE’? >>>>>>>    680 |   ulong base = CONFIG_SYS_TEXT_BASE; >>>>>>>        |                ^~~~~~~~~~~~~~~~~~~~ >>>>>>>        |                CONFIG_SYS_SRAM_BASE >>>>>>> >>>>>>> Signed-off-by: Simon Glass >>>>>> >>>>>> Reviewed-by: Heinrich Schuchardt >>>>>> >>>>> >>>>> How to deal with boards that need CONFIG_NET but do not actually >>>>> implement any driver (yet)? This now broke UEFI for the IOT2050 which >>>>> needs NET for network-related device tree setup (see also [1]) and >>>>> enforces a local hack for us. >>>> >>>> UEFI will not provide network without a DM driver. >>>> The migration period ended 2020.07. >>>> >>>> make iot2050_defconfig set EFI_LOADER=y. >>>> What does not work in UEFI? >>>> >>>> Are you missing a way to call eth_get_dev() to trigger aforementioned >>>> devicetree setup? >>>> >>>> Adding 'net list' to CONFIG_PREBOOT might do the trick. >>> >>> I think, and this is why I suggested NETDEVICES, the issue is that there >>> is no network driver in U-Boot, but we need to have networking support >>> enabled in general, in order to perform device tree fixups for Linux >>> where there is the network driver. >>> >> >> Exactly. >> >> Unfortunately, NETDEVICES does not do the trick because it selects >> DM_ETH anyway, thus you don't detect legacy network drivers this way. > > Right, but does your platform enable NETDEVICES? It sounds like it > shouldn't be since you don't have devices in U-Boot? Or something else? > NETDEVICES is off, obviously. Jan -- Siemens AG, Technology Competence Center Embedded Linux