From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6956FC43603 for ; Thu, 19 Dec 2019 07:56:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B59924650 for ; Thu, 19 Dec 2019 07:56:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XQ5kw+KJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbfLSH4p (ORCPT ); Thu, 19 Dec 2019 02:56:45 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:21096 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726439AbfLSH4o (ORCPT ); Thu, 19 Dec 2019 02:56:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576742203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvRns0+s5ODaaBbR9sMA0LBUY8/sENZwJrqscoaTGtk=; b=XQ5kw+KJb+t1+BzQqY9s6hA91bWe8liRTtFL65vJvPcebxgkrYIKhnHpiIYZ5A6+XC3+y9 +BzsZlGcOjBpbrFL4N2jYBaYrDSS/Ux4LaWAWS2DZ42BM3KF/vhAQ7vRIFwhu3IiSVdoza FdZBHML154T6gPNeROmmYNbDiJW2wFQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-232-1ErO75Y3Nii5mZirEPdZPg-1; Thu, 19 Dec 2019 02:56:40 -0500 X-MC-Unique: 1ErO75Y3Nii5mZirEPdZPg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17E30DBDA; Thu, 19 Dec 2019 07:56:35 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-52.rdu2.redhat.com [10.10.120.52]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7B0467E47; Thu, 19 Dec 2019 07:56:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <157558502272.10278.8718685637610645781.stgit@warthog.procyon.org.uk> <20191206135604.GB2734@twin.jikos.cz> <20191219000013.GB13065@localhost> <20191219001446.GA49812@localhost> To: Linus Torvalds Cc: dhowells@redhat.com, Josh Triplett , Konstantin Khlebnikov , Akemi Yagi , DJ Delorie , David Sterba , Eric Biggers , Al Viro , linux-fsdevel , Linux Kernel Mailing List , Peter Zijlstra , Ingo Molnar , Vincent Guittot Subject: Re: [PATCH 0/2] pipe: Fixes [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <934.1576742190.1@warthog.procyon.org.uk> Date: Thu, 19 Dec 2019 07:56:30 +0000 Message-ID: <935.1576742190@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > If I were to actually commit it, the "split into two waitqueues" would > be a separate patch from the "use wait_event_interruptible_exclusive() > and add "wake_next_reader/writer logic", but for testing purposes the > unified patch was simpler, and your forward port looks good to me. I looked at splitting the waitqueue in to two, but it makes poll tricky. David