From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69AFBC433F5 for ; Fri, 14 Jan 2022 10:28:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237318AbiANK2P convert rfc822-to-8bit (ORCPT ); Fri, 14 Jan 2022 05:28:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233947AbiANK2P (ORCPT ); Fri, 14 Jan 2022 05:28:15 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4521AC061574 for ; Fri, 14 Jan 2022 02:28:15 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8JoZ-0007TH-K0; Fri, 14 Jan 2022 11:28:11 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1n8JoX-0006cp-EB; Fri, 14 Jan 2022 11:28:09 +0100 Message-ID: <936f9c0c1de0fcf485b8f5e7a9e1a07b04d0b040.camel@pengutronix.de> Subject: Re: [RFC 22/28] drm: rcar-du: Add RZ/G2L DSI driver From: Philipp Zabel To: Biju Das , David Airlie , Daniel Vetter Cc: Laurent Pinchart , Kieran Bingham , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad Date: Fri, 14 Jan 2022 11:28:09 +0100 In-Reply-To: <20220112174612.10773-23-biju.das.jz@bp.renesas.com> References: <20220112174612.10773-1-biju.das.jz@bp.renesas.com> <20220112174612.10773-23-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-renesas-soc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Biju, On Wed, 2022-01-12 at 17:46 +0000, Biju Das wrote: [...] > +static int rzg2l_mipi_dsi_probe(struct platform_device *pdev) > +{ [...] > + dsi->rstc = devm_reset_control_get(dsi->dev, "rst"); [...] > + dsi->arstc = devm_reset_control_get(dsi->dev, "arst"); [...] > + dsi->prstc = devm_reset_control_get(dsi->dev, "prst"); Please use devm_reset_control_get_exclusive() instead. regards Philipp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 269FEC433EF for ; Fri, 14 Jan 2022 10:28:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2910C10E90D; Fri, 14 Jan 2022 10:28:16 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F07D10E8E9 for ; Fri, 14 Jan 2022 10:28:14 +0000 (UTC) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8JoZ-0007TH-K0; Fri, 14 Jan 2022 11:28:11 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1n8JoX-0006cp-EB; Fri, 14 Jan 2022 11:28:09 +0100 Message-ID: <936f9c0c1de0fcf485b8f5e7a9e1a07b04d0b040.camel@pengutronix.de> Subject: Re: [RFC 22/28] drm: rcar-du: Add RZ/G2L DSI driver From: Philipp Zabel To: Biju Das , David Airlie , Daniel Vetter Date: Fri, 14 Jan 2022 11:28:09 +0100 In-Reply-To: <20220112174612.10773-23-biju.das.jz@bp.renesas.com> References: <20220112174612.10773-1-biju.das.jz@bp.renesas.com> <20220112174612.10773-23-biju.das.jz@bp.renesas.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Paterson , Geert Uytterhoeven , Prabhakar Mahadev Lad , dri-devel@lists.freedesktop.org, Biju Das , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Biju, On Wed, 2022-01-12 at 17:46 +0000, Biju Das wrote: [...] > +static int rzg2l_mipi_dsi_probe(struct platform_device *pdev) > +{ [...] > + dsi->rstc =3D devm_reset_control_get(dsi->dev, "rst"); [...] > + dsi->arstc =3D devm_reset_control_get(dsi->dev, "arst"); [...] > + dsi->prstc =3D devm_reset_control_get(dsi->dev, "prst"); Please use devm_reset_control_get_exclusive() instead. regards Philipp