From: Paolo Bonzini <pbonzini@redhat.com>
To: "Roman Kagan" <rkagan@virtuozzo.com>,
kvm@vger.kernel.org, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v5 2/2] kvm: x86: hyperv: guest->host event signaling via eventfd
Date: Tue, 12 Dec 2017 17:22:20 +0100 [thread overview]
Message-ID: <938118d0-9296-0c0c-3251-275778c71c05@redhat.com> (raw)
In-Reply-To: <20171212160742.793-3-rkagan@virtuozzo.com>
On 12/12/2017 17:07, Roman Kagan wrote:
> + idx = srcu_read_lock(&vcpu->kvm->srcu);
> + ret = kvm_vcpu_read_guest(vcpu, gpa, ¶m, sizeof(param));
> + srcu_read_unlock(&vcpu->kvm->srcu, idx);
> +
The lock/unlock is not needed (vcpu_enter_guest -> vmx_handle_exit ->
handle_vmcall -> kvm_emulate_hypercall -> kvm_hv_hypercall ->
kvm_hvcall_signal_event). I'll drop it.
Thanks,
next prev parent reply other threads:[~2017-12-12 16:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 16:07 [PATCH v5 0/2] kvm: x86: hyperv: guest->host event signaling via eventfd Roman Kagan
2017-12-12 16:07 ` [PATCH v5 1/2] kvm: x86: factor out kvm.arch.hyperv (de)init Roman Kagan
2017-12-12 16:07 ` [PATCH v5 2/2] kvm: x86: hyperv: guest->host event signaling via eventfd Roman Kagan
2017-12-12 16:22 ` Paolo Bonzini [this message]
2017-12-12 16:29 ` David Hildenbrand
2017-12-12 18:18 ` Roman Kagan
2017-12-12 18:20 ` David Hildenbrand
2017-12-13 8:41 ` Roman Kagan
2017-12-13 9:35 ` David Hildenbrand
2017-12-13 10:00 ` Roman Kagan
2017-12-12 17:03 ` Roman Kagan
2017-12-13 9:51 ` David Hildenbrand
2017-12-13 11:04 ` Roman Kagan
2017-12-13 11:14 ` David Hildenbrand
2017-12-13 12:16 ` Roman Kagan
2017-12-13 9:55 ` David Hildenbrand
2017-12-13 11:44 ` Roman Kagan
2017-12-13 11:46 ` David Hildenbrand
2017-12-13 11:51 ` David Hildenbrand
2017-12-13 11:57 ` David Hildenbrand
2017-12-13 12:58 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=938118d0-9296-0c0c-3251-275778c71c05@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@redhat.com \
--cc=den@openvz.org \
--cc=konrad.wilk@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.