[PATCH] run-postinsts: fix setting pi_dir

[PATCH] run-postinsts: fix setting pi_dir

[Trevor Woerner]

The pi_dir variable isn't being set properly; it gets set to the value of the
*previous* package manager. Given the order of "rpm deb ipk", if the script
determines that the package manager is "ipk", pi_dir remains set at
SYSCONFDIR/deb-postinsts.

Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
index f84a7e18c8..c10fd11e9d 100755
--- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
+++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
@@ -20,14 +20,12 @@ for pm in $backend_list; do
 		"deb")
 			if [ -s "#LOCALSTATEDIR#/lib/dpkg/status" ]; then
 				pm_installed=true
-				break
 			fi
 			;;
 
 		"ipk")
 			if [ -s "#LOCALSTATEDIR#/lib/opkg/status" ]; then
 				pm_installed=true
-				break
 			fi
 			;;
 	esac
-- 
2.30.0.rc0

Re: [OE-core] [PATCH] run-postinsts: fix setting pi_dir

[Richard Purdie]

On Tue, 2020-12-22 at 01:46 -0500, Trevor Woerner wrote:
> The pi_dir variable isn't being set properly; it gets set to the
> value of the
> *previous* package manager. Given the order of "rpm deb ipk", if the
> script
> determines that the package manager is "ipk", pi_dir remains set at
> SYSCONFDIR/deb-postinsts.
> 
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
>  meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts | 2
> --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/run-postinsts/run-postinsts/run-
> postinsts b/meta/recipes-devtools/run-postinsts/run-postinsts/run-
> postinsts
> index f84a7e18c8..c10fd11e9d 100755
> --- a/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
> +++ b/meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts
> @@ -20,14 +20,12 @@ for pm in $backend_list; do
>                 "deb")
>                         if [ -s "#LOCALSTATEDIR#/lib/dpkg/status" ];
> then
>                                 pm_installed=true
> -                               break
>                         fi
>                         ;;
>  
>                 "ipk")
>                         if [ -s "#LOCALSTATEDIR#/lib/opkg/status" ];
> then
>                                 pm_installed=true
> -                               break
>                         fi
>                         ;;
>         esac

Just to confirm, this patch causes:

https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/1668

(and other selftest builds failed the same way)

Cheers,

Richard