[U-Boot] [PATCH 00/14] powerpc/p4080: add support for FMan ethernet in Independent mode

[Hu Mingkai-B21284 <B21284@freescale.com>]

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org]
> Sent: Thursday, January 27, 2011 2:05 PM
> To: Hu Mingkai-B21284
> Cc: u-boot at lists.denx.de; Fleming Andy-AFLEMING; Zang Roy-R61911; Liu Dave-
> R63238; Medve Emilian-EMMEDVE1; Tabi Timur-B04825; Phillips Kim-R1AAHA; Haruki
> Dai-R35557; Radulescu Ruxandra Ioana-B05472
> Subject: Re: [PATCH 00/14] powerpc/p4080: add support for FMan ethernet in
> Independent mode
> 
> 
> On Jan 26, 2011, at 10:52 PM, Mingkai Hu wrote:
> 
> > This patchset add support for the P4080's datapath accelation
> > architecture in independent mode, and do some code refactor of the file tsec.c.
> >
> > 1. Add the releated MAC controller support, includeing dTSEC and 10GEC
> > 2. Add support for FMan ethernet in Independent mode 3. Add PHY
> > support (VSC8244 and VSC8234) to a new file fsl_phy.c which  can be
> > reused by other code, such tsec and uec code.
> > 4. tsec code cleanup
> > 5. Move all the PHY code in tsec.c to fsl_phy.c to make it reuseable.
> >
> > Based on the latest WD's U-Boot tree. Tested on P4080DS and MPC8536DS
> > board with SGMII card.
> >
> > [PATCH 01/14] powerpc/p4080: Add function to report which lane is used
> > for a prtcl [PATCH 02/14] powerpc/fman: add PHY support for dTSEC
> > [PATCH 03/14] powerpc/fman: add dTSEC controller support [PATCH 04/14]
> > powerpc/fman: add 10GEC controller and PHY support [PATCH 05/14]
> > powerpc/qoirq: Add support for FMan ethernet in Independent mode
> > [PATCH 06/14] powerpc/corenet_ds: Add fman support [PATCH 07/14] tsec:
> > use IO accessories to access the register [PATCH 08/14] tsec: arrange
> > the code to avoid useless function declaration [PATCH 09/14] tsec: use
> > general ethernet MII register struct(tsec_mii_t) [PATCH 10/14] tsec:
> > refactor the PHY code to make it reuseable [PATCH 11/14] PHY: add some
> > Vitesse phy support [PATCH 12/14] PHY: add some Broadcom phy support
> > [PATCH 13/14] PHY: add some Marvell phy support [PATCH 14/14] PHY: add
> > some misc phy code support
> >
> > Thanks,
> > Mingkai
> 
> I suggest we re-order these patches to first deal with tsec changes and refactor
> of the phy code.  After which we should introduce fman driver code that shares
> fsl_phy.c
> 
> These patches also break some fundamental rules about patches:
> 1. some patches aren't used by anything
> 2. some patches break functionality
> 

OK, I'll reorder the patchset and take care of the above rules in the next version.
Thanks for your comments.

Thanks,
Mingkai