From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v3 1/2] bus/pci: fix vfio mode Date: Mon, 30 Oct 2017 12:07:05 -0700 Message-ID: <938aa760-f957-62a7-792c-a97fece0a36c@intel.com> References: <3195804eda227dde6bb6d80122b2af25e071e1c1.1509367736.git.gaetan.rivet@6wind.com> <8492fe4cf1a8d6f15d389c9148e4942f1d060a40.1509381300.git.gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Jerin Jacob To: Gaetan Rivet , dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AF4A41B299 for ; Mon, 30 Oct 2017 20:07:34 +0100 (CET) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30/2017 10:26 AM, Ferruh Yigit wrote: > On 10/30/2017 9:36 AM, Gaetan Rivet wrote: >> From: Jerin Jacob >> >> Revert back to using VFIO_PRESENT as a marker to enable compilation >> of VFIO-related segments. >> >> Fixes: 279b581c897d ("vfio: expose functions") >> >> Signed-off-by: Jerin Jacob >> Signed-off-by: Gaetan Rivet > > Tested-by: Ferruh Yigit Opps, this still will break the build with kernel < 3.6 Because rte_vfio.h includes "linux/vfio.h" unconditionally, I am still for adding a version check in it to fix build for old kernels.