All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Scott Wood <oss@buserror.net>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 3/5] powerpc/mm: remove a redundant test in do_page_fault()
Date: Wed, 19 Apr 2017 14:56:28 +0200 (CEST)	[thread overview]
Message-ID: <938b8a2050fb08b92a609d78e8a213e2f4146f6d.1492606298.git.christophe.leroy@c-s.fr> (raw)
In-Reply-To: <cover.1492606297.git.christophe.leroy@c-s.fr>

The result of (trap == 0x400) is already in is_exec.

Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
---
 arch/powerpc/mm/fault.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/fault.c b/arch/powerpc/mm/fault.c
index 9d21e5fd383d..b56bf472db6d 100644
--- a/arch/powerpc/mm/fault.c
+++ b/arch/powerpc/mm/fault.c
@@ -213,7 +213,7 @@ int do_page_fault(struct pt_regs *regs, unsigned long address,
 	 * bits we are interested in.  But there are some bits which
 	 * indicate errors in DSISR but can validly be set in SRR1.
 	 */
-	if (trap == 0x400)
+	if (is_exec)
 		error_code &= 0x48200000;
 	else
 		is_write = error_code & DSISR_ISSTORE;
-- 
2.12.0

  parent reply	other threads:[~2017-04-19 12:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-19 12:56 [PATCH 0/5] powerpc/mm: some cleanup of do_page_fault() Christophe Leroy
2017-04-19 12:56 ` [PATCH 1/5] powerpc/mm: only call store_updates_sp() on stores in do_page_fault() Christophe Leroy
2017-04-24  9:10   ` Aneesh Kumar K.V
2017-06-05 10:21   ` [1/5] " Michael Ellerman
2017-04-19 12:56 ` [PATCH 2/5] powerpc/mm: split store_updates_sp() in two parts " Christophe Leroy
2017-04-24  9:11   ` Aneesh Kumar K.V
2017-06-02  9:26   ` Michael Ellerman
2017-06-02  9:39     ` Christophe LEROY
2017-06-02 12:11       ` Benjamin Herrenschmidt
2017-06-02 12:31         ` Christophe LEROY
2017-06-05 10:49           ` Michael Ellerman
2017-06-05 10:49             ` Michael Ellerman
2017-06-05 10:45       ` Michael Ellerman
2017-06-05 10:45         ` Michael Ellerman
2017-06-05 17:48         ` christophe leroy
2017-06-06 11:00           ` Michael Ellerman
2017-06-06 11:00             ` Michael Ellerman
2017-06-06 13:29             ` Christophe LEROY
2017-04-19 12:56 ` Christophe Leroy [this message]
2017-04-19 12:56 ` [PATCH 4/5] powerpc/mm: Evaluate user_mode(regs) only once " Christophe Leroy
2017-04-24  9:13   ` Aneesh Kumar K.V
2017-04-19 12:56 ` [PATCH 5/5] powerpc/mm: The 8xx doesn't call do_page_fault() for breakpoints Christophe Leroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=938b8a2050fb08b92a609d78e8a213e2f4146f6d.1492606298.git.christophe.leroy@c-s.fr \
    --to=christophe.leroy@c-s.fr \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=oss@buserror.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.